Changeset View
Changeset View
Standalone View
Standalone View
applets/digital-clock/package/contents/ui/configTimeZones.qml
| Show All 12 Lines | |||||
| 13 | * but WITHOUT ANY WARRANTY; without even the implied warranty of | 13 | * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| 14 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | 14 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| 15 | * GNU General Public License for more details. | 15 | * GNU General Public License for more details. | ||
| 16 | * | 16 | * | ||
| 17 | * You should have received a copy of the GNU General Public License | 17 | * You should have received a copy of the GNU General Public License | ||
| 18 | * along with this program. If not, see <http://www.gnu.org/licenses/> | 18 | * along with this program. If not, see <http://www.gnu.org/licenses/> | ||
| 19 | */ | 19 | */ | ||
| 20 | 20 | | |||
| 21 | import QtQuick 2.0 | 21 | import QtQuick 2.13 | ||
| 22 | import QtQuick.Controls 1.2 as QtControls | 22 | import QtQuick.Controls 2.13 as QQC2 | ||
ngraham: `import QtQuick.Controls 2.5 as QQC2` | |||||
Next plasma release can only depend on Qt 5.12 Please can you change accordingly davidedmundson: Next plasma release can only depend on Qt 5.12
Please can you change accordingly | |||||
| 23 | import QtQuick.Layouts 1.0 | 23 | import QtQuick.Layouts 1.0 | ||
| 24 | import QtQuick.Dialogs 1.1 | 24 | import QtQuick.Dialogs 1.1 | ||
| 25 | 25 | | |||
| 26 | import org.kde.plasma.private.digitalclock 1.0 | 26 | import org.kde.plasma.private.digitalclock 1.0 | ||
| 27 | import org.kde.plasma.core 2.0 as PlasmaCore | 27 | import org.kde.plasma.core 2.0 as PlasmaCore | ||
| 28 | import org.kde.kirigami 2.5 as Kirigami | 28 | import org.kde.kirigami 2.5 as Kirigami | ||
| 29 | 29 | | |||
| 30 | ColumnLayout { | 30 | ColumnLayout { | ||
| Show All 9 Lines | 39 | onSelectedTimeZonesChanged: { | |||
| 40 | if (selectedTimeZones.length === 0) { | 40 | if (selectedTimeZones.length === 0) { | ||
| 41 | messageWidget.visible = true; | 41 | messageWidget.visible = true; | ||
| 42 | 42 | | |||
| 43 | timeZones.selectLocalTimeZone(); | 43 | timeZones.selectLocalTimeZone(); | ||
| 44 | } | 44 | } | ||
| 45 | } | 45 | } | ||
| 46 | } | 46 | } | ||
| 47 | 47 | | |||
| 48 | // This is just for getting the column width | | |||
| 49 | QtControls.CheckBox { | | |||
| 50 | id: checkbox | | |||
| 51 | visible: false | | |||
| 52 | } | | |||
| 53 | | ||||
| 54 | Kirigami.InlineMessage { | 48 | Kirigami.InlineMessage { | ||
While you're doing some porting, this entire thing can be replaced with a Kirigami.InlineMessage which will drastically reduce the amount of code here, and you can also remove the PlasmaComponents import (PlasmaCore is still needed for units, unless you want to also port things to use Kirigami.Units instead) ngraham: While you're doing some porting, this entire thing can be replaced with a `Kirigami. | |||||
You can take my changes from D24853 kmaterka: You can take my changes from D24853 | |||||
| 55 | id: messageWidget | 49 | id: messageWidget | ||
| 56 | | ||||
| 57 | Layout.fillWidth: true | 50 | Layout.fillWidth: true | ||
| 58 | 51 | Layout.margins: Kirigami.Units.smallSpacing | |||
| 59 | type: Kirigami.MessageType.Warning | 52 | type: Kirigami.MessageType.Warning | ||
| 60 | text: i18n("At least one time zone needs to be enabled. 'Local' was enabled automatically.") | 53 | text: i18n("At least one time zone needs to be enabled. 'Local' was enabled automatically.") | ||
| 61 | | ||||
| 62 | showCloseButton: true | 54 | showCloseButton: true | ||
| 63 | } | 55 | } | ||
| 64 | 56 | | |||
| 65 | QtControls.TextField { | 57 | QQC2.TextField { | ||
| 66 | id: filter | 58 | id: filter | ||
| 67 | Layout.fillWidth: true | 59 | Layout.fillWidth: true | ||
| 68 | placeholderText: i18n("Search Time Zones") | 60 | placeholderText: i18n("Search Time Zones") | ||
| 69 | } | 61 | } | ||
| 70 | 62 | | |||
| 71 | QtControls.TableView { | 63 | Item { | ||
| 72 | id: timeZoneView | | |||
| 73 | | ||||
| 74 | signal toggleCurrent | | |||
| 75 | | ||||
| 76 | Layout.fillWidth: true | 64 | Layout.fillWidth: true | ||
| 77 | Layout.fillHeight: true | 65 | Layout.fillHeight: true | ||
| 78 | 66 | | |||
| 79 | Keys.onSpacePressed: toggleCurrent() | 67 | QQC2.ScrollView { | ||
| 68 | anchors.fill: parent | ||||
| 69 | clip: true | ||||
| 70 | Component.onCompleted: background.visible = true // enable border | ||||
ngraham: `units.largeSpacing` is preferable to hardcoded spacing values | |||||
| 71 | | ||||
| 72 | ListView { | ||||
| 73 | id: listView | ||||
| 74 | focus: true // keyboard navigation | ||||
| 75 | activeFocusOnTab: true // keyboard navigation | ||||
| 80 | 76 | | |||
| 81 | model: TimeZoneFilterProxy { | 77 | model: TimeZoneFilterProxy { | ||
| 82 | sourceModel: timeZones | 78 | sourceModel: timeZones | ||
| 83 | filterString: filter.text | 79 | filterString: filter.text | ||
| 84 | } | 80 | } | ||
| 85 | 81 | | |||
| 86 | QtControls.TableViewColumn { | 82 | delegate: QQC2.CheckDelegate { | ||
| 87 | role: "checked" | 83 | id: checkbox | ||
| 88 | width: checkbox.width | 84 | focus: true // keyboard navigation | ||
| 89 | delegate: | 85 | width: parent.width | ||
| 90 | QtControls.CheckBox { | 86 | text: !city || city.indexOf("UTC") === 0 ? comment : comment ? i18n("%1, %2 (%3)", city, region, comment) : i18n("%1, %2", city, region) | ||
| 91 | id: checkBox | 87 | checked: model.checked | ||
| 92 | anchors.centerIn: parent | 88 | onToggled: { | ||
| 93 | checked: styleData.value | 89 | model.checked = checkbox.checked | ||
| 94 | activeFocusOnTab: false // only let the TableView as a whole get focus | 90 | listView.currentIndex = index // highlight | ||
| 95 | onClicked: { | 91 | listView.forceActiveFocus() // keyboard navigation | ||
| 96 | //needed for model's setData to be called | | |||
| 97 | model.checked = checked; | | |||
| 98 | } | | |||
| 99 | | ||||
| 100 | Connections { | | |||
| 101 | target: timeZoneView | | |||
| 102 | onToggleCurrent: { | | |||
| 103 | if (styleData.row === timeZoneView.currentRow) { | | |||
| 104 | model.checked = !checkBox.checked | | |||
| 105 | } | | |||
| 106 | } | | |||
| 107 | } | | |||
| 108 | } | | |||
| 109 | | ||||
| 110 | resizable: false | | |||
| 111 | movable: false | | |||
| 112 | } | 92 | } | ||
| 113 | QtControls.TableViewColumn { | 93 | highlighted: ListView.isCurrentItem | ||
| 114 | role: "city" | | |||
| 115 | title: i18n("City") | | |||
| 116 | } | 94 | } | ||
| 117 | QtControls.TableViewColumn { | | |||
| 118 | role: "region" | | |||
| 119 | title: i18n("Region") | | |||
| 120 | } | 95 | } | ||
This is pretty hard to follow. I would recommend expanding it to a conventional if/else block for clarity. ngraham: This is pretty hard to follow. I would recommend expanding it to a conventional if/else block… | |||||
| 121 | QtControls.TableViewColumn { | | |||
| 122 | role: "comment" | | |||
| 123 | title: i18n("Comment") | | |||
| 124 | } | 96 | } | ||
| 125 | } | 97 | } | ||
| 126 | 98 | | |||
| 127 | RowLayout { | 99 | RowLayout { | ||
| 128 | Layout.fillWidth: true | 100 | Layout.fillWidth: true | ||
| 129 | QtControls.CheckBox { | 101 | QQC2.CheckBox { | ||
| 130 | id: enableWheelCheckBox | 102 | id: enableWheelCheckBox | ||
| 131 | text: i18n("Switch time zone with mouse wheel") | 103 | text: i18n("Switch time zone with mouse wheel") | ||
| 132 | } | 104 | } | ||
| 133 | } | 105 | } | ||
| 106 | | ||||
| 134 | } | 107 | } | ||
import QtQuick.Controls 2.5 as QQC2