Differential D25257 Diff 69598 src/search/dolphinquerymodel.cpp

Changeset View

Standalone View

src/search/dolphinquerymodel.cpp

This file was added.

1		/***************************************************************************
2		* Copyright (C) 2019 by Ismael Asensio <isma.af@mgmail.com> *
3		* *
4		* This program is free software; you can redistribute it and/or modify *
5		* it under the terms of the GNU General Public License as published by *
6		* the Free Software Foundation; either version 2 of the License, or *
7		* (at your option) any later version. *
8		* *
9		* This program is distributed in the hope that it will be useful, *
10		* but WITHOUT ANY WARRANTY; without even the implied warranty of *
11		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
12		* GNU General Public License for more details. *
13		* *
14		* You should have received a copy of the GNU General Public License *
15		* along with this program; if not, write to the *
16		* Free Software Foundation, Inc., *
17		* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA *
18		***************************************************************************/
19
20		#include "dolphinquerymodel.h"
21
22		#include <config-baloo.h>
23		#ifdef HAVE_BALOO
24		#include <Baloo/Query>
25		#endif
26
27		DolphinQueryModel DolphinQueryModel::fromBalooSearchUrl(const QUrl &searchUrl)
28		{
29		DolphinQueryModel model;
30		model.m_searchUrl = searchUrl;
31
32		#ifdef HAVE_BALOO
33		const Baloo::Query query = Baloo::Query::fromSearchUrl(searchUrl);
34
	brunsUnsubmitted Done not necessary, as already done by `Baloo::Query::fromSearchUrl()` bruns: not necessary, as already done by `Baloo::Query::fromSearchUrl()`
35		model.m_customDir = query.includeFolder();
36
37		model.m_searchText = query.searchString();
38
39		const QStringList types = query.types();
40		model.m_fileType = types.isEmpty() ? QString() : types.first();
41
42		const QStringList subTerms = query.searchString().split(' ', QString::SkipEmptyParts);
43		foreach (const QString& subTerm, subTerms) {
44		if (subTerm.startsWith(QLatin1String("filename:"))) {
45		const QString value = subTerm.mid(9);
46		model.m_searchText = value;
47		} else if (DolphinQueryModel::isSearchTerm(subTerm)) {
48		model.m_searchTerms << subTerm;
49		}
50		}
51		#endif
52		return model;
53		}
54
55		/* Checks if a given search term can be handled by DolphinFacetsWidget.
56		* This is a copy of `DolphinFacetsWidget::isRatingTerm()` method.
57		*/
	elvisangelaccioUnsubmitted Done Please move the documentation in the header file and add doxygen tags (`/** ... /`). I'd also "invert" the definition: is this class says this is a search them, then the UI (e.g. DolphinFacetsWidget) will be able to handle it. elvisangelaccio:* Please move the documentation in the header file and add doxygen tags (`/** ... */`). I'd also…
	brunsUnsubmitted Not Done The intention is to first factor the model out, i.e. no behavior changes. Afterwards, the model can be changed to e.g. use Baloo::AdvancedQueryParser, which splits out all terms with a prefix (modified, type, rating, ...). The Widget can then pick out the ones it handles specifically and keep the remainder verbatim. bruns: The intention is to first factor the model out, i.e. no behavior changes. Afterwards, the…
	elvisangelaccioUnsubmitted Not Done Ah right, I didn't realize this is copied from DolphinFacetsWidget's implementation. elvisangelaccio: Ah right, I didn't realize this is copied from DolphinFacetsWidget's implementation.
58		bool DolphinQueryModel::isSearchTerm(const QString& term)
59		{
60		static const QLatin1String searchTokens[] {
61		QLatin1String("modified>="),
62		QLatin1String("rating>=")
	brunsUnsubmitted Done Use a plain C array instead of a QList. bruns: Use a plain C array instead of a QList.
63		};
	brunsUnsubmitted Done add a comment this is a copy of the DolphinFacetsWidget::isRatingTerm() method. bruns: add a comment this is a copy of the DolphinFacetsWidget::isRatingTerm() method.
	elvisangelaccioUnsubmitted Not Done Why not a simpler `QStringList` ? elvisangelaccio: Why not a simpler `QStringList` ?
	brunsUnsubmitted Not Done `QLatin1String x[] = {...}` is definitely simpler then `QStringList`. bruns: `QLatin1String x[] = {...}` is definitely simpler then `QStringList`.
	elvisangelaccioUnsubmitted Not Done Well it's a bit... unusual, at least in dolphin we never use a plain C array of QLatin1Strings elvisangelaccio: Well it's a bit... unusual, at least in dolphin we never use a plain C array of QLatin1Strings
	brunsUnsubmitted Not Done Probably because iterating over a plain C array was awkward before C++11 range-based for loops. Array is preferred, as it needs no allocation and does one pointer dereference less. bruns: Probably because iterating over a plain C array was awkward before C++11 range-based for loops.
64
65		for (const auto &searchToken : searchTokens) {
66		if (term.startsWith(searchToken)) {
67		return true;
	brunsUnsubmitted Done `{` goes on the line above bruns: `{` goes on the line above
68		}
69		}
70		return false;
71		}