Differential D25187 Diff 69550 git/fileviewgitplugin.cpp

Changeset View

Standalone View

View Options

git/fileviewgitplugin.cpp

Context not available.
140 int index = -1; 140​ int index = -1;
141 while (++index < maxChars) { 141​ while (++index < maxChars) {
142 if (!device->getChar(&buffer[index])) { 142​ if (!device->getChar(&buffer[index])) {
143 buffer[index] = '\0'; 143​ if (device->waitForReadyRead(30000)) { // 30 seconds to be consistent with QProcess::waitForReadyRead default
elvisangelaccioUnsubmitted
Not Done

Aren't 30 seconds a bit too much? I'm worried about UI freezes in the worst case. Do we really need to wait this long?

elvisangelaccio: Aren't 30 seconds a bit too much? I'm worried about UI freezes in the worst case. Do we really…
macdemsAuthorUnsubmitted
Not Done

Probably it is too long. However, this number is default value for QProcess::waitForReadyRead, which is used e.g. in FileViewGitPlugin::beginRetrieval. This is why I put this number here. However, to me it can be easily reduced to e.g. 3 seconds or even half a second. If so, the change should be introduced both here and in FileViewGitPlugin::beginRetrieval.

macdems: Probably it is too long. However, this number is default value for `QProcess::waitForReadyRead`…
elvisangelaccioUnsubmitted
Done

I see. I'd put this information in a comment, e.g. "// 30 seconds because we need to match the QProcess::waitForReadyRead default"

elvisangelaccio: I see. I'd put this information in a comment, e.g. "// 30 seconds because we need to match the…
144 return index == 0 ? 0 : index + 1; 144​ --index;
145​ continue;
146​ } else {
147​ buffer[index] = '\0';
148​ return index <= 0 ? 0 : index + 1;
149​ }
145 } 150​ }
146 if (buffer[index] == '\0') { // line end or we put it there (see above) 151​ if (buffer[index] == '\0') { // line end or we put it there (see above)
147 return index + 1; 152​ return index + 1;
Context not available.