Differential D24893 Diff 69386 lookandfeel/contents/lockscreen/config.qml

Changeset View

Standalone View

View Options

lookandfeel/contents/lockscreen/config.qml

1import QtQuick 2.5 1​import QtQuick 2.5
2import QtQuick.Controls 2.5 as QQC2 2​import QtQuick.Controls 2.5 as QQC2
3import QtQuick.Layouts 1.1 3​import QtQuick.Layouts 1.1
4 4​
5RowLayout { 5​ColumnLayout {
6​ property alias cfg_alwaysShowClock: alwaysClock.checked
ngrahamUnsubmitted
Not Done

Make this a FormLayout since it now has multiple rows of items in it

ngraham: Make this a FormLayout since it now has multiple rows of items in it
broulikAuthorUnsubmitted
Not Done

Can't, really, as it has to be aligned wit the non QML bits and other UI elements out of the control of this item (see formAlignment comment)
(I also didn't bother tbh)

broulik: Can't, really, as it has to be aligned wit the non QML bits and other UI elements out of the…
6 property alias cfg_showMediaControls: showMediaControls.checked 7​ property alias cfg_showMediaControls: showMediaControls.checked
7 8​
9​ spacing: 0
10​
11​ RowLayout {
12​ spacing: units.largeSpacing / 2
13​
14​ QQC2.Label {
15​ Layout.minimumWidth: formAlignment - units.largeSpacing //to match wallpaper config...
16​ horizontalAlignment: Text.AlignRight
17​ text: i18nd("plasma_lookandfeel_org.kde.lookandfeel", "Clock:")
18​ }
19​ QQC2.CheckBox {
20​ id: alwaysClock
21​ text: i18ndc("plasma_lookandfeel_org.kde.lookandfeel", "verb, to show something", "Always show")
davidedmundsonUnsubmitted
Not Done

One thing Thomas always used to say was that if you have a checkbox it should be obvious what the opposite action is.

This currently sounds like if it's off, the clock will randomly start flashing like a 90's html <blink> tag.

davidedmundson: One thing Thomas always used to say was that if you have a checkbox it should be obvious what…
broulikAuthorUnsubmitted
Not Done

Can I have a <marquee> clock?
"Show when idle"? (Open to non-jargon suggestions)

broulik: Can I have a <marquee> clock? "Show when idle"? (Open to non-jargon suggestions)
22​ }
23​ Item {
24​ Layout.fillWidth: true
25​ }
26​ }
27​
28​ RowLayout {
8 spacing: units.largeSpacing / 2 29​ spacing: units.largeSpacing / 2
9 30​
10 QQC2.Label { 31​ QQC2.Label {
11 Layout.minimumWidth: formAlignment - units.largeSpacing //to match wallpaper config... 32​ Layout.minimumWidth: formAlignment - units.largeSpacing //to match wallpaper config...
12 horizontalAlignment: Text.AlignRight 33​ horizontalAlignment: Text.AlignRight
13 text: i18nd("plasma_lookandfeel_org.kde.lookandfeel", "Media controls:") 34​ text: i18nd("plasma_lookandfeel_org.kde.lookandfeel", "Media controls:")
14 } 35​ }
15 QQC2.CheckBox { 36​ QQC2.CheckBox {
16 id: showMediaControls 37​ id: showMediaControls
17 text: i18ndc("plasma_lookandfeel_org.kde.lookandfeel", "verb, to show something", "Show") 38​ text: i18ndc("plasma_lookandfeel_org.kde.lookandfeel", "verb, to show something", "Show")
18 } 39​ }
19 Item { 40​ Item {
20 Layout.fillWidth: true 41​ Layout.fillWidth: true
21 } 42​ }
22} 43​ }
44​}