Differential D25039 Diff 69082 src/ioslaves/http/kcookiejar/kcookieserver.h

Changeset View

Standalone View

View Options

src/ioslaves/http/kcookiejar/kcookieserver.h

Show First 20 Lines • Show All 97 Lines • ▼ Show 20 Line(s)96private:
98 KHttpCookieList *mPendingCookies; 98​ KHttpCookieList *mPendingCookies;
99 RequestList *mRequestList; 99​ RequestList *mRequestList;
100 QTimer *mTimer; 100​ QTimer *mTimer;
101 bool mAdvicePending; 101​ bool mAdvicePending;
102 KConfig *mConfig; 102​ KConfig *mConfig;
103 QString mFilename; 103​ QString mFilename;
104 104​
105private: 105​private:
106 virtual int newInstance(QList<QByteArray>) 106​ virtual int newInstance(const QList<QByteArray>&)
kossebauUnsubmitted
Not Done

As there is no override changed in this patch, I found this suspicious and had a look:
seems this is dead code once introduced in 2002, when KCookieServer had been made a DCOP object, and KUniqueApplication asked subclasses to implement a virtual "int newInstance();" method.
See https://phabricator.kde.org/R446:1276fdc2bdbf7fd0236b8630cc1e529e3a6c4fe5

Nothing is using this method anymore now, so it can instead be simply removed, in a separate commit.

kossebau: As there is no override changed in this patch, I found this suspicious and had a look: seems…
107 { 107​ {
108 return 0; 108​ return 0;
109 } 109​ }
110 bool cookieMatches(const KHttpCookie &, const QString &, const QString &, const QString &, const QString &); 110​ bool cookieMatches(const KHttpCookie &, const QString &, const QString &, const QString &, const QString &);
111 void putCookie(QStringList &, const KHttpCookie &, const QList<int> &); 111​ void putCookie(QStringList &, const KHttpCookie &, const QList<int> &);
112 void saveCookieJar(); 112​ void saveCookieJar();
113}; 113​};
114 114​
115#endif 115​#endif