Differential D25010 Diff 68975 autotests/jobremotetest.cpp

Changeset View

Standalone View

View Options

autotests/jobremotetest.cpp

Show First 20 Lines • Show All 61 Lines • ▼ Show 20 Line(s)
62#else 62​#else
63 // This one needs to be on another partition 63​ // This one needs to be on another partition
64 return QStringLiteral("/tmp/jobremotetest/"); 64​ return QStringLiteral("/tmp/jobremotetest/");
65#endif 65​#endif
66} 66​}
67 67​
68static bool myExists(const QUrl &url) 68​static bool myExists(const QUrl &url)
69{ 69​{
70 KIO::Job *job = KIO::stat(url, KIO::StatJob::DestinationSide, 0, KIO::HideProgressInfo); 70​ KIO::Job *job = KIO::stat(url, KIO::StatJob::DestinationSide, KIO::StatJob::Basic, KIO::HideProgressInfo);
kossebauUnsubmitted
Done

As reader of this code here alone, I wonder what KIO::StatJob::Basic means. To understand what this code does, I would first have to look at the API dox, not good.
So possibly Basic should get a different name, at least contain "Detail" term perhaps. "Basic" also needs context to have semantics, I could e.g. not tell instantly what basic details are. So perhaps needs to be more expliciti here.

kossebau: As reader of this code here alone, I wonder what KIO::StatJob::Basic means. To understand what…
mevenAuthorUnsubmitted
Done

I guess so, "Basic" here lacks context.
But the documentation will be much faster to get than before with the 0 field.

meven: I guess so, "Basic" here lacks context. But the documentation will be much faster to get than…
71 job->setUiDelegate(nullptr); 71​ job->setUiDelegate(nullptr);
72 return job->exec(); 72​ return job->exec();
73} 73​}
74 74​
75static bool myMkdir(const QUrl &url) 75​static bool myMkdir(const QUrl &url)
76{ 76​{
77 KIO::Job *job = KIO::mkdir(url, -1); 77​ KIO::Job *job = KIO::mkdir(url, -1);
78 job->setUiDelegate(nullptr); 78​ job->setUiDelegate(nullptr);
▲ Show 20 Lines • Show All 391 Lines • Show Last 20 Lines