Differential D24730 Diff 68534 kcms/ksplash/CMakeLists.txt

Changeset View

Standalone View

View Options

kcms/ksplash/CMakeLists.txt

1# KI18N Translation Domain for this library 1​# KI18N Translation Domain for this library
2add_definitions(-DTRANSLATION_DOMAIN=\"kcm_splashscreen\") 2​add_definitions(-DTRANSLATION_DOMAIN=\"kcm_splashscreen\")
3 3​
4set(kcm_splashscreen_SRCS 4​set(kcm_splashscreen_SRCS
5 kcm.cpp 5​ kcm.cpp
6) 6​)
7 7​
8​kconfig_add_kcfg_files(kcm_splashscreen_SRCS splashscreensettings.kcfgc GENERATE_MOC)
9​
8add_library(kcm_splashscreen MODULE ${kcm_splashscreen_SRCS}) 10​add_library(kcm_splashscreen MODULE ${kcm_splashscreen_SRCS})
9 11​
10target_link_libraries(kcm_splashscreen 12​target_link_libraries(kcm_splashscreen
11 KF5::KIOWidgets 13​ KF5::KIOWidgets
12 KF5::CoreAddons 14​ KF5::CoreAddons
13 KF5::QuickAddons 15​ KF5::QuickAddons
14 KF5::I18n 16​ KF5::I18n
15 KF5::Plasma 17​ KF5::Plasma
16 KF5::PlasmaQuick 18​ KF5::PlasmaQuick
17 KF5::NewStuff 19​ KF5::NewStuff
18 20​
19 Qt5::DBus 21​ Qt5::DBus
20 Qt5::Widgets 22​ Qt5::Widgets
21 Qt5::QuickWidgets 23​ Qt5::QuickWidgets
22) 24​)
23 25​
24kcoreaddons_desktop_to_json(kcm_splashscreen "kcm_splashscreen.desktop" SERVICE_TYPES kcmodule.desktop) 26​kcoreaddons_desktop_to_json(kcm_splashscreen "kcm_splashscreen.desktop" SERVICE_TYPES kcmodule.desktop)
25 27​
26#this desktop file is installed only for retrocompatibility with sycoca 28​#this desktop file is installed only for retrocompatibility with sycoca
29​install(FILES splashscreensettings.kcfg DESTINATION ${KDE_INSTALL_KCFGDIR})
apolUnsubmitted
Not Done

You don't need to install the kcfg file if you're generating it.

apol: You don't need to install the kcfg file if you're generating it.
crossiAuthorUnsubmitted
Not Done

kcfg file is not generated, it is used to generate class SplashScreenSettings

It was requested by davidedmundson on another review, thought I should add it as well.

crossi: kcfg file is not generated, it is used to generate class SplashScreenSettings It was requested…
ervinUnsubmitted
Not Done

I'm still not quite sure why it was requested to be honest. The reusability potential of those kcfgs is rather low in most cases.

ervin: I'm still not quite sure why it was requested to be honest. The reusability potential of those…
27install(FILES kcm_splashscreen.desktop DESTINATION ${KDE_INSTALL_KSERVICES5DIR}) 30​install(FILES kcm_splashscreen.desktop DESTINATION ${KDE_INSTALL_KSERVICES5DIR})
28install(TARGETS kcm_splashscreen DESTINATION ${KDE_INSTALL_PLUGINDIR}/kcms) ​
29install( FILES ksplash.knsrc DESTINATION ${KDE_INSTALL_KNSRCDIR} ) 31​install( FILES ksplash.knsrc DESTINATION ${KDE_INSTALL_KNSRCDIR} )
32​install(TARGETS kcm_splashscreen DESTINATION ${KDE_INSTALL_PLUGINDIR}/kcms)
30 33​
31kpackage_install_package(package kcm_splashscreen kcms) 34​kpackage_install_package(package kcm_splashscreen kcms)