Differential D4981 Diff 68452 plugins/subversion/kdevsvnplugin.cpp

Changeset View

Standalone View

View Options

plugins/subversion/kdevsvnplugin.cpp

Context not available.
235 const KDevelop::VcsRevision& dstRevision, 235​ const KDevelop::VcsRevision& dstRevision,
236 KDevelop::IBasicVersionControl::RecursionMode recurse) 236​ KDevelop::IBasicVersionControl::RecursionMode recurse)
237{ 237​{
238​ // TODO: support custom context lines in SvnDiffJob
238 auto* job = new SvnDiffJob(this); 239​ auto* job = new SvnDiffJob(this);
239 job->setSource(src); 240​ job->setSource(src);
kfunkUnsubmitted
Done

Why does this store contextLines into a member? That's totally cumbersome from a API POV.

kfunk: Why does this store `contextLines` into a member? That's totally cumbersome from a API POV.
rjvbbAuthorUnsubmitted
Done

I could indeed just as well have passed on the parameter to diff2() as an additional argument.

I take it then that you wouldn't be in favour of making the contextLines parameter a member variable of the base class, with a setter function so that it doesn't have to be passed around regardless of whether an implementation actually support it?

rjvbb: I could indeed just as well have passed on the parameter to diff2() as an additional argument.
240 job->setDestination(dst); 241​ job->setDestination(dst);
Context not available.