Differential D24723 Diff 68115 wallpapers/image/slidefiltermodel.cpp

Changeset View

Standalone View

View Options

wallpapers/image/slidefiltermodel.cpp

Show All 18 Lines
19#include "slidefiltermodel.h" 19​#include "slidefiltermodel.h"
20 20​
21#include "backgroundlistmodel.h" 21​#include "backgroundlistmodel.h"
22#include "slidemodel.h" 22​#include "slidemodel.h"
23 23​
24#include <QRandomGenerator> 24​#include <QRandomGenerator>
25#include <QFileInfo> 25​#include <QFileInfo>
26 26​
27​#include <algorithm>
28​
27SlideFilterModel::SlideFilterModel(QObject* parent) 29​SlideFilterModel::SlideFilterModel(QObject* parent)
28 : QSortFilterProxyModel{parent} 30​ : QSortFilterProxyModel{parent}
29 , m_SortingMode{Image::Random} 31​ , m_SortingMode{Image::Random}
30 , m_usedInConfig{false} 32​ , m_usedInConfig{false}
31{ 33​{
32 setSortCaseSensitivity(Qt::CaseSensitivity::CaseInsensitive); 34​ setSortCaseSensitivity(Qt::CaseSensitivity::CaseInsensitive);
33 connect(this, &SlideFilterModel::usedInConfigChanged, this, &SlideFilterModel::invalidateFilter); 35​ connect(this, &SlideFilterModel::usedInConfigChanged, this, &SlideFilterModel::invalidateFilter);
34} 36​}
35 37​
36bool SlideFilterModel::filterAcceptsRow(int source_row, const QModelIndex& source_parent) const 38​bool SlideFilterModel::filterAcceptsRow(int source_row, const QModelIndex& source_parent) const
37{ 39​{
38 auto index = sourceModel()->index(source_row, 0, source_parent); 40​ auto index = sourceModel()->index(source_row, 0, source_parent);
39 return m_usedInConfig || index.data(BackgroundListModel::ToggleRole).toBool(); 41​ return m_usedInConfig || index.data(BackgroundListModel::ToggleRole).toBool();
40} 42​}
41 43​
44​void SlideFilterModel::setSourceModel(QAbstractItemModel *sourceModel)
45​{
46​ if (this->sourceModel()) {
47​ disconnect(this->sourceModel(), nullptr, this, nullptr);
48​ }
49​ QSortFilterProxyModel::setSourceModel(sourceModel);
50​ if(sourceModel) {
51​ connect(sourceModel, &QAbstractItemModel::rowsInserted, this, &SlideFilterModel::invalidate);
broulikUnsubmitted
Done

Perhaps only invalidate if order is actually set to random?

I am actually not sure we need to invalidate at all when inserting items, unless you want to shuffle every time that happens? Perhaps all we need to do is shrink/grow the random vector when new items are added?

broulik: Perhaps only `invalidate` if order is actually set to random? I am actually not sure we need…
davidreAuthorUnsubmitted
Done

Good point. No need to invalidate in the other cases.

Maybe. It depends where images are added in the model? Maybe we would end up showing pictures again because the indexes have shifted? Or the new images are always shown at the end because they get appended? Either way I think that*'s not to bad if the order is set to Random. The result could also be the result of a random permutation.

davidre: Good point. No need to invalidate in the other cases. Maybe. It depends where images are added…
52​ connect(sourceModel, &QAbstractItemModel::rowsRemoved, this, &SlideFilterModel::invalidate);
53​ }
54​}
55​
42bool SlideFilterModel::lessThan(const QModelIndex& source_left, const QModelIndex& source_right) const 56​bool SlideFilterModel::lessThan(const QModelIndex& source_left, const QModelIndex& source_right) const
43{ 57​{
44 switch (m_SortingMode) { 58​ switch (m_SortingMode) {
45 case Image::Random: 59​ case Image::Random:
46 return (*QRandomGenerator::system())() % 2 == 0; 60​ return m_randomOrder.indexOf(source_left.row()) < m_randomOrder.indexOf(source_right.row());
47 case Image::Alphabetical: 61​ case Image::Alphabetical:
48 return QSortFilterProxyModel::lessThan(source_left, source_right); 62​ return QSortFilterProxyModel::lessThan(source_left, source_right);
49 case Image::AlphabeticalReversed: 63​ case Image::AlphabeticalReversed:
50 return !QSortFilterProxyModel::lessThan(source_left, source_right); 64​ return !QSortFilterProxyModel::lessThan(source_left, source_right);
51 case Image::Modified: // oldest first 65​ case Image::Modified: // oldest first
52 { 66​ {
53 QFileInfo f1(source_left.data(BackgroundListModel::PathRole).toUrl().toLocalFile()); 67​ QFileInfo f1(source_left.data(BackgroundListModel::PathRole).toUrl().toLocalFile());
54 QFileInfo f2(source_right.data(BackgroundListModel::PathRole).toUrl().toLocalFile()); 68​ QFileInfo f2(source_right.data(BackgroundListModel::PathRole).toUrl().toLocalFile());
55 return f1.lastModified() < f2.lastModified(); 69​ return f1.lastModified() < f2.lastModified();
56 } 70​ }
57 case Image::ModifiedReversed: // newest first 71​ case Image::ModifiedReversed: // newest first
58 { 72​ {
59 QFileInfo f1(source_left.data(BackgroundListModel::PathRole).toUrl().toLocalFile()); 73​ QFileInfo f1(source_left.data(BackgroundListModel::PathRole).toUrl().toLocalFile());
60 QFileInfo f2(source_right.data(BackgroundListModel::PathRole).toUrl().toLocalFile()); 74​ QFileInfo f2(source_right.data(BackgroundListModel::PathRole).toUrl().toLocalFile());
61 return !(f1.lastModified() < f2.lastModified()); 75​ return !(f1.lastModified() < f2.lastModified());
62 } 76​ }
63 } 77​ }
64 Q_UNREACHABLE(); 78​ Q_UNREACHABLE();
65} 79​}
66 80​
67void SlideFilterModel::setSortingMode(Image::SlideshowMode mode) 81​void SlideFilterModel::setSortingMode(Image::SlideshowMode mode)
68{ 82​{
69 m_SortingMode = mode; 83​ m_SortingMode = mode;
84​ if (mode == Image::Random) {
85​ buildRandomOrder();
86​ }
70 if (!(m_usedInConfig && mode == Image::Random)) { 87​ if (!(m_usedInConfig && mode == Image::Random)) {
71 QSortFilterProxyModel::invalidate(); 88​ QSortFilterProxyModel::invalidate();
72 } 89​ }
73} 90​}
91​void SlideFilterModel::invalidate()
92​{
93​ if (m_SortingMode == Image::Random) {
94​ buildRandomOrder();
95​ }
96​ QSortFilterProxyModel::invalidate();
97​}
74 98​
75void SlideFilterModel::invalidateFilter() 99​void SlideFilterModel::invalidateFilter()
76{ 100​{
77 QSortFilterProxyModel::invalidateFilter(); 101​ QSortFilterProxyModel::invalidateFilter();
78} 102​}
79 103​
80int SlideFilterModel::indexOf(const QString& path) 104​int SlideFilterModel::indexOf(const QString& path)
81{ 105​{
82 auto sourceIndex = sourceModel()->index(static_cast<SlideModel*>(sourceModel())->indexOf(path), 0); 106​ auto sourceIndex = sourceModel()->index(static_cast<SlideModel*>(sourceModel())->indexOf(path), 0);
83 return mapFromSource(sourceIndex).row(); 107​ return mapFromSource(sourceIndex).row();
84} 108​}
85 109​
86void SlideFilterModel::openContainingFolder(int rowIndex) 110​void SlideFilterModel::openContainingFolder(int rowIndex)
87{ 111​{
88 auto sourceIndex = mapToSource(index(rowIndex, 0)); 112​ auto sourceIndex = mapToSource(index(rowIndex, 0));
89 static_cast<SlideModel*>(sourceModel())->openContainingFolder(sourceIndex.row()); 113​ static_cast<SlideModel*>(sourceModel())->openContainingFolder(sourceIndex.row());
90} 114​}
115​
116​void SlideFilterModel::buildRandomOrder()
117​{
118​ if (m_SortingMode != Image::Random) {
broulikUnsubmitted
Done

Can sourceModel() be null here?

broulik: Can `sourceModel()` be null here?
119​ return;
120​ }
121​ m_randomOrder.resize(sourceModel()->rowCount());
122​ std::iota(m_randomOrder.begin(), m_randomOrder.end(), 0);
123​ std::random_shuffle(m_randomOrder.begin(), m_randomOrder.end());
124​}