Differential D24663 Diff 67973 src/server/plasmawindowmanagement_interface.cpp

Changeset View

Standalone View

View Options

src/server/plasmawindowmanagement_interface.cpp

Show First 20 Lines • Show All 732 Lines • ▼ Show 20 Line(s)732{
733 d->setPid(pid); 733​ d->setPid(pid);
734} 734​}
735 735​
736void PlasmaWindowInterface::setTitle(const QString &title) 736​void PlasmaWindowInterface::setTitle(const QString &title)
737{ 737​{
738 d->setTitle(title); 738​ d->setTitle(title);
739} 739​}
740 740​
741#ifndef KWAYLANDSERVER_NO_DEPRECATED ​
zzagUnsubmitted
Not Done

Hmm, PlasmaWindowInterface::setVirtualDesktop is wrapped in KWAYLANDSERVER_ENABLE_DEPRECATED_SINCE in the header file.

Is there a reason not to use KWAYLANDSERVER_BUILD_DEPRECATED_SINCE here?

zzag: Hmm, PlasmaWindowInterface::setVirtualDesktop is wrapped in…
kossebauAuthorUnsubmitted
Not Done

KWAYLANDSERVER_BUILD_DEPRECATED_SINCE are not available yet, cmp the comment in the commit message:
"No support for "EXCLUDE_DEPRECATED_BEFORE_AND_AT", needs to be done by
someone with detailed knowledge about disabling implementation, if wanted."

I tried to add it, but too much API got deprecated yet still kept being used internally. So a version-levelled disabling of implementation is not yet possible, first needs more cleanup of the internal usages.

kossebau: KWAYLANDSERVER_BUILD_DEPRECATED_SINCE are not available yet, cmp the comment in the commit…
742void PlasmaWindowInterface::setVirtualDesktop(quint32 desktop) 741​void PlasmaWindowInterface::setVirtualDesktop(quint32 desktop)
743{ 742​{
744 d->setVirtualDesktop(desktop); 743​ d->setVirtualDesktop(desktop);
745} 744​}
746#endif ​
747 745​
748void PlasmaWindowInterface::unmap() 746​void PlasmaWindowInterface::unmap()
749{ 747​{
750 d->wm->unmapWindow(this); 748​ d->wm->unmapWindow(this);
751} 749​}
752 750​
753QHash<SurfaceInterface*, QRect> PlasmaWindowInterface::minimizedGeometries() const 751​QHash<SurfaceInterface*, QRect> PlasmaWindowInterface::minimizedGeometries() const
754{ 752​{
▲ Show 20 Lines • Show All 97 Lines • ▼ Show 20 Line(s)849{
852 d->setState(ORG_KDE_PLASMA_WINDOW_MANAGEMENT_STATE_SKIPTASKBAR, set); 850​ d->setState(ORG_KDE_PLASMA_WINDOW_MANAGEMENT_STATE_SKIPTASKBAR, set);
853} 851​}
854 852​
855void PlasmaWindowInterface::setSkipSwitcher(bool skip) 853​void PlasmaWindowInterface::setSkipSwitcher(bool skip)
856{ 854​{
857 d->setState(ORG_KDE_PLASMA_WINDOW_MANAGEMENT_STATE_SKIPSWITCHER, skip); 855​ d->setState(ORG_KDE_PLASMA_WINDOW_MANAGEMENT_STATE_SKIPSWITCHER, skip);
858} 856​}
859 857​
860#ifndef KWAYLANDSERVER_NO_DEPRECATED ​
861void PlasmaWindowInterface::setThemedIconName(const QString &iconName) 858​void PlasmaWindowInterface::setThemedIconName(const QString &iconName)
862{ 859​{
863 d->setThemedIconName(iconName); 860​ d->setThemedIconName(iconName);
864} 861​}
865#endif ​
866 862​
867void PlasmaWindowInterface::setIcon(const QIcon &icon) 863​void PlasmaWindowInterface::setIcon(const QIcon &icon)
868{ 864​{
869 d->setIcon(icon); 865​ d->setIcon(icon);
870} 866​}
871 867​
872void PlasmaWindowInterface::addPlasmaVirtualDesktop(const QString &id) 868​void PlasmaWindowInterface::addPlasmaVirtualDesktop(const QString &id)
873{ 869​{
▲ Show 20 Lines • Show All 81 Lines • Show Last 20 Lines