Differential D21860 Diff 67643 gtkconfig/kded/gtkconfig.cpp

Changeset View

Standalone View

gtkconfig/kded/gtkconfig.cpp

This file was added.

1		/*
2		* Copyright (C) 2019 Mikhail Zolotukhin <zomial@protonmail.com>
3		* Copyright (C) 2019 Nicolas Fella <nicolas.fella@gmx.de>
4		*
5		* This program is free software; you can redistribute it and/or
6		* modify it under the terms of the GNU General Public License as
7		* published by the Free Software Foundation; either version 2 of
8		* the License or (at your option) version 3 or any later version
9		* accepted by the membership of KDE e.V. (or its successor approved
10		* by the membership of KDE e.V.), which shall act as a proxy
11		* defined in Section 14 of version 3 of the license.
12		*
13		* This program is distributed in the hope that it will be useful,
14		* but WITHOUT ANY WARRANTY; without even the implied warranty of
15		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16		* GNU General Public License for more details.
17		*
18		* You should have received a copy of the GNU General Public License
19		* along with this program. If not, see <http://www.gnu.org/licenses/>.
20		*/
21
22		#include "gtkconfig.h"
23
24		#include <QDebug>
25		#include <QFont>
26		#include <QtDBus/QDBusConnection>
27		#include <QGuiApplication>
28
29		#include <KPluginFactory>
30
31		K_PLUGIN_CLASS_WITH_JSON(GtkConfig, "gtkconfig.json")
32
33		GtkConfig::GtkConfig(QObject *parent, const QVariantList&) :
34		KDEDModule(parent), configEditor {new ConfigEditor()}
35		{
	broulikUnsubmitted Done We typically don't use braces for initializations, see https://techbase.kde.org/Policies/Frameworks_Coding_Style broulik: We typically don't use braces for initializations, see https://techbase.kde.
	gikariAuthorUnsubmitted Done Sure, I will change that and other initializations to curly brackets and equal signs, but I don't see any mention that brace initialization should be avoided in the coding style. May be I'm inconsiderate. gikari: Sure, I will change that and other initializations to curly brackets and equal signs, but I…
36		QGuiApplication qapp = static_cast<QGuiApplication >(QGuiApplication::instance());
37		connect(qapp, &QGuiApplication::fontChanged, this, &GtkConfig::setFont);
	broulikUnsubmitted Done The cast is pointless broulik: The cast is pointless
	gikariAuthorUnsubmitted Done Why? `QGuiApplication::instance()` returns `QCoreApplication` pointer, not `QGuiApplication` one. gikari: Why? `QGuiApplication::instance()` returns `QCoreApplication` pointer, not `QGuiApplication`…
38		}
39
	broulikUnsubmitted Done Remove, or use categorized logging broulik: Remove, or use categorized logging
40		void GtkConfig::setFont(const QFont &font)
41		{
42		const QString configFontName {getConfigFontName(font)};
43		configEditor->setGtk2ConfigValue("gtk-font-name", configFontName);
44		configEditor->setGtk3ConfigValueWayland("font-name", configFontName);
	broulikUnsubmitted Done const broulik: const
45		configEditor->setGtk3ConfigValueX11SettingsIni("gtk-font-name", configFontName);
46		configEditor->setGtk3ConfigValueX11XSettingsd("Gtk/FontName", configFontName);
47		}
48
49		QString GtkConfig::getConfigFontName(const QFont &font)
50		{
51		return font.family()
52		+ ' ' + font.styleName()
53		+ ' ' + QString::number(font.pointSize());
54		}
55
56		#include "gtkconfig.moc"