Differential D24191 Diff 66752 host/abstractbrowserplugin.h

Changeset View

Standalone View

View Options

host/abstractbrowserplugin.h

Show All 33 Lines33public:
34 ~AbstractBrowserPlugin() = default; 34​ ~AbstractBrowserPlugin() = default;
35 QString subsystem() const; 35​ QString subsystem() const;
36 int protocolVersion() const; 36​ int protocolVersion() const;
37 37​
38 bool isLoaded() const; 38​ bool isLoaded() const;
39 // FIXME this should not be public but we need to change it from main.cpp 39​ // FIXME this should not be public but we need to change it from main.cpp
40 void setLoaded(bool loaded); 40​ void setLoaded(bool loaded);
41 41​
42​ /**
43​ * Lets the plugin add additional status information to the getSubsystemStatus request
44​ *
45​ * E.g. whether a library dependency or external binary is present.
46​ */
47​ virtual QJsonObject status() const;
broulikAuthorUnsubmitted
Not Done

Not too happy about making it public, but it is used by Settings. Other alternative would be to make a getter in PluginManager which then calls this... or also making Settings a friend class

broulik: Not too happy about making it public, but it is used by `Settings`. Other alternative would be…
fvogtUnsubmitted
Not Done

I actually expect a method like this to be public

fvogt: I actually expect a method like this to be public
48​
42protected: 49​protected:
43 /* 50​ /*
44 * @arg subsystemId 51​ * @arg subsystemId
45 * The name of the plugin. This will be used for the "subsystem" parameter for all data sent 52​ * The name of the plugin. This will be used for the "subsystem" parameter for all data sent
46 * 53​ *
47 * @arg protocolVersion 54​ * @arg protocolVersion
48 * As the browser extension will be shipped separately to the native plugin a user could have incompatiable setups 55​ * As the browser extension will be shipped separately to the native plugin a user could have incompatiable setups
49 * Here we inform the browser of the protocol used so if we do ever changed the native API we can at least detect it on the JS side and handle it 56​ * Here we inform the browser of the protocol used so if we do ever changed the native API we can at least detect it on the JS side and handle it
Show All 27 Lines