Differential D24086 Diff 66497 kcmkwin/kwinrules/ruleswidget.cpp

Changeset View

Standalone View

View Options

kcmkwin/kwinrules/ruleswidget.cpp

Show First 20 Lines • Show All 580 Lines • ▼ Show 20 Line(s)
581{ 581​{
582 Rules* rules = new Rules(); 582​ Rules* rules = new Rules();
583 rules->description = description->text(); 583​ rules->description = description->text();
584 rules->wmclass = wmclass->text().toUtf8(); 584​ rules->wmclass = wmclass->text().toUtf8();
585 rules->wmclasscomplete = whole_wmclass->isChecked(); 585​ rules->wmclasscomplete = whole_wmclass->isChecked();
586 rules->wmclassmatch = static_cast< Rules::StringMatch >(wmclass_match->currentIndex()); 586​ rules->wmclassmatch = static_cast< Rules::StringMatch >(wmclass_match->currentIndex());
587 rules->windowrole = role->text().toUtf8(); 587​ rules->windowrole = role->text().toUtf8();
588 rules->windowrolematch = static_cast< Rules::StringMatch >(role_match->currentIndex()); 588​ rules->windowrolematch = static_cast< Rules::StringMatch >(role_match->currentIndex());
589 rules->types = nullptr; 589​ rules->types = {};
590 bool all_types = true; 590​ bool all_types = true;
apolUnsubmitted
Not Done

maybe using {} reads better?

apol: maybe using `{}` reads better?
591 for (int i = 0; 591​ for (int i = 0;
592 i < types->count(); 592​ i < types->count();
593 ++i) 593​ ++i)
594 if (!types->item(i)->isSelected()) 594​ if (!types->item(i)->isSelected())
595 all_types = false; 595​ all_types = false;
596 if (all_types) // if all types are selected, use AllTypesMask (for future expansion) 596​ if (all_types) // if all types are selected, use AllTypesMask (for future expansion)
597 rules->types = NET::AllTypesMask; 597​ rules->types = NET::AllTypesMask;
598 else { 598​ else {
▲ Show 20 Lines • Show All 372 Lines • Show Last 20 Lines