Differential D24011 Diff 66467 kcms/feedback/package/contents/ui/main.qml

Changeset View

Standalone View

View Options

kcms/feedback/package/contents/ui/main.qml

  • This file was added.
1​/*
2​ * Copyright (C) 2019 David Edmundson <davidedmundson@kde.org>
3​ * Copyright (C) 2019 Aleix Pol Gonzalez <aleixpol@kde.org>
4​ *
5​ * This library is free software; you can redistribute it and/or
6​ * modify it under the terms of the GNU Library General Public
7​ * License as published by the Free Software Foundation; either
8​ * version 2 of the License, or (at your option) any later version.
9​ *
10​ * This library is distributed in the hope that it will be useful,
11​ * but WITHOUT ANY WARRANTY; without even the implied warranty of
12​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
13​ * Library General Public License for more details.
14​ *
15​ * You should have received a copy of the GNU Library General Public License
16​ * along with this library; see the file COPYING.LIB. If not, write to
17​ * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
18​ * Boston, MA 02110-1301, USA.
19​*/
20​
21​import QtQuick 2.1
22​import QtQuick.Layouts 1.1
23​import QtQuick.Controls 2.3 as QtControls
ngrahamUnsubmitted
Not Done

"as QQC2"

ngraham: "as QQC2"
24​import org.kde.kirigami 2.6 as Kirigami
25​import org.kde.userfeedback 1.0 as UserFeedback
26​import org.kde.kcm 1.2
27​
28​SimpleKCM {
29​ id: root
30​
31​ ConfigModule.buttons: ConfigModule.Defaults | ConfigModule.Apply
32​ leftPadding: width * 0.1
33​ rightPadding: leftPadding
34​
davidedmundsonUnsubmitted
Not Done

Generally we only want a label if it's deliberately spanning and not associated with a control.

Otherwise, we want:

Kirigami.FormData.label: i18n("Blah blah:")
davidedmundson: Generally we only want a label if it's deliberately spanning and not associated with a control.
35​ ColumnLayout {
36​ QtControls.Label {
37​ Layout.leftMargin: Kirigami.Units.gridUnit
38​ Layout.rightMargin: Kirigami.Units.gridUnit
39​ Layout.fillWidth: true
40​ wrapMode: Text.WordWrap
41​ text: i18n("We make Plasma for you. You can help us improve it by contributing information on how you use it. This allows us to focus on things that matter to you.\n\nContributing usage information is optional and entirely anonymous. It will not associate the data with any kind of unique identifier, and will never track the documents you open, the websites you visit, or any other kind of personal information.\n\nYou can read more about our policy in the following link.")
ngrahamUnsubmitted
Done
  1. Since this is no longer just about Plasma, maybe the first sentence should say, "We make software for you".
  1. Use kuit formatting for newlines: xi18nc("@info", "Line 1<nl/>Line 2<nl/>Line 3<nl/>etc.");
ngraham: 1. Since this is no longer just about Plasma, maybe the first sentence should say, "We make…
ngrahamUnsubmitted
Not Done

#1 isn't done yet (it still talks about Plasma, not KDE software more generally)

ngraham: #1 isn't done yet (it still talks about Plasma, not KDE software more generally)
apolAuthorUnsubmitted
Not Done

But it's not true, only Plasma components will follow the setting. Only the checkbox will be used elsewhere. (hence the old ugly frame).

apol: But it's not true, only Plasma components will follow the setting. Only the checkbox will be…
42​ }
43​
44​ Kirigami.UrlButton {
45​ Layout.leftMargin: Kirigami.Units.gridUnit
46​ Layout.rightMargin: Kirigami.Units.gridUnit
ngrahamUnsubmitted
Not Done

This is aligned in a weird way. Let's come up with a better way to communicate this information. Maybe we could add it to the text block.

ngraham: This is aligned in a weird way. Let's come up with a better way to communicate this information.
47​ url: "https://kde.org/privacypolicy-apps.php"
ognarbUnsubmitted
Done

strange </p> tag in the text

ognarb: strange </p> tag in the text
48​ }
49​ Kirigami.FormLayout {
50​ Layout.topMargin: Kirigami.Units.gridUnit
51​ QtControls.CheckBox {
52​ Kirigami.FormData.label: i18n("Feedback:")
53​ checked: kcm.feedbackEnabled
54​ onToggled: kcm.feedbackEnabled = checked
55​ text: i18n("Allow KDE software to collect anomymous usage information")
56​ }
57​
58​ QtControls.ComboBox {
ngrahamUnsubmitted
Not Done

Ew gross, frames

ngraham: Ew gross, frames
59​ id: statisticsModeCombo
60​ Kirigami.FormData.label: i18n("Plasma:")
61​ enabled: kcm.feedbackEnabled
62​ Layout.fillWidth: true
63​ textRole: "text"
64​ model: ListModel { id: modeOptions }
65​
66​ Component.onCompleted: {
67​ modeOptions.append({text: i18n("Basic System Information"), value: UserFeedback.Provider.BasicSystemInformation})
68​ modeOptions.append({text: i18n("Basic Usage Information"), value: UserFeedback.Provider.BasicUsageStatistics})
69​ modeOptions.append({text: i18n("Detailed System Information"), value: UserFeedback.Provider.DetailedSystemInformation})
ngrahamUnsubmitted
Not Done

These strings still need to be re-worded, and possibly collapsed, and possible the whole UI needs to be re-thought. What if I want to submit detailed system information but only basic usage information? Maybe we need two combo boxes, one for system info and one for usage info.

ngraham: These strings still need to be re-worded, and possibly collapsed, and possible the whole UI…
apolAuthorUnsubmitted
Not Done

That's not how it's implemented in KUserfeedback.

enum TelemetryMode {
        NoTelemetry, ///< Transmit no data at all.
        BasicSystemInformation = 0x10, ///< Transmit basic information about the system.
        BasicUsageStatistics = 0x20, ///< Transmit basic usage statistics.
        DetailedSystemInformation = 0x30, ///< Transmit detailed system information.
        DetailedUsageStatistics = 0x40, ///< Transmit detailed usage statistics.
    };

DetailedSystemInformation = BasicUsageStatistics+BasicSystemInformation

And I don't think it's wrong. It's about making it easy for users to choose to help us learn about their behaviour.

apol: That's not how it's implemented in KUserfeedback. ``` enum TelemetryMode { NoTelemetry…
70​ modeOptions.append({text: i18n("Detailed Usage Information"), value: UserFeedback.Provider.DetailedUsageStatistics})
71​
72​ for(var i = 0, c=modeOptions.count; i<c; ++i) {
73​ if (modeOptions.get(i).value === kcm.plasmaFeedbackLevel) {
74​ currentIndex = i;
75​ break;
76​ }
77​ }
78​ if (currentIndex < 0)
79​ currentIndex = 2
80​ }
81​
82​ onActivated: {
83​ kcm.plasmaFeedbackLevel = modeOptions.get(index).value;
84​ }
85​ }
86​
87​ UserFeedback.FeedbackConfigUiController {
88​ id: feedbackController
89​ }
90​
ngrahamUnsubmitted
Not Done

This label never shows up for me, no matter which entry is selected in the combo box.

ngraham: This label never shows up for me, no matter which entry is selected in the combo box.
91​ QtControls.Label {
92​ Layout.maximumWidth: root.width * 0.75
93​ wrapMode: Text.WordWrap
94​ text: feedbackController.telemetryDescription(modeOptions.get(statisticsModeCombo.currentIndex).value)
95​ }
96​ }
97​ }
98​}
99​