Differential D24011 Diff 66291 kcms/feedback/package/contents/ui/main.qml

Changeset View

Standalone View

View Options

kcms/feedback/package/contents/ui/main.qml

  • This file was added.
1​/*
2​ * Copyright (C) 2019 David Edmundson <davidedmundson@kde.org>
3​ *
4​ * This library is free software; you can redistribute it and/or
5​ * modify it under the terms of the GNU Library General Public
6​ * License as published by the Free Software Foundation; either
7​ * version 2 of the License, or (at your option) any later version.
8​ *
9​ * This library is distributed in the hope that it will be useful,
10​ * but WITHOUT ANY WARRANTY; without even the implied warranty of
11​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
12​ * Library General Public License for more details.
13​ *
14​ * You should have received a copy of the GNU Library General Public License
15​ * along with this library; see the file COPYING.LIB. If not, write to
16​ * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
17​ * Boston, MA 02110-1301, USA.
18​*/
19​
20​import QtQuick 2.1
21​import QtQuick.Layouts 1.1
22​import QtQuick.Controls 2.3 as QtControls
23​import org.kde.kirigami 2.5 as Kirigami
24​import org.kde.userfeedback 1.0 as UserFeedback
ngrahamUnsubmitted
Not Done

"as QQC2"

ngraham: "as QQC2"
25​import org.kde.kcm 1.2
26​
27​SimpleKCM {
28​ id: root
29​
30​ ConfigModule.buttons: ConfigModule.Defaults | ConfigModule.Apply
31​
32​ Kirigami.FormLayout {
33​ QtControls.Label {
davidedmundsonUnsubmitted
Not Done

Generally we only want a label if it's deliberately spanning and not associated with a control.

Otherwise, we want:

Kirigami.FormData.label: i18n("Blah blah:")
davidedmundson: Generally we only want a label if it's deliberately spanning and not associated with a control.
34​ text: i18n("Telemetry enabled")
35​ }
36​
37​ QtControls.CheckBox {
38​ checked: kcm.feedbackEnabled
39​ onToggled: kcm.feedbackEnabled = checked
40​ }
41​
42​ QtControls.Label {
ngrahamUnsubmitted
Done
  1. Since this is no longer just about Plasma, maybe the first sentence should say, "We make software for you".
  1. Use kuit formatting for newlines: xi18nc("@info", "Line 1<nl/>Line 2<nl/>Line 3<nl/>etc.");
ngraham: 1. Since this is no longer just about Plasma, maybe the first sentence should say, "We make…
ngrahamUnsubmitted
Not Done

#1 isn't done yet (it still talks about Plasma, not KDE software more generally)

ngraham: #1 isn't done yet (it still talks about Plasma, not KDE software more generally)
apolAuthorUnsubmitted
Not Done

But it's not true, only Plasma components will follow the setting. Only the checkbox will be used elsewhere. (hence the old ugly frame).

apol: But it's not true, only Plasma components will follow the setting. Only the checkbox will be…
43​ enabled: kcm.feedbackEnabled
44​ Layout.fillWidth: true
45​ wrapMode: Text.WordWrap
46​ text: i18n("<p>We make Plasma for you. You can help us improve it by contributing information on how you use it.</p><p>This allows us to make sure we focus on things that matter to you. Contributing statistics is of course entirely anonymous, will not use any kind of unique identifier and will not cover any data you process with this application.</p><p><a href='https://kde.org/privacypolicy-apps.php'>https://kde.org/privacypolicy-apps.php</a></p>")
ngrahamUnsubmitted
Not Done

This is aligned in a weird way. Let's come up with a better way to communicate this information. Maybe we could add it to the text block.

ngraham: This is aligned in a weird way. Let's come up with a better way to communicate this information.
47​ onLinkActivated: Qt.openUrlExternally(link)
ognarbUnsubmitted
Done

strange </p> tag in the text

ognarb: strange </p> tag in the text
48​ }
49​ QtControls.ComboBox {
50​ id: statisticsModeCombo
51​ enabled: kcm.feedbackEnabled
52​ Layout.fillWidth: true
53​ currentIndex: 2
54​ textRole: "text"
55​ model: ListModel { id: modeOptions }
56​ Component.onCompleted: {
57​ modeOptions.append({text: i18n("No Statistics"), value: UserFeedback.Provider.NoStatistics})
58​ modeOptions.append({text: i18n("Basic System Information"), value: UserFeedback.Provider.BasicSystemInformation})
ngrahamUnsubmitted
Not Done

Ew gross, frames

ngraham: Ew gross, frames
59​ modeOptions.append({text: i18n("Basic Usage Information"), value: UserFeedback.Provider.BasicUsageStatistics})
60​ modeOptions.append({text: i18n("Detailed System Information"), value: UserFeedback.Provider.DetailedSystemInformation})
61​ modeOptions.append({text: i18n("Detailed Usage Information"), value: UserFeedback.Provider.DetailedUsageStatistics})
62​
63​ for(var i = 0, c=modeOptions.count; i<c; ++i) {
64​ if (modeOptions.get(i).value === kcm.plasmaFeedbackLevel) {
65​ currentIndex = i;
66​ break;
67​ }
68​ }
69​ }
ngrahamUnsubmitted
Not Done

These strings still need to be re-worded, and possibly collapsed, and possible the whole UI needs to be re-thought. What if I want to submit detailed system information but only basic usage information? Maybe we need two combo boxes, one for system info and one for usage info.

ngraham: These strings still need to be re-worded, and possibly collapsed, and possible the whole UI…
apolAuthorUnsubmitted
Not Done

That's not how it's implemented in KUserfeedback.

enum TelemetryMode {
        NoTelemetry, ///< Transmit no data at all.
        BasicSystemInformation = 0x10, ///< Transmit basic information about the system.
        BasicUsageStatistics = 0x20, ///< Transmit basic usage statistics.
        DetailedSystemInformation = 0x30, ///< Transmit detailed system information.
        DetailedUsageStatistics = 0x40, ///< Transmit detailed usage statistics.
    };

DetailedSystemInformation = BasicUsageStatistics+BasicSystemInformation

And I don't think it's wrong. It's about making it easy for users to choose to help us learn about their behaviour.

apol: That's not how it's implemented in KUserfeedback. ``` enum TelemetryMode { NoTelemetry…
70​
71​ onActivated: {
72​ kcm.plasmaFeedbackLevel = modeOptions.get(index).value;
73​ }
74​ }
75​ }
76​}
77​
ngrahamUnsubmitted
Not Done

This label never shows up for me, no matter which entry is selected in the combo box.

ngraham: This label never shows up for me, no matter which entry is selected in the combo box.