Differential D23615 Diff 65649 kcmkwin/kwinoptions/main.cpp

Changeset View

Standalone View

View Options

kcmkwin/kwinoptions/main.cpp

Show First 20 Lines • Show All 74 Lines • ▼ Show 20 Line(s)68{
75 75​
76 mFocus = new KFocusConfig(false, mConfig, this); 76​ mFocus = new KFocusConfig(false, mConfig, this);
77 mFocus->setObjectName(QLatin1String("KWin Focus Config")); 77​ mFocus->setObjectName(QLatin1String("KWin Focus Config"));
78 tab->addTab(mFocus, i18n("&Focus")); 78​ tab->addTab(mFocus, i18n("&Focus"));
79 connect(mFocus, SIGNAL(changed(bool)), this, SLOT(moduleChanged(bool))); 79​ connect(mFocus, SIGNAL(changed(bool)), this, SLOT(moduleChanged(bool)));
80 80​
81 mTitleBarActions = new KTitleBarActionsConfig(false, mConfig, this); 81​ mTitleBarActions = new KTitleBarActionsConfig(false, mConfig, this);
82 mTitleBarActions->setObjectName(QLatin1String("KWin TitleBar Actions")); 82​ mTitleBarActions->setObjectName(QLatin1String("KWin TitleBar Actions"));
83 tab->addTab(mTitleBarActions, i18n("&Titlebar Actions")); 83​ tab->addTab(mTitleBarActions, i18n("Titlebar A&ctions"));
84 connect(mTitleBarActions, SIGNAL(changed(bool)), this, SLOT(moduleChanged(bool))); 84​ connect(mTitleBarActions, SIGNAL(changed(bool)), this, SLOT(moduleChanged(bool)));
85 85​
86 mWindowActions = new KWindowActionsConfig(false, mConfig, this); 86​ mWindowActions = new KWindowActionsConfig(false, mConfig, this);
87 mWindowActions->setObjectName(QLatin1String("KWin Window Actions")); 87​ mWindowActions->setObjectName(QLatin1String("KWin Window Actions"));
88 tab->addTab(mWindowActions, i18n("Window Actio&ns")); 88​ tab->addTab(mWindowActions, i18n("W&indow Actions"));
89 connect(mWindowActions, SIGNAL(changed(bool)), this, SLOT(moduleChanged(bool))); 89​ connect(mWindowActions, SIGNAL(changed(bool)), this, SLOT(moduleChanged(bool)));
90 90​
91 mMoving = new KMovingConfig(false, mConfig, this); 91​ mMoving = new KMovingConfig(false, mConfig, this);
92 mMoving->setObjectName(QLatin1String("KWin Moving")); 92​ mMoving->setObjectName(QLatin1String("KWin Moving"));
93 tab->addTab(mMoving, i18n("&Moving")); 93​ tab->addTab(mMoving, i18n("Mo&vement"));
davidedmundsonUnsubmitted
Done

Where does this object name get used?

davidedmundson: Where does this object name get used?
GB_2AuthorUnsubmitted
Done

In the tab name.

GB_2: In the tab name.
GB_2AuthorUnsubmitted
Done

Oops, sorry, that's not really shere it's used. I'll have to see where.

GB_2: Oops, sorry, that's not really shere it's used. I'll have to see where.
GB_2AuthorUnsubmitted
Done

I can't see where it is used, it's probably not visible anywhere.

GB_2: I can't see where it is used, it's probably not visible anywhere.
davidedmundsonUnsubmitted
Done

It won't be in the ui.

An object name is an internal ID.

Which means either its used in some code and changing it will break things....or its unused.

From what I could see it happens to be unused.

davidedmundson: It won't be in the ui. An object name is an internal ID. Which means either its used in some…
GB_2AuthorUnsubmitted
Done

Should I keep this change then?

GB_2: Should I keep this change then?
94 connect(mMoving, SIGNAL(changed(bool)), this, SLOT(moduleChanged(bool))); 94​ connect(mMoving, SIGNAL(changed(bool)), this, SLOT(moduleChanged(bool)));
95 95​
96 mAdvanced = new KAdvancedConfig(false, mConfig, this); 96​ mAdvanced = new KAdvancedConfig(false, mConfig, this);
97 mAdvanced->setObjectName(QLatin1String("KWin Advanced")); 97​ mAdvanced->setObjectName(QLatin1String("KWin Advanced"));
98 tab->addTab(mAdvanced, i18n("Ad&vanced")); 98​ tab->addTab(mAdvanced, i18n("Adva&nced"));
99 connect(mAdvanced, SIGNAL(changed(bool)), this, SLOT(moduleChanged(bool))); 99​ connect(mAdvanced, SIGNAL(changed(bool)), this, SLOT(moduleChanged(bool)));
100 100​
101 KAboutData *about = 101​ KAboutData *about =
102 new KAboutData(QStringLiteral("kcmkwinoptions"), i18n("Window Behavior Configuration Module"), 102​ new KAboutData(QStringLiteral("kcmkwinoptions"), i18n("Window Behavior Configuration Module"),
103 QString(), QString(), KAboutLicense::GPL, 103​ QString(), QString(), KAboutLicense::GPL,
104 i18n("(c) 1997 - 2002 KWin and KControl Authors")); 104​ i18n("(c) 1997 - 2002 KWin and KControl Authors"));
105 105​
106 about->addAuthor(i18n("Matthias Ettrich"), QString(), "ettrich@kde.org"); 106​ about->addAuthor(i18n("Matthias Ettrich"), QString(), "ettrich@kde.org");
▲ Show 20 Lines • Show All 143 Lines • Show Last 20 Lines