Differential D23446 Diff 65487 src/Gui/CaptureAreaComboBox/CaptureModeModel.cpp

Changeset View

Standalone View

View Options

src/Gui/CaptureAreaComboBox/CaptureModeModel.cpp

  • This file was added.
1​#include "CaptureModeModel.h"
2​#include "SpectacleConfig.h"
3​
4​#include <QApplication>
5​
6​#include <kglobalaccel.h>
7​#include <KLocalizedString>
8​
9​#include <algorithm>
10​
11​CaptureModeModel::CaptureModeModel(const Platform::GrabModes &theGrabModes, QObject* parent) :
ngrahamAuthorUnsubmitted
Done

Put this with the other local include at the top

ngraham: Put this with the other local include at the top
12​ QAbstractListModel(parent)
13​{
14​ SpectacleConfig *config = SpectacleConfig::instance();
15​ KGlobalAccel *accelerator = KGlobalAccel::self();
16​
17​ std::vector<QAction*> availableActions;
18​ if (theGrabModes.testFlag(Platform::GrabMode::AllScreens)) {
19​ availableActions.push_back(config->shortCutActions->action(QStringLiteral("FullScreenScreenShot")));
20​ }
davidreUnsubmitted
Done

QKeySequence::NativeText would be maybe better. Use QString() instead of QStringLiteral("").

davidre: QKeySequence::NativeText would be maybe better. Use QString() instead of QStringLiteral("").
21​ if (theGrabModes.testFlag(Platform::GrabMode::CurrentScreen)) {
22​ availableActions.push_back(config->shortCutActions->action(QStringLiteral("CurrentMonitorScreenShot")));
23​ }
24​ if (theGrabModes.testFlag(Platform::GrabMode::ActiveWindow)) {
25​ availableActions.push_back(config->shortCutActions->action(QStringLiteral("ActiveWindowScreenShot")));
26​ }
davidreUnsubmitted
Done

Instead of duplicating the literals you can reuse the QAction::text().

davidre: Instead of duplicating the literals you can reuse the `QAction::text()`.
27​ if (theGrabModes.testFlag(Platform::GrabMode::WindowUnderCursor)) {
28​ availableActions.push_back(config->shortCutActions->action(QStringLiteral("WindowUnderCursorScreenShot")));
29​ }
30​ availableActions.push_back(config->shortCutActions->action(QStringLiteral("RectangularRegionScreenShot")));
31​
32​ for(QAction* action: availableActions) {
33​ QString label = action ? action->text().remove(QStringLiteral("Capture ")) : QString();
34​ QKeySequence shortcut = accelerator->hasShortcut(action) ? accelerator->shortcut(action)[0] : QKeySequence();
35​ modelData.push_back( {label, shortcut, action} );
36​ }
37​
38​ connect(accelerator, &KGlobalAccel::globalShortcutChanged, this, &CaptureModeModel::changeShortcut);
39​}
40​
41​int CaptureModeModel::rowCount(const QModelIndex &parent) const {
42​ Q_UNUSED(parent);
43​ return modelData.size();
44​}
45​
46​QHash<int, QByteArray> CaptureModeModel::roleNames() const {
47​ QHash<int, QByteArray> roleNames = QAbstractListModel::roleNames();
48​ roleNames.insert(ShortcutRole, "shortcut");
49​ roleNames.insert(ActionRole, "action");
50​ return roleNames;
davidreUnsubmitted
Done

Why 3?

davidre: Why 3?
Leon0402Unsubmitted
Done

Because the model has three columns, see the definition of modelEntry. The third property is not used in a visual context, but I think that doesn't matter?

Leon0402: Because the model has three columns, see the definition of modelEntry. The third property is…
51​}
52​
53​QVariant CaptureModeModel::data(const QModelIndex &index, int role) const {
54​ switch (role) {
55​ case Qt::DisplayRole: return modelData[index.row()].captureModeLabel;
ngrahamAuthorUnsubmitted
Done

Needs a comment explaining this magic number

ngraham: Needs a comment explaining this magic number
56​ case ShortcutRole: return modelData[index.row()].captureModeShortcut;
57​ case ActionRole: return modelData[index.row()].action->data();
58​ }
59​ return QVariant {};
60​}
61​
62​void CaptureModeModel::changeShortcut(QAction *action, const QKeySequence &seq) {
63​ auto modelEntryIterator = std::find_if(modelData.begin(), modelData.end(), [action](const ModelEntry& entry) {
64​ return (entry.action == action);
65​ });
66​ if(modelEntryIterator != modelData.end()) {
67​ (*modelEntryIterator).captureModeShortcut = seq;
68​ }
69​}
ngrahamAuthorUnsubmitted
Done

TODO:

canged -> changed

ngraham: `TODO:` canged -> changed