Differential D23446 Diff 65382 src/Gui/CaptureAreaComboBox/CaptureModeModel.cpp

Changeset View

Standalone View

View Options

src/Gui/CaptureAreaComboBox/CaptureModeModel.cpp

  • This file was added.
1​#include "CaptureModeModel.h"
2​#include "SpectacleConfig.h"
3​
4​#include <QApplication>
5​
6​#include <kglobalaccel.h>
7​#include <KLocalizedString>
8​
9​#include <algorithm>
10​
11​CaptureModeModel::CaptureModeModel(const Platform::GrabModes &theGrabModes, QObject* parent) :
ngrahamAuthorUnsubmitted
Done

Put this with the other local include at the top

ngraham: Put this with the other local include at the top
12​ QAbstractTableModel(parent),
13​ modelData()
14​{
15​ SpectacleConfig *lConfigMgr = SpectacleConfig::instance();
16​ KGlobalAccel *accelerator = KGlobalAccel::self();
17​
18​ if(theGrabModes.testFlag(Platform::GrabMode::AllScreens)) {
19​ QAction *fullScreenAction = lConfigMgr->shortCutActions->action(QStringLiteral("FullScreenScreenShot"));
20​ QString fullScreenLabel = QApplication::screens().count() == 1 ? i18n("Full Screen") : i18n("Full Screen (All Monitors)");
davidreUnsubmitted
Done

QKeySequence::NativeText would be maybe better. Use QString() instead of QStringLiteral("").

davidre: QKeySequence::NativeText would be maybe better. Use QString() instead of QStringLiteral("").
21​ QKeySequence shortcut = accelerator->hasShortcut(fullScreenAction) ? accelerator->shortcut(fullScreenAction)[0] : QKeySequence();
22​ modelData.push_back({fullScreenLabel, shortcut, Spectacle::CaptureMode::AllScreens});
23​ }
24​ if(theGrabModes.testFlag(Platform::GrabMode::CurrentScreen)) {
25​ QAction *currentScreenAction = lConfigMgr->shortCutActions->action(QStringLiteral("CurrentMonitorScreenShot"));
26​ QKeySequence shortcut = accelerator->hasShortcut(currentScreenAction) ? accelerator->shortcut(currentScreenAction)[0]: QKeySequence();
davidreUnsubmitted
Done

Instead of duplicating the literals you can reuse the QAction::text().

davidre: Instead of duplicating the literals you can reuse the `QAction::text()`.
27​ modelData.push_back({currentScreenAction->text(), shortcut, Spectacle::CaptureMode::CurrentScreen});
28​ }
29​ if (theGrabModes.testFlag(Platform::GrabMode::ActiveWindow)) {
30​ QAction *activeWindowAction = lConfigMgr->shortCutActions->action(QStringLiteral("ActiveWindowScreenShot"));
31​ QKeySequence shortcut = accelerator->hasShortcut(activeWindowAction) ? accelerator->shortcut(activeWindowAction)[0] : QKeySequence();
32​ modelData.push_back({activeWindowAction->text(), shortcut, Spectacle::CaptureMode::ActiveWindow});
33​ }
34​ if (theGrabModes.testFlag(Platform::GrabMode::WindowUnderCursor)) {
35​ QAction *windowUnderCursorAction = lConfigMgr->shortCutActions->action(QStringLiteral("WindowUnderCursorScreenShot"));
36​ QKeySequence shortcut = accelerator->hasShortcut(windowUnderCursorAction) ? accelerator->shortcut(windowUnderCursorAction)[0] : QKeySequence();
37​ modelData.push_back({windowUnderCursorAction->text(), shortcut, Spectacle::CaptureMode::WindowUnderCursor});
38​ }
39​ QAction *regionAction = lConfigMgr->shortCutActions->action(QStringLiteral("RectangularRegionScreenShot"));
40​ QKeySequence shortcut = accelerator->hasShortcut(regionAction) ? accelerator->shortcut(regionAction)[0] : QKeySequence();
41​ modelData.push_back({regionAction->text(), shortcut, Spectacle::CaptureMode::RectangularRegion});
42​
43​ connect(accelerator, &KGlobalAccel::globalShortcutChanged, this, &CaptureModeModel::changeShortcut);
44​}
45​
46​int CaptureModeModel::rowCount(const QModelIndex &parent) const {
47​ Q_UNUSED(parent);
48​ return modelData.size();
49​}
50​
davidreUnsubmitted
Done

Why 3?

davidre: Why 3?
Leon0402Unsubmitted
Done

Because the model has three columns, see the definition of modelEntry. The third property is not used in a visual context, but I think that doesn't matter?

Leon0402: Because the model has three columns, see the definition of modelEntry. The third property is…
51​int CaptureModeModel::columnCount(const QModelIndex &parent) const {
52​ Q_UNUSED(parent);
53​ //Model Entry has three members (=columns)
54​ return 3;
55​}
ngrahamAuthorUnsubmitted
Done

Needs a comment explaining this magic number

ngraham: Needs a comment explaining this magic number
56​
57​QVariant CaptureModeModel::data(const QModelIndex &index, int role) const {
58​ if(role == Qt::DisplayRole) {
59​ switch(index.column()) {
60​ case 0: return modelData[index.row()].captureModeLabel;
61​ case 1: return modelData[index.row()].captureModeShortcut;
62​ }
63​ } else if(role == Qt::UserRole) {
64​ return modelData[index.row()].captureMode;
65​ }
66​ return QVariant {};
67​}
68​
69​void CaptureModeModel::changeShortcut(QAction *action, const QKeySequence &seq) {
70​ //TO DO: captureModeLabel does not work for fullscreen as the label is changed there
71​ auto modelEntryIterator = std::find_if(modelData.begin(), modelData.end(), [action](const ModelEntry& entry) {
ngrahamAuthorUnsubmitted
Done

TODO:

canged -> changed

ngraham: `TODO:` canged -> changed
72​ return (entry.captureModeLabel == action->text());
73​ });
74​ if(modelEntryIterator != modelData.end()) {
75​ (*modelEntryIterator).captureModeShortcut = seq;
76​ }
77​}