Differential D23446 Diff 65360 src/Gui/CaptureAreaComboBox/CaptureModeModel.cpp

Changeset View

Standalone View

View Options

src/Gui/CaptureAreaComboBox/CaptureModeModel.cpp

  • This file was added.
1​#include "CaptureModeModel.h"
2​
3​#include <QApplication>
4​
5​#include <kglobalaccel.h>
6​#include <KLocalizedString>
7​
8​#include <algorithm>
9​
10​#include "SpectacleConfig.h"
11​
ngrahamAuthorUnsubmitted
Done

Put this with the other local include at the top

ngraham: Put this with the other local include at the top
12​CaptureModeModel::CaptureModeModel(const Platform::GrabModes &theGrabModes, QObject* parent) :
13​ QAbstractTableModel(parent),
14​ modelData()
15​{
16​ SpectacleConfig *lConfigMgr = SpectacleConfig::instance();
17​ KGlobalAccel *accelerator = KGlobalAccel::self();
18​
19​ if(theGrabModes.testFlag(Platform::GrabMode::AllScreens)) {
20​ QAction *fullScreenAction = lConfigMgr->shortCutActions->action(QStringLiteral("FullScreenScreenShot"));
davidreUnsubmitted
Done

QKeySequence::NativeText would be maybe better. Use QString() instead of QStringLiteral("").

davidre: QKeySequence::NativeText would be maybe better. Use QString() instead of QStringLiteral("").
21​ QString fullScreenLabel = QApplication::screens().count() == 1 ? i18n("Full Screen") : i18n("Full Screen (All Monitors)");
22​ QKeySequence shortcut = accelerator->hasShortcut(fullScreenAction) ? accelerator->shortcut(fullScreenAction)[0] : QKeySequence();
23​ modelData.push_back({fullScreenLabel, shortcut, Spectacle::CaptureMode::AllScreens});
24​ }
25​ if(theGrabModes.testFlag(Platform::GrabMode::CurrentScreen)) {
26​ QAction *currentScreenAction = lConfigMgr->shortCutActions->action(QStringLiteral("CurrentMonitorScreenShot"));
davidreUnsubmitted
Done

Instead of duplicating the literals you can reuse the QAction::text().

davidre: Instead of duplicating the literals you can reuse the `QAction::text()`.
27​ QKeySequence shortcut = accelerator->hasShortcut(currentScreenAction) ? accelerator->shortcut(currentScreenAction)[0]: QKeySequence();
28​ modelData.push_back({currentScreenAction->text(), shortcut, Spectacle::CaptureMode::CurrentScreen});
29​ }
30​ if (theGrabModes.testFlag(Platform::GrabMode::ActiveWindow)) {
31​ QAction *activeWindowAction = lConfigMgr->shortCutActions->action(QStringLiteral("ActiveWindowScreenShot"));
32​ QKeySequence shortcut = accelerator->hasShortcut(activeWindowAction) ? accelerator->shortcut(activeWindowAction)[0] : QKeySequence();
33​ modelData.push_back({activeWindowAction->text(), shortcut, Spectacle::CaptureMode::ActiveWindow});
34​ }
35​ if (theGrabModes.testFlag(Platform::GrabMode::WindowUnderCursor)) {
36​ QAction *windowUnderCursorAction = lConfigMgr->shortCutActions->action(QStringLiteral("WindowUnderCursorScreenShot"));
37​ QKeySequence shortcut = accelerator->hasShortcut(windowUnderCursorAction) ? accelerator->shortcut(windowUnderCursorAction)[0] : QKeySequence();
38​ modelData.push_back({windowUnderCursorAction->text(), shortcut, Spectacle::CaptureMode::WindowUnderCursor});
39​ }
40​ QAction *regionAction = lConfigMgr->shortCutActions->action(QStringLiteral("RectangularRegionScreenShot"));
41​ QKeySequence shortcut = accelerator->hasShortcut(regionAction) ? accelerator->shortcut(regionAction)[0] : QKeySequence();
42​ modelData.push_back({regionAction->text(), shortcut, Spectacle::CaptureMode::RectangularRegion});
43​
44​ connect(accelerator, &KGlobalAccel::globalShortcutChanged, this, &CaptureModeModel::changeShortcut);
45​}
46​
47​int CaptureModeModel::rowCount(const QModelIndex &parent) const {
48​ Q_UNUSED(parent);
49​ return modelData.size();
50​}
davidreUnsubmitted
Done

Why 3?

davidre: Why 3?
Leon0402Unsubmitted
Done

Because the model has three columns, see the definition of modelEntry. The third property is not used in a visual context, but I think that doesn't matter?

Leon0402: Because the model has three columns, see the definition of modelEntry. The third property is…
51​
52​int CaptureModeModel::columnCount(const QModelIndex &parent) const {
53​ Q_UNUSED(parent);
54​ return 3;
55​}
ngrahamAuthorUnsubmitted
Done

Needs a comment explaining this magic number

ngraham: Needs a comment explaining this magic number
56​
57​QVariant CaptureModeModel::data(const QModelIndex &index, int role) const {
58​ if(role == Qt::DisplayRole) {
59​ switch(index.column()) {
60​ case 0: return modelData[index.row()].captureModeLabel;
61​ case 1: return modelData[index.row()].captureModeShortcut;
62​ }
63​ } else if(role == Qt::UserRole) {
64​ return modelData[index.row()].captureMode;
65​ }
66​ return QVariant {};
67​}
68​
69​
70​
71​void CaptureModeModel::changeShortcut(QAction *action, const QKeySequence &seq) {
ngrahamAuthorUnsubmitted
Done

TODO:

canged -> changed

ngraham: `TODO:` canged -> changed
72​ //TO DO: captureModeLabel does not work for fullscreen as the label is canged there
73​ auto modelEntryIterator = std::find_if(modelData.begin(), modelData.end(), [action](const ModelEntry& entry) {
74​ return (entry.captureModeLabel == action->text());
75​ });
76​ if(modelEntryIterator == modelData.end()) {
77​ (*modelEntryIterator).captureModeShortcut = seq;
78​ }
79​}