Differential D21721 Diff 65219 src/attica/atticaprovider.cpp

Changeset View

Standalone View

View Options

src/attica/atticaprovider.cpp

Show All 11 Lines1/*
12 Lesser General Public License for more details. 12​ Lesser General Public License for more details.
13 13​
14 You should have received a copy of the GNU Lesser General Public 14​ You should have received a copy of the GNU Lesser General Public
15 License along with this library. If not, see <http://www.gnu.org/licenses/>. 15​ License along with this library. If not, see <http://www.gnu.org/licenses/>.
16*/ 16​*/
17 17​
18#include "atticaprovider_p.h" 18​#include "atticaprovider_p.h"
19 19​
20​#include "commentsmodel.h"
20#include "question.h" 21​#include "question.h"
21#include "tagsfilterchecker.h" 22​#include "tagsfilterchecker.h"
22 23​
23#include <QCollator> 24​#include <QCollator>
24#include <knewstuffcore_debug.h> 25​#include <knewstuffcore_debug.h>
25#include <klocalizedstring.h> 26​#include <klocalizedstring.h>
26 27​
27#include <attica/providermanager.h> 28​#include <attica/providermanager.h>
Show All 16 Lines44{
44 // init categories map with invalid categories 45​ // init categories map with invalid categories
45 for (const QString &category : categories) { 46​ for (const QString &category : categories) {
46 mCategoryMap.insert(category, Attica::Category()); 47​ mCategoryMap.insert(category, Attica::Category());
47 } 48​ }
48 49​
49 connect(&m_providerManager, &ProviderManager::providerAdded, this, &AtticaProvider::providerLoaded); 50​ connect(&m_providerManager, &ProviderManager::providerAdded, this, &AtticaProvider::providerLoaded);
50 connect(&m_providerManager, SIGNAL(authenticationCredentialsMissing(Provider)), 51​ connect(&m_providerManager, SIGNAL(authenticationCredentialsMissing(Provider)),
51 SLOT(authenticationCredentialsMissing(Provider))); 52​ SLOT(authenticationCredentialsMissing(Provider)));
53​ connect(this, &Provider::loadComments, this, &AtticaProvider::loadComments);
54​ connect(this, &Provider::loadPerson, this, &AtticaProvider::loadPerson);
52} 55​}
53 56​
54AtticaProvider::AtticaProvider(const Attica::Provider &provider, const QStringList &categories) 57​AtticaProvider::AtticaProvider(const Attica::Provider &provider, const QStringList &categories)
55 : mEntryJob(nullptr) 58​ : mEntryJob(nullptr)
56 , mInitialized(false) 59​ , mInitialized(false)
57{ 60​{
58 // init categories map with invalid categories 61​ // init categories map with invalid categories
59 for (const QString &category : categories) { 62​ for (const QString &category : categories) {
▲ Show 20 Lines • Show All 277 Lines • ▼ Show 20 Line(s)338 } else {
337 connect(job, &BaseJob::finished, this, &AtticaProvider::downloadItemLoaded); 340​ connect(job, &BaseJob::finished, this, &AtticaProvider::downloadItemLoaded);
338 mDownloadLinkJobs[job] = qMakePair(entry, linkId); 341​ mDownloadLinkJobs[job] = qMakePair(entry, linkId);
339 job->start(); 342​ job->start();
340 343​
341 qCDebug(KNEWSTUFFCORE) << " link for " << entry.uniqueId(); 344​ qCDebug(KNEWSTUFFCORE) << " link for " << entry.uniqueId();
342 } 345​ }
343} 346​}
344 347​
348​void AtticaProvider::loadComments(const EntryInternal &entry, int commentsPerPage, int page)
349​{
350​ ListJob<Attica::Comment> *job = m_provider.requestComments(Attica::Comment::ContentComment, entry.uniqueId(), QLatin1String("0"), page, commentsPerPage);
351​ connect(job, &BaseJob::finished, this, &AtticaProvider::loadedComments);
352​ job->start();
353​}
354​
355​/// TODO KF6 QList is discouraged, and we'll probably want to switch this (and the rest of the KNS library) to QVector instead
ahiemstraUnsubmitted
Done

Since upstream Qt is starting to discourage usage of QList, maybe use QVector instead.

ahiemstra: Since upstream Qt is starting to discourage usage of QList, maybe use QVector instead.
leinirAuthorUnsubmitted
Done

That'd be good, except the rest of the KNewStuff API is all QList based. It'll want doing for KF6, but since QList is being deprecated for that anyway, i'm thinking we'll end up with a general QList->QVector porting effort for that time anyway, and right now it'd just be introducing a different API style for seemingly no reason... Otherwise yes :)

leinir: That'd be good, except the rest of the KNewStuff API is all QList based. It'll want doing for…
ahiemstraUnsubmitted
Done

Fair enough. I do try to make sure to use vectors as much as possible in new API, but consistency is also a good argument. :)

ahiemstra: Fair enough. I do try to make sure to use vectors as much as possible in new API, but…
leinirAuthorUnsubmitted
Done

Think i might just pop in a TODO KF6 comment... just sort of make sure that even if it ends up not being a wholesale policy, we do it here :)

leinir: Think i might just pop in a TODO KF6 comment... just sort of make sure that even if it ends up…
356​QList<std::shared_ptr<KNSCore::Comment>> getCommentsList(const Attica::Comment::List &comments, std::shared_ptr<KNSCore::Comment> parent) {
357​ QList<std::shared_ptr<KNSCore::Comment>> knsComments;
358​ for (const Attica::Comment &comment : comments) {
359​ qCDebug(KNEWSTUFFCORE) << "Appending comment with id" << comment.id() << ", which has" << comment.childCount() << "children";
ahiemstraUnsubmitted
Done

Generally, it's recommended to use std::shared_ptr<KNSCore::Comment> knsComment = std::make_shared<KNSCore::Comment>(). As a bonus, that allows you to use auto knsComment.

ahiemstra: Generally, it's recommended to use `std::shared_ptr<KNSCore::Comment> knsComment = std…
leinirAuthorUnsubmitted
Done

Handy :) One of those places where i'm not opposed to auto, as it's easily read from the right hand side ;)

leinir: Handy :) One of those places where i'm not opposed to auto, as it's easily read from the right…
360​ auto knsComment = std::make_shared<KNSCore::Comment>();
361​ knsComment->id = comment.id();
362​ knsComment->subject = comment.subject();
363​ knsComment->text = comment.text();
364​ knsComment->childCount = comment.childCount();
365​ knsComment->username = comment.user();
366​ knsComment->date = comment.date();
367​ knsComment->score = comment.score();
368​ knsComment->parent = parent;
369​ knsComments << knsComment;
370​ if (comment.childCount() > 0) {
ahiemstraUnsubmitted
Done

Probably better to use categorised logging for this?

ahiemstra: Probably better to use categorised logging for this?
leinirAuthorUnsubmitted
Done

Actually leftovers... but also yes :)

leinir: Actually leftovers... but also yes :)
371​ qCDebug(KNEWSTUFFCORE) << "Getting more comments, as this one has children, and we currently have this number of comments:" << knsComments.count();
372​ knsComments << getCommentsList(comment.children(), knsComment);
373​ qCDebug(KNEWSTUFFCORE) << "After getting the children, we now have the following number of comments:" << knsComments.count();
374​ }
375​ }
376​ return knsComments;
377​}
378​
379​void AtticaProvider::loadedComments(Attica::BaseJob *baseJob)
380​{
381​ if (!jobSuccess(baseJob)) {
382​ return;
383​ }
384​
385​ ListJob<Attica::Comment> *job = static_cast<ListJob<Attica::Comment>*>(baseJob);
386​ Attica::Comment::List comments = job->itemList();
387​
388​ QList<std::shared_ptr<KNSCore::Comment>> receivedComments = getCommentsList(comments, nullptr);
389​ emit commentsLoaded(receivedComments);
390​}
391​
392​void AtticaProvider::loadPerson(const QString& username)
393​{
394​ if (m_provider.hasPersonService()) {
395​ ItemJob<Attica::Person> *job = m_provider.requestPerson(username);
396​ job->setProperty("username", username);
397​ connect(job, &BaseJob::finished, this, &AtticaProvider::loadedPerson);
398​ job->start();
399​ }
400​}
401​
402​void AtticaProvider::loadedPerson(Attica::BaseJob *baseJob)
403​{
404​ if (!jobSuccess(baseJob)) {
405​ return;
406​ }
407​
408​ ItemJob<Attica::Person> *job = static_cast<ItemJob<Attica::Person>*>(baseJob);
409​ Attica::Person person = job->result();
410​
ahiemstraUnsubmitted
Done

Like above, std::make_shared<KNSCore::Author>

ahiemstra: Like above, std::make_shared<KNSCore::Author>
411​ auto author = std::make_shared<KNSCore::Author>();
412​ author->setId(job->property("username").toString()); // This is a touch hack-like, but it ensures we actually have the data in case it is not returned by the server
413​ author->setName(QString::fromLatin1("%1 %2").arg(person.firstName()).arg(person.lastName()).trimmed());
414​ author->setHomepage(person.homepage());
415​ author->setProfilepage(person.extendedAttribute(QStringLiteral("profilepage")));
416​ author->setAvatarUrl(person.avatarUrl());
417​ author->setDescription(person.extendedAttribute(QStringLiteral("description")));
418​ emit personLoaded(author);
419​}
420​
345void AtticaProvider::accountBalanceLoaded(Attica::BaseJob *baseJob) 421​void AtticaProvider::accountBalanceLoaded(Attica::BaseJob *baseJob)
346{ 422​{
347 if (!jobSuccess(baseJob)) { 423​ if (!jobSuccess(baseJob)) {
348 return; 424​ return;
349 } 425​ }
350 426​
351 ItemJob<AccountBalance> *job = static_cast<ItemJob<AccountBalance>*>(baseJob); 427​ ItemJob<AccountBalance> *job = static_cast<ItemJob<AccountBalance>*>(baseJob);
352 AccountBalance item = job->result(); 428​ AccountBalance item = job->result();
▲ Show 20 Lines • Show All 144 Lines • ▼ Show 20 Line(s)535{
497 entry.setPreviewUrl(content.smallPreviewPicture(QStringLiteral("3")), EntryInternal::PreviewSmall3); 573​ entry.setPreviewUrl(content.smallPreviewPicture(QStringLiteral("3")), EntryInternal::PreviewSmall3);
498 574​
499 entry.setPreviewUrl(content.previewPicture(QStringLiteral("1")), EntryInternal::PreviewBig1); 575​ entry.setPreviewUrl(content.previewPicture(QStringLiteral("1")), EntryInternal::PreviewBig1);
500 entry.setPreviewUrl(content.previewPicture(QStringLiteral("2")), EntryInternal::PreviewBig2); 576​ entry.setPreviewUrl(content.previewPicture(QStringLiteral("2")), EntryInternal::PreviewBig2);
501 entry.setPreviewUrl(content.previewPicture(QStringLiteral("3")), EntryInternal::PreviewBig3); 577​ entry.setPreviewUrl(content.previewPicture(QStringLiteral("3")), EntryInternal::PreviewBig3);
502 578​
503 entry.setLicense(content.license()); 579​ entry.setLicense(content.license());
504 Author author; 580​ Author author;
581​ author.setId(content.author());
505 author.setName(content.author()); 582​ author.setName(content.author());
506 author.setHomepage(content.attribute(QStringLiteral("profilepage"))); 583​ author.setHomepage(content.attribute(QStringLiteral("profilepage")));
507 entry.setAuthor(author); 584​ entry.setAuthor(author);
508 585​
509 entry.setSource(EntryInternal::Online); 586​ entry.setSource(EntryInternal::Online);
510 entry.setSummary(content.description()); 587​ entry.setSummary(content.description());
511 entry.setShortSummary(content.summary()); 588​ entry.setShortSummary(content.summary());
512 entry.setChangelog(content.changelog()); 589​ entry.setChangelog(content.changelog());
Show All 22 Lines