Changeset View
Changeset View
Standalone View
Standalone View
src/wirelessdevice.h
Show First 20 Lines • Show All 123 Lines • ▼ Show 20 Line(s) | 47 | public: | |||
---|---|---|---|---|---|
124 | WirelessDevice::OperationMode mode() const; | 124 | WirelessDevice::OperationMode mode() const; | ||
125 | /** | 125 | /** | ||
126 | * Retrieves the effective bit rate currently attainable by this device. | 126 | * Retrieves the effective bit rate currently attainable by this device. | ||
127 | * | 127 | * | ||
128 | * @return the bitrate in Kbit/s | 128 | * @return the bitrate in Kbit/s | ||
129 | */ | 129 | */ | ||
130 | int bitRate() const; | 130 | int bitRate() const; | ||
131 | /** | 131 | /** | ||
132 | * The LastScan property value, converted to QDateTime | ||||
133 | * @since 5.62.0 | ||||
jgrulich: Add something like:
@note will always return invalid QDateTime when runtime NM < 1.12 | |||||
134 | * @note will always return invalid QDateTime when runtime NM < 1.12 | ||||
135 | * @return | ||||
136 | */ | ||||
137 | QDateTime lastScan() const; | ||||
138 | /** | ||||
139 | * The time the last RequestScan function was called | ||||
140 | * @since 5.62.0 | ||||
141 | * @return | ||||
142 | */ | ||||
143 | QDateTime lastRequestScanTime() const; | ||||
Thinking about it now, wouldn't be this wording better? QDateTime lastScanRequestTime() const; Maybe even without the "Time" at the end so it's consistent with "lastScan". jgrulich: Thinking about it now, wouldn't be this wording better?
QDateTime lastScanRequestTime() const… | |||||
I chose lastRequestScanTime to have RequestScan in the name, that is the function, it keeps the last time called from. The Time suffix does not feel great indeed. I can make an adjustment to lastRequestScan, I will adjust D23578 then meven: I chose lastRequestScanTime to have RequestScan in the name, that is the function, it keeps the… | |||||
jgrulich: Please do, you can push it directly, it's just a function rename. | |||||
meven: https://cgit.kde.org/networkmanager-qt.git/commit/?id=af98fdba63e32c38008592774436ae6c9b61cd90 | |||||
144 | /** | ||||
132 | * Retrieves the capabilities of this wifi network. | 145 | * Retrieves the capabilities of this wifi network. | ||
133 | * | 146 | * | ||
134 | * @return the flag set describing the capabilities | 147 | * @return the flag set describing the capabilities | ||
135 | * @see Capabilities | 148 | * @see Capabilities | ||
136 | */ | 149 | */ | ||
137 | WirelessDevice::Capabilities wirelessCapabilities() const; | 150 | WirelessDevice::Capabilities wirelessCapabilities() const; | ||
138 | 151 | | |||
139 | /** | 152 | /** | ||
▲ Show 20 Lines • Show All 65 Lines • ▼ Show 20 Line(s) | 179 | Q_SIGNALS: | |||
205 | /** | 218 | /** | ||
206 | * A wireless network appeared | 219 | * A wireless network appeared | ||
207 | */ | 220 | */ | ||
208 | void networkAppeared(const QString &ssid); | 221 | void networkAppeared(const QString &ssid); | ||
209 | /** | 222 | /** | ||
210 | * A wireless network disappeared | 223 | * A wireless network disappeared | ||
211 | */ | 224 | */ | ||
212 | void networkDisappeared(const QString &ssid); | 225 | void networkDisappeared(const QString &ssid); | ||
226 | /** | ||||
227 | * The LastScan property has changed, meaning a scan has just finished | ||||
228 | * @since 5.62.0 | ||||
229 | * @note will never be emitted when runtime NM < 1.12 | ||||
jgrulich: Add something like:
@note will never be emitted when runtime NM < 1.12 | |||||
230 | * @see lastScanTime | ||||
231 | */ | ||||
232 | void lastScanChanged(const QDateTime &dateTime); | ||||
jgrulich: const QDateTime ×tamp | |||||
213 | 233 | | |||
214 | private: | 234 | private: | ||
215 | Q_DECLARE_PRIVATE(WirelessDevice) | 235 | Q_DECLARE_PRIVATE(WirelessDevice) | ||
216 | }; | 236 | }; | ||
217 | 237 | | |||
218 | } // namespace NetworkManager | 238 | } // namespace NetworkManager | ||
219 | #endif //NETWORKMANAGERQT_WIRELESSDEVICE_H | 239 | #endif //NETWORKMANAGERQT_WIRELESSDEVICE_H | ||
220 | 240 | |
Add something like:
@note will always return invalid QDateTime when runtime NM < 1.12