Differential D21721 Diff 64855 src/qtquick/categoriesmodel.cpp

Changeset View

Standalone View

View Options

src/qtquick/categoriesmodel.cpp

  • This file was added.
1​/*
2​ * Copyright (C) 2019 Dan Leinir Turthra Jensen <admin@leinir.dk>
3​ *
4​ * This library is free software; you can redistribute it and/or
5​ * modify it under the terms of the GNU Lesser General Public
6​ * License as published by the Free Software Foundation; either
7​ * version 2.1 of the License, or (at your option) version 3, or any
8​ * later version accepted by the membership of KDE e.V. (or its
9​ * successor approved by the membership of KDE e.V.), which shall
10​ * act as a proxy defined in Section 6 of version 3 of the license.
11​ *
12​ * This library is distributed in the hope that it will be useful,
13​ * but WITHOUT ANY WARRANTY; without even the implied warranty of
14​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
15​ * Lesser General Public License for more details.
16​ *
17​ * You should have received a copy of the GNU Lesser General Public
18​ * License along with this library. If not, see <http://www.gnu.org/licenses/>.
19​ *
20​ */
21​
22​#include "categoriesmodel.h"
23​
24​#include "engine.h"
25​
26​#include <KLocalizedString>
27​
28​class CategoriesModel::Private {
29​public:
30​ Private() {}
31​ KNSCore::Engine* engine;
32​};
33​
34​CategoriesModel::CategoriesModel(Engine* parent)
35​ : QAbstractListModel(parent)
36​ , d(new Private)
37​{
38​ d->engine = qobject_cast<KNSCore::Engine*>(parent->engine());
39​ connect(d->engine, &KNSCore::Engine::signalCategoriesMetadataLoded, this, [this](){ beginResetModel(); endResetModel(); });
40​}
41​
42​CategoriesModel::~CategoriesModel()
43​{
44​ delete d;
45​}
46​
47​QHash<int, QByteArray> CategoriesModel::roleNames() const
48​{
49​ QHash<int, QByteArray> roles;
50​ roles[NameRole] = "name";
ahiemstraUnsubmitted
Done

Suggestion: I tend to make roles static since it doesn't change between instances anyway.
Like so:

static QHash<int, QByteArray> roles{
    { NameRole, "name" },
    ...
};
ahiemstra: Suggestion: I tend to make roles static since it doesn't change between instances anyway. Like…
leinirAuthorUnsubmitted
Not Done

Good call indeed, also perhaps a touch easier to read and such :) (also, this is what the QtQuick ItemsModel already does - i'll leave it to the new models, but probably wants proliferating through the codebase)

leinir: Good call indeed, also perhaps a touch easier to read and such :) (also, this is what the…
51​ roles[IdRole] = "id";
52​ roles[DisplayNameRole] = "displayName";
53​ return roles;
54​}
55​
56​int CategoriesModel::rowCount(const QModelIndex& parent) const
57​{
58​ if(parent.isValid()) {
59​ return 0;
60​ }
61​ return d->engine->categoriesMetadata().count() + 1;
62​}
63​
64​QVariant CategoriesModel::data(const QModelIndex& index, int role) const
65​{
66​ QVariant result;
67​ const QList<KNSCore::Provider::CategoryMetadata> categoriesMetadata = d->engine->categoriesMetadata();
68​ if (index.isValid()) {
69​ if (index.row() == 0) {
70​ switch (role) {
71​ case NameRole:
72​ result.setValue(QString::fromLatin1(""));
73​ break;
74​ case IdRole:
75​ result.setValue(0);
76​ break;
77​ case DisplayNameRole:
78​ result.setValue(i18nc("The first entry in the category selection list (also the default value)", "Show All Categories"));
79​ break;
80​ default:
81​ result.setValue(QString::fromLatin1("Unknown role"));
82​ break;
83​ }
84​ } else if (index.row() <= categoriesMetadata.count()) {
85​ const KNSCore::Provider::CategoryMetadata category = categoriesMetadata[index.row() - 1];
86​ switch (role) {
87​ case NameRole:
88​ result.setValue(category.name);
89​ break;
90​ case IdRole:
91​ result.setValue(category.id);
92​ break;
93​ case DisplayNameRole:
94​ result.setValue(category.displayName);
95​ break;
96​ default:
97​ result.setValue(QString::fromLatin1("Unknown role"));
98​ break;
99​ }
100​ }
101​ }
102​ return result;
103​}
104​
105​QVariant CategoriesModel::data(int index, int role) const
106​{
107​ return data(CategoriesModel::index(index), role);
108​}
109​
110​QString CategoriesModel::idToDisplayName(const QString& id) const
111​{
112​ QString dispName = i18nc("The string passed back in the case the requested category is not known", "Unknown Category");
113​ for (const KNSCore::Provider::CategoryMetadata& cat : d->engine->categoriesMetadata()) {
114​ if (cat.id == id) {
115​ dispName = cat.displayName;
116​ break;
117​ }
118​ }
119​ return dispName;
120​}