Changeset View
Standalone View
src/core/slavebase.h
Show First 20 Lines • Show All 328 Lines • ▼ Show 20 Line(s) | 63 | public: | |||
---|---|---|---|---|---|
329 | 329 | | |||
330 | /** | 330 | /** | ||
331 | * @internal for ForwardingSlaveBase | 331 | * @internal for ForwardingSlaveBase | ||
332 | * Contains all metadata (but no config) sent by the application to the slave. | 332 | * Contains all metadata (but no config) sent by the application to the slave. | ||
333 | */ | 333 | */ | ||
334 | MetaData allMetaData() const; | 334 | MetaData allMetaData() const; | ||
335 | 335 | | |||
336 | /** | 336 | /** | ||
337 | * Returns a map to query config/meta-data information | ||||
338 | * from. | ||||
339 | * | ||||
340 | * The application provides the slave with all configuration information | ||||
341 | * relevant for the current protocol and host. | ||||
342 | */ | ||||
dfaure: missing @since | |||||
dfaure: Time passed, this is for 5.63 now, sorry about that. | |||||
343 | QMap<QString, QString> *mapConfig(); | ||||
Why return a pointer, and why is this method not const? broulik: Why return a pointer, and why is this method not `const`?
Or is this supposed to be writable? | |||||
344 | | ||||
345 | /** | ||||
337 | * Returns a configuration object to query config/meta-data information | 346 | * Returns a configuration object to query config/meta-data information | ||
338 | * from. | 347 | * from. | ||
339 | * | 348 | * | ||
340 | * The application provides the slave with all configuration information | 349 | * The application provides the slave with all configuration information | ||
341 | * relevant for the current protocol and host. | 350 | * relevant for the current protocol and host. | ||
351 | * | ||||
352 | * TODO KF6: remove | ||||
353 | * @deprecated use mapConfig(StatSide side) | ||||
dfaure: @deprecated since 5.xx | |||||
dfaure: @deprecated since 5.63, use mapConfig() instead. | |||||
Can you update the docu as suggested above, to point more clearly to the replacement? This makes things easier for people doing porting. Thanks. dfaure: Can you update the docu as suggested above, to point more clearly to the replacement? This… | |||||
I have a @see mapConfig on the line below, did you see ? Or do you mean I should have all this on the same line. meven: I have a `@see mapConfig` on the line below, did you see ? Or do you mean I should have all… | |||||
342 | */ | 354 | */ | ||
343 | KConfigGroup *config(); | 355 | KIOCORE_DEPRECATED KConfigGroup *config(); | ||
Given there are still a few usages of config() left which seem not easily replaceable, it would be better to remove the deprecation tag for the compiler, to not have false warnings on those places (see e.g. http.cpp for certain usages still). kossebau: Given there are still a few usages of config() left which seem not easily replaceable, it would… | |||||
meven: Agreed, perhaps update the documentation slightly | |||||
344 | 356 | | |||
345 | /** | 357 | /** | ||
346 | * Returns an object that can translate remote filenames into proper | 358 | * Returns an object that can translate remote filenames into proper | ||
347 | * Unicode forms. This encoding can be set by the user. | 359 | * Unicode forms. This encoding can be set by the user. | ||
348 | */ | 360 | */ | ||
349 | KRemoteEncoding *remoteEncoding(); | 361 | KRemoteEncoding *remoteEncoding(); | ||
350 | 362 | | |||
351 | /////////// | 363 | /////////// | ||
▲ Show 20 Lines • Show All 637 Lines • Show Last 20 Lines |
missing @since