Differential D22062 Diff 64717 kdevplatform/outputview/outputfilteringstrategies.cpp

Changeset View

Standalone View

View Options

kdevplatform/outputview/outputfilteringstrategies.cpp

Show All 14 Lines1/*
15 You should have received a copy of the GNU General Public License 15​ You should have received a copy of the GNU General Public License
16 along with this program. If not, see <http://www.gnu.org/licenses/>. 16​ along with this program. If not, see <http://www.gnu.org/licenses/>.
17*/ 17​*/
18 18​
19#include "outputfilteringstrategies.h" 19​#include "outputfilteringstrategies.h"
20#include "outputformats.h" 20​#include "outputformats.h"
21#include "filtereditem.h" 21​#include "filtereditem.h"
22#include <util/path.h> 22​#include <util/path.h>
23 23​#include "debug.h"
24#include <KLocalizedString> 24​#include <KLocalizedString>
25 25​
26#include <QFileInfo> 26​#include <QFileInfo>
27​#include <QDir>
27 28​
28#include <algorithm> 29​#include <algorithm>
29 30​
30namespace KDevelop 31​namespace KDevelop
31{ 32​{
32void initializeFilteredItem(FilteredItem& item, const ErrorFormat& filter, const QRegularExpressionMatch& match) 33​void initializeFilteredItem(FilteredItem& item, const ErrorFormat& filter, const QRegularExpressionMatch& match)
33{ 34​{
34 item.lineNo = match.captured( filter.lineGroup ).toInt() - 1; 35​ item.lineNo = match.captured( filter.lineGroup ).toInt() - 1;
▲ Show 20 Lines • Show All 318 Lines • ▼ Show 20 Line(s)311 for (const auto& curErrFilter : ERROR_FILTERS) {
353 } 354​ }
354 } 355​ }
355 return item; 356​ return item;
356} 357​}
357 358​
358 359​
359/// --- Script error filter strategy --- 360​/// --- Script error filter strategy ---
360 361​
361ScriptErrorFilterStrategy::ScriptErrorFilterStrategy() 362​/// Impl. of ScriptErrorFilterStrategy.
363​class ScriptErrorFilterStrategyPrivate
364​{
365​public:
366​ explicit ScriptErrorFilterStrategyPrivate(const QUrl& scriptDir);
367​ Path m_scriptDir;
368​};
369​
370​ScriptErrorFilterStrategyPrivate::ScriptErrorFilterStrategyPrivate(const QUrl& scriptDir)
371​ : m_scriptDir(scriptDir)
372​{
373​ if( !m_scriptDir.isValid() ) {
374​ qCDebug(OUTPUTVIEW) << "Invalid scriptDir:" << scriptDir;
375​ }
376​}
377​
378​ScriptErrorFilterStrategy::~ScriptErrorFilterStrategy() = default;
379​
380​ScriptErrorFilterStrategy::ScriptErrorFilterStrategy(const QUrl& scriptDir)
381​ : d_ptr(new ScriptErrorFilterStrategyPrivate(scriptDir))
362{ 382​{
363} 383​}
364 384​
365FilteredItem ScriptErrorFilterStrategy::actionInLine(const QString& line) 385​FilteredItem ScriptErrorFilterStrategy::actionInLine(const QString& line)
366{ 386​{
367 return FilteredItem(line); 387​ return FilteredItem(line);
368} 388​}
369 389​
370FilteredItem ScriptErrorFilterStrategy::errorInLine(const QString& line) 390​FilteredItem ScriptErrorFilterStrategy::errorInLine(const QString& line)
371{ 391​{
372 // A list of filters for possible Python and PHP errors 392​ // A list of filters for possible Python and PHP errors
373 static const ErrorFormat SCRIPT_ERROR_FILTERS[] = { 393​ static const ErrorFormat SCRIPT_ERROR_FILTERS[] = {
394​ // php trigger_error message
395​ ErrorFormat( QStringLiteral(".*PHP\\s+(.*?):.* in\\s+(/.*) on line ([0-9]+)$"), 2, 3, 1, QStringLiteral("PHP") ),
396​ // php trigger_error stack trace
397​ // PHP 2. trigger_error() /home/proyect/yii:6
398​ ErrorFormat( QStringLiteral("^(PHP\\s+)[0-9]+\\.\\s+.*\\s+(/.*):([0-9]+)$"), 2, 3, 1, QStringLiteral("PHP") ),
399​ // PHP Uncaught Error
400​ ErrorFormat( QStringLiteral("^PHP.*(error):.* in (/.*):([0-9]+)$"), 2, 3, 1, QStringLiteral("PHP") ),
401​ // General framework rendered Error (Yii2::renderException, etc.)
402​ ErrorFormat( QStringLiteral("^([Ee]rror):.* in (/.*):([0-9]+)$"), 2, 3, 1, QStringLiteral("PHP") ),
403​ // PHP Uncaught Error stack trace
404​ // #0 /home/proyect/yii(6): bad()
405​ ErrorFormat( QStringLiteral("^\\#[0-9]+\\s+(/.*)\\(([0-9]+)\\):.*$"), 1, 2, -1, QStringLiteral("PHP") ),
406​ // PHP Uncaught Error stack trace, last thrown
407​ ErrorFormat( QStringLiteral("^(thrown) in\\s+(/.*) on line ([0-9]+)$"), 2, 3, 1, QStringLiteral("PHP") ),
408​ // Codeception summary failed tests
409​ ErrorFormat( QStringLiteral("^\\s*Test\\s+(.*):.*$"), 1, -1, -1, QStringLiteral("CodeCeption") ),
410​ // Codeception scenario steps
411​ // 4. $I->grabFixture("model","models0") at tests/functional/ModelsCest.php:43
412​ ErrorFormat( QStringLiteral("^.* at (.*):([0-9]+)$"), 1, 2, -1, QStringLiteral("CodeCeption") ),
413​ // Another stack trace format (seen with CodeCeption)
414​ // #0 /home/proyect/yii:6
415​ ErrorFormat( QStringLiteral("^(\\#[0-9]*\\s)\\s*(/.*):([0-9]+)$"), 2, 3, 0, QStringLiteral("PHP") ),
416​ // ungreedy with no trailing text, usually the output of the php function trigger_error()
417​ ErrorFormat( QStringLiteral("^.*\\.\\s+(/.*?):([0-9]+)$"), 1, 2, 0, QStringLiteral("PHP") ),
418​ // Codeception functional tests response
419​ ErrorFormat( QStringLiteral("^\\s*(Response:)\\s+(/.*)$"), 2, -1, 1),
374 ErrorFormat( QStringLiteral("^ File \"(.*)\", line ([0-9]+)(.*$|, in(.*)$)"), 1, 2, -1 ), 420​ ErrorFormat( QStringLiteral("^ File \"(.*)\", line ([0-9]+)(.*$|, in(.*)$)"), 1, 2, -1 ),
375 ErrorFormat( QStringLiteral("^.*(/.*):([0-9]+).*$"), 1, 2, -1 ), 421​ ErrorFormat( QStringLiteral("^.*(/.*):([0-9]+).*$"), 1, 2, -1 ),
376 ErrorFormat( QStringLiteral("^.* in (/.*) on line ([0-9]+).*$"), 1, 2, -1 ) 422​ ErrorFormat( QStringLiteral("^.* in (/.*) on line ([0-9]+).*$"), 1, 2, -1 ),
423​
377 }; 424​ };
425​ using Indicator = QPair<QString, FilteredItem::FilteredOutputItemType>;
426​ static const Indicator INDICATORS[] = {
427​ // PHP
428​// Indicator(QStringLiteral("Notice:"), FilteredItem::InformationItem),
429​// Indicator(QStringLiteral("thrown:"), FilteredItem::InformationItem),
430​// Indicator(QStringLiteral("PHP "), FilteredItem::InformationItem),
431​ Indicator(QStringLiteral("Warning"), FilteredItem::WarningItem),
432​ Indicator(QStringLiteral("error"), FilteredItem::ErrorItem),
433​ Indicator(QStringLiteral("Error"), FilteredItem::ErrorItem),
434​ Indicator(QStringLiteral("DEPRECATION"), FilteredItem::WarningItem),
435​ Indicator(QStringLiteral("Response:"), FilteredItem::WarningItem),
436​ Indicator(QStringLiteral("#1 "), FilteredItem::WarningItem),
437​ };
438​ FilteredItem item(line);
439​ for (const auto& curErrFilter : SCRIPT_ERROR_FILTERS) {
440​ const auto match = curErrFilter.expression.match(line);
441​ if( match.hasMatch() )
442​ {
443​ QString url;
444​ if(curErrFilter.fileGroup > 0) {
445​ url = match.captured( curErrFilter.fileGroup );
446​ QFileInfo fi(url);
447​ if( fi.isRelative() ) {
448​ item.url = Path(d_ptr->m_scriptDir, url).toUrl();
449​ } else {
450​ item.url = Path(url).toUrl();
451​ }
452​ }
453​ item.type = FilteredItem::InformationItem;
454​ initializeFilteredItem(item, curErrFilter, match);
455​ const QString txt = match.captured(curErrFilter.textGroup);
378 456​
379 return match(SCRIPT_ERROR_FILTERS, line); 457​ // Find the indicator which happens most early.
458​ if( txt.length() ) {
459​ int earliestIndicatorIdx = txt.length();
460​ for (const auto& curIndicator : INDICATORS) {
461​ int curIndicatorIdx = txt.indexOf(curIndicator.first, 0, Qt::CaseInsensitive);
462​ if((curIndicatorIdx >= 0) && (earliestIndicatorIdx > curIndicatorIdx)) {
463​ earliestIndicatorIdx = curIndicatorIdx;
464​ item.type = curIndicator.second;
465​ }
466​ }
467​ }
468​
469​ // Make the item clickable if it comes with the necessary file information
470​ if (item.url.isValid()) {
471​ item.isActivatable = true;
472​ if(item.type == FilteredItem::InvalidItem) {
473​ // Okay so we couldn't find anything to indicate an error, but we have file and lineGroup
474​ // Lets keep this item clickable and indicate this to the user.
475​ item.type = FilteredItem::InformationItem;
476​ }
477​ }
478​ break;
479​ }
480​ }
481​ return item;
380} 482​}
381 483​
382/// --- Native application error filter strategy --- 484​/// --- Native application error filter strategy ---
383 485​
384NativeAppErrorFilterStrategy::NativeAppErrorFilterStrategy() 486​NativeAppErrorFilterStrategy::NativeAppErrorFilterStrategy()
385{ 487​{
386} 488​}
387 489​
▲ Show 20 Lines • Show All 77 Lines • Show Last 20 Lines