Differential D23356 Diff 64410 plugins/process/taskmanager/taskmanager.cpp

Changeset View

Standalone View

plugins/process/taskmanager/taskmanager.cpp

This file was added.

1		/* This file is part of the KDE project
2
3		Copyright (C) 2019 David Edmundson <davidedmundson@kde.org>
4
5		This library is free software; you can redistribute it and/or
6		modify it under the terms of the GNU Library General Public
7		License as published by the Free Software Foundation; either
8		version 2 of the License, or (at your option) any later version.
9
10		This library is distributed in the hope that it will be useful,
11		but WITHOUT ANY WARRANTY; without even the implied warranty of
12		MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
13		Library General Public License for more details.
14
15		You should have received a copy of the GNU Library General Public License
16		along with this library; see the file COPYING.LIB. If not, write to
17		the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
18		Boston, MA 02110-1301, USA.
19		*/
20
21		#include "taskmanager.h"
22
23		#include <QGuiApplication>
24
	broulikUnsubmitted Done Unused broulik: Unused
25		#include <KLocalizedString>
26		#include <KPluginFactory>
27
28		#include <processcore/process.h>
29		#include <processcore/process_attribute.h>
30
31		#include <taskmanager/windowtasksmodel.h>
32		#include <taskmanager/abstracttasksmodel.h>
33
34		using namespace KSysGuard;
35
36		TaskManagerIntegration::TaskManagerIntegration(QObject *parent, const QVariantList &args)
37		: ProcessDataProvider(parent, args)
38		{
39		if (!QGuiApplication::instance()) {
40		return;
41		}
42		m_model = new TaskManager::WindowTasksModel(this);
43
44		m_iconAttribute = new ProcessAttribute(QStringLiteral("windowIcon"), i18n("Window Icon"), this);
45		addProcessAttribute(m_iconAttribute);
46
47		m_titleAttribute = new ProcessAttribute(QStringLiteral("windowTitle"), i18n("Window Title"), this);
48		addProcessAttribute(m_titleAttribute);
49
50		m_appIdAttribute = new ProcessAttribute(QStringLiteral("appId"), i18n("Application ID"), this);
51		addProcessAttribute(m_appIdAttribute);
52
53		auto updateRows = [this](int first, int last) {
54		for (int i = first ; i <= last; i++) {
55		const QModelIndex index = m_model->index(i, 0, QModelIndex());
56		attachPidToTMIndex(index.data(TaskManager::AbstractTasksModel::AppPid).toLongLong(), index);
57		}
58		};
59
	broulikUnsubmitted Done `attachPidToTMIndex` already checks for `IsWindow` unless you want to save a pointless `AppPid` call broulik: `attachPidToTMIndex` already checks for `IsWindow` unless you want to save a pointless `AppPid`…
60		connect(m_model, &QAbstractItemModel::rowsInserted, this, [updateRows](const QModelIndex &parent, int first, int last) {
61		Q_UNUSED(parent)
62		updateRows(first, last);
63		});
64
65		connect(m_model, &QAbstractItemModel::modelReset, this, [this, updateRows]() {
66		if (m_model->rowCount() > 0) {
67		updateRows(0, m_model->rowCount() -1);
68		}
69		});
70
71		connect(m_model, &QAbstractItemModel::dataChanged, this, [updateRows](const QModelIndex &topLeft, const QModelIndex &bottomRight, const QVector<int> &roles ) {
72		if (roles.isEmpty() \|\| roles.contains(Qt::DisplayRole) \|\| roles.contains(Qt::DecorationRole) \|\| roles.contains(TaskManager::AbstractTasksModel::AppId)) {
73		updateRows(topLeft.row(), bottomRight.row());
	broulikUnsubmitted Done `rowCount() - 1` because you go `i <= last` broulik: `rowCount() - 1` because you go `i <= last`
74		}
75		});
76
77		if (m_model->rowCount() > 0) {
78		updateRows(0, m_model->rowCount() -1);
	broulikUnsubmitted Done Roles can potentially be empty indicating all roles are dirty? Also, what about `DecorationRole`, in case it's window pixmap. broulik: Roles can potentially be empty indicating all roles are dirty? Also, what about…
79		}
80		}
81
82		void TaskManagerIntegration::attachPidToTMIndex(long pid, const QModelIndex &index)
83		{
84		auto process = getProcess(pid);
	broulikUnsubmitted Done `rowCount() - 1` broulik: `rowCount() - 1`
85		if (!process) {
86		return;
87		}
88		if (!index.data(TaskManager::AbstractTasksModel::IsWindow).toBool()) {
89		return;
90		}
91
92		m_appIdAttribute->setData(process, index.data(TaskManager::AbstractTasksModel::AppId));
93		m_titleAttribute->setData(process, index.data(Qt::DisplayRole));
94		m_iconAttribute->setData(process, index.data(Qt::DecorationRole));
95		}
96
97		K_PLUGIN_FACTORY_WITH_JSON(PluginFactory, "taskmanager.json", registerPlugin<TaskManagerIntegration>();)
98
99		#include "taskmanager.moc"
	broulikUnsubmitted Done This role is a `QIcon`, potentially created from the window pixmap in case window mapping failed. Or is that what the "tiny mods in ProcessModel" is about? broulik: This role is a `QIcon`, potentially created from the window pixmap in case window mapping…
	davidedmundsonAuthorUnsubmitted Done Yeah, and I need to map it to there decoration role on a different row. Kinda messy and against the spirit of plugins, but it still helps the code davidedmundson: Yeah, and I need to map it to there decoration role on a different row. Kinda messy and against…