Changeset View
Changeset View
Standalone View
Standalone View
src/qml/ElisaMainWindow.qml
| Show First 20 Lines • Show All 177 Lines • ▼ Show 20 Line(s) | 177 | HeaderBar { | |||
|---|---|---|---|---|---|
| 178 | id: headerBar | 178 | id: headerBar | ||
| 179 | 179 | | |||
| 180 | focus: true | 180 | focus: true | ||
| 181 | 181 | | |||
| 182 | Layout.minimumHeight: mainWindow.height * 0.2 + elisaTheme.mediaPlayerControlHeight | 182 | Layout.minimumHeight: mainWindow.height * 0.2 + elisaTheme.mediaPlayerControlHeight | ||
| 183 | Layout.maximumHeight: mainWindow.height * 0.2 + elisaTheme.mediaPlayerControlHeight | 183 | Layout.maximumHeight: mainWindow.height * 0.2 + elisaTheme.mediaPlayerControlHeight | ||
| 184 | Layout.fillWidth: true | 184 | Layout.fillWidth: true | ||
| 185 | 185 | | |||
| 186 | tracksCount: elisa.manageHeaderBar.remainingTracks | 186 | tracksCount: elisa.mediaPlayList.remainingTracks | ||
mgallien: As is, your patch is somehow pushing for a removal of ManageHeaderBar class that would serve no… | |||||
| 187 | album: elisa.manageHeaderBar.album | 187 | album: elisa.manageHeaderBar.album | ||
| 188 | title: elisa.manageHeaderBar.title | 188 | title: elisa.manageHeaderBar.title | ||
| 189 | artist: elisa.manageHeaderBar.artist | 189 | artist: elisa.manageHeaderBar.artist | ||
| 190 | albumArtist: elisa.manageHeaderBar.albumArtist | 190 | albumArtist: elisa.manageHeaderBar.albumArtist | ||
| 191 | image: elisa.manageHeaderBar.image | 191 | image: elisa.manageHeaderBar.image | ||
| 192 | albumID: elisa.manageHeaderBar.albumId | 192 | albumID: elisa.manageHeaderBar.albumId | ||
| 193 | 193 | | |||
| 194 | ratingVisible: false | 194 | ratingVisible: false | ||
| ▲ Show 20 Lines • Show All 138 Lines • Show Last 20 Lines | |||||
As is, your patch is somehow pushing for a removal of ManageHeaderBar class that would serve no purpose.
I am not sure that is desirable though.
Could you please explain in the commit message what is the reason for such changes ?