Differential D23356 Diff 64326 plugins/process/taskmanager/taskmanager.cpp

Changeset View

Standalone View

plugins/process/taskmanager/taskmanager.cpp

This file was added.

1		/* This file is part of the KDE project
2
3		Copyright (C) 2019 David Edmundson <davidedmundson@kde.org>
4
5		This library is free software; you can redistribute it and/or
6		modify it under the terms of the GNU Library General Public
7		License as published by the Free Software Foundation; either
8		version 2 of the License, or (at your option) any later version.
9
10		This library is distributed in the hope that it will be useful,
11		but WITHOUT ANY WARRANTY; without even the implied warranty of
12		MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
13		Library General Public License for more details.
14
15		You should have received a copy of the GNU Library General Public License
16		along with this library; see the file COPYING.LIB. If not, write to
17		the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
18		Boston, MA 02110-1301, USA.
19		*/
20
21		#include "taskmanager.h"
22
23		#include <QDebug>
	broulikUnsubmitted Done Unused broulik: Unused
24		#include <QGuiApplication>
25
26		#include <KLocalizedString>
27		#include <KPluginFactory>
28
29		#include <processcore/process.h>
30		#include <processcore/process_attribute.h>
31
32		#include <taskmanager/tasksmodel.h>
33		#include <taskmanager/abstracttasksmodel.h>
34
35		using namespace KSysGuard;
36
37		TaskManagerIntegration::TaskManagerIntegration(QObject *parent, const QVariantList &args)
38		: ProcessDataProvider(parent, args)
39		{
40		if (!QGuiApplication::instance()) {
41		return;
42		}
43		m_iconNameAttribute = new ProcessAttribute(QStringLiteral("windowIcon"), i18n("Window Icon"), this);
44		addProcessAttribute(m_iconNameAttribute);
45
46		m_titleAttribute = new ProcessAttribute(QStringLiteral("windowTitle"), i18n("Window Title"), this);
47		addProcessAttribute(m_titleAttribute);
48
49		m_appIdAttribute = new ProcessAttribute(QStringLiteral("appId"), i18n("Application ID"), this);
50		addProcessAttribute(m_appIdAttribute);
51
52		m_model = new TaskManager::TasksModel(this);
53		m_model->setGroupMode(TaskManager::TasksModel::GroupDisabled);
54
55		auto updateRows = [this](int first, int last) {
56		for (int i = first ; i <= last; i++) {
57		const QModelIndex index = m_model->index(i, 0, QModelIndex());
58		if (!index.data(TaskManager::AbstractTasksModel::IsWindow).toBool()) {
	broulikUnsubmitted Done `attachPidToTMIndex` already checks for `IsWindow` unless you want to save a pointless `AppPid` call broulik: `attachPidToTMIndex` already checks for `IsWindow` unless you want to save a pointless `AppPid`…
59		continue;
60		}
61		attachPidToTMIndex(index.data(TaskManager::AbstractTasksModel::AppPid).toLongLong(), index);
62		}
63		};
64
65		connect(m_model, &QAbstractItemModel::rowsInserted, this, [updateRows](const QModelIndex &parent, int first, int last) {
66		Q_UNUSED(parent)
67		updateRows(first, last);
68		});
69
70		connect(m_model, &QAbstractItemModel::modelReset, this, [this, updateRows]() {
71		if (m_model->rowCount() > 0) {
72		updateRows(0, m_model->rowCount());
	broulikUnsubmitted Done `rowCount() - 1` because you go `i <= last` broulik: `rowCount() - 1` because you go `i <= last`
73		}
74		});
75
76		connect(m_model, &QAbstractItemModel::dataChanged, this, [updateRows](const QModelIndex &topLeft, const QModelIndex &bottomRight, const QVector<int> &roles ) {
77		if (roles.contains(Qt::DisplayRole)) {
	broulikUnsubmitted Done Roles can potentially be empty indicating all roles are dirty? Also, what about `DecorationRole`, in case it's window pixmap. broulik: Roles can potentially be empty indicating all roles are dirty? Also, what about…
78		updateRows(topLeft.row(), bottomRight.row());
79		}
80		});
81
82		if (m_model->rowCount() > 0) {
83		updateRows(0, m_model->rowCount());
	broulikUnsubmitted Done `rowCount() - 1` broulik: `rowCount() - 1`
84		}
85		}
86
87		void TaskManagerIntegration::attachPidToTMIndex(long pid, const QModelIndex &index)
88		{
89		auto process = getProcess(pid);
90		if (!process) {
91		return;
92		}
93		if (!index.data(TaskManager::AbstractTasksModel::IsWindow).toBool()) {
94		return;
95		}
96
97		m_appIdAttribute->setData(process, index.data(TaskManager::AbstractTasksModel::AppId));
98		m_titleAttribute->setData(process, index.data(Qt::DisplayRole));
99		m_iconNameAttribute->setData(process, index.data(Qt::DecorationRole));
	broulikUnsubmitted Done This role is a `QIcon`, potentially created from the window pixmap in case window mapping failed. Or is that what the "tiny mods in ProcessModel" is about? broulik: This role is a `QIcon`, potentially created from the window pixmap in case window mapping…
	davidedmundsonAuthorUnsubmitted Done Yeah, and I need to map it to there decoration role on a different row. Kinda messy and against the spirit of plugins, but it still helps the code davidedmundson: Yeah, and I need to map it to there decoration role on a different row. Kinda messy and against…
100		}
101
102		K_PLUGIN_FACTORY_WITH_JSON(PluginFactory, "taskmanager.json", registerPlugin<TaskManagerIntegration>();)
103
104		#include "taskmanager.moc"