Differential D23287 Diff 64291 processcore/extended_process_list.cpp

Changeset View

Standalone View

processcore/extended_process_list.cpp

This file was added.

1		/*
2		Copyright (c) 2019 David Edmundson <davidedmundson@kde.org>
3
4		This library is free software; you can redistribute it and/or
5		modify it under the terms of the GNU Library General Public
6		License as published by the Free Software Foundation; either
7		version 2 of the License, or (at your option) any later version.
8
9		This library is distributed in the hope that it will be useful,
10		but WITHOUT ANY WARRANTY; without even the implied warranty of
11		MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
12		Library General Public License for more details.
13
14		You should have received a copy of the GNU Library General Public License
15		along with this library; see the file COPYING.LIB. If not, write to
16		the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
17		Boston, MA 02110-1301, USA.
18		*/
19		#include "extended_process_list.h"
20
21		#include <KPluginLoader>
22		#include <KPluginFactory>
23		#include <KPluginMetaData>
24
25		#include "process_data_provider.h"
26		#include "process_attribute.h"
27		#include "processcore_debug.h"
28
29		using namespace KSysGuard;
30
31		class ExtendedProcesses::Private
	zzagUnsubmitted Not Done Symbol of the PIMPL is leaked. Use Q_DECL_HIDDEN. zzag: Symbol of the PIMPL is leaked. Use Q_DECL_HIDDEN.
32		{
33		public:
34		Private(ExtendedProcesses *q);
35		void loadPlugins();
36
37		ExtendedProcesses *q;
38		QVector<ProcessDataProvider *> m_providers;
39		};
40
41		ExtendedProcesses::Private::Private(ExtendedProcesses *_q)
42		:q(_q)
43		{}
44
45		ExtendedProcesses::ExtendedProcesses(QObject *parent):
46		Processes(QString(), parent),
47		d(new Private(this))
48		{
49		d->loadPlugins();
50
51		connect(this, &KSysGuard::Processes::beginRemoveProcess, this, [this](KSysGuard::Process *process) {
52		const auto attrs = attributes();
53		for (auto a: attrs) {
54		a->clearData(process);
55		}
56		});
57
58		connect(this, &KSysGuard::Processes::updated, this, [this]() {
59		for (auto p: qAsConst(d->m_providers)) {
60		if (p->enabled()) {
61		p->update();
62		}
63		}
	broulikUnsubmitted Not Done Add `reserve` call broulik: Add `reserve` call
	davidedmundsonAuthorUnsubmitted Not Done I can't add a meaningful one. p->attributes() is itself another vector of size 0 to N. davidedmundson: I can't add a meaningful one. p->attributes() is itself another vector of size 0 to N.
64		});
65		}
66
67		ExtendedProcesses::~ExtendedProcesses()
68		{
69		}
70
71		QVector<ProcessAttribute *> ExtendedProcesses::attributes() const
72		{
73		QVector<ProcessAttribute *> rc;
74		for (auto p: qAsConst(d->m_providers)) {
75		rc << p->attributes();
76		}
77		return rc;
	broulikUnsubmitted Done Shouldn't this be a `continue`? broulik: Shouldn't this be a `continue`?
78		}
79
80		void ExtendedProcesses::Private::loadPlugins()
81		{
82		//instantiate all plugins
83		const QVector<KPluginMetaData> listMetaData = KPluginLoader::findPlugins(QStringLiteral("ksysguard/process"));
	ahiemstraUnsubmitted Done It would probably be nice to have some categorized logging here that reports the loaded plugins. It would make it easier to figure out if/when your plugin does not load. ahiemstra: It would probably be nice to have some categorized logging here that reports the loaded plugins.
84		for (const auto &pluginMetaData: listMetaData) {
85		qCDebug(LIBKSYSGUARD_PROCESSCORE) << "loading plugin" << pluginMetaData.name();
86		auto factory = qobject_cast<KPluginFactory*>(pluginMetaData.instantiate());
87		if (!factory) {
88		qCCritical(LIBKSYSGUARD_PROCESSCORE) << "failed to load plugin factory" << pluginMetaData.name();
89		continue;
90		}
91		ProcessDataProvider *provider = factory->create<ProcessDataProvider>(q);
92		if (!provider) {
93		qCCritical(LIBKSYSGUARD_PROCESSCORE) << "failed to instantiate ProcessDataProvider" << pluginMetaData.name();
94		continue;
95		}
96		m_providers << provider;
97		}
98		}
99
100