Changeset View
Changeset View
Standalone View
Standalone View
src/qml/HeaderBar.qml
Show First 20 Lines • Show All 317 Lines • ▼ Show 20 Line(s) | 207 | ColumnLayout { | |||
---|---|---|---|---|---|
318 | } | 318 | } | ||
319 | } | 319 | } | ||
320 | } | 320 | } | ||
321 | } | 321 | } | ||
322 | 322 | | |||
323 | LabelWithToolTip { | 323 | LabelWithToolTip { | ||
324 | id: remainingTracksLabel | 324 | id: remainingTracksLabel | ||
325 | 325 | | |||
326 | text: i18np("1 track remaining", "%1 tracks remaining", tracksCount) | 326 | text: tracksCount > 0 ? i18np("1 track remaining", "%1 tracks remaining", tracksCount) : i18n("No remaining tracks") | ||
mgallien: This will display "0 tracks remaining". That is not good.
Please put back the previous… | |||||
327 | 327 | | |||
328 | elide: Text.ElideRight | 328 | elide: Text.ElideRight | ||
329 | visible: tracksCount > 0 | 329 | visible: tracksCount >= 0 | ||
Not sure we really want this change but can you make it ">= 0" as this is easier to understand. mgallien: Not sure we really want this change but can you make it ">= 0" as this is easier to understand. | |||||
330 | // Hardcoded because the headerbar blur always makes a dark-ish | 330 | // Hardcoded because the headerbar blur always makes a dark-ish | ||
331 | // background, so we don't want to use a color scheme color that | 331 | // background, so we don't want to use a color scheme color that | ||
332 | // might also be dark | 332 | // might also be dark | ||
333 | color: "white" | 333 | color: "white" | ||
334 | 334 | | |||
335 | anchors.right: contentZone.right | 335 | anchors.right: contentZone.right | ||
336 | anchors.bottom: contentZone.bottom | 336 | anchors.bottom: contentZone.bottom | ||
337 | anchors.rightMargin: elisaTheme.layoutHorizontalMargin * 2 | 337 | anchors.rightMargin: elisaTheme.layoutHorizontalMargin * 2 | ||
▲ Show 20 Lines • Show All 86 Lines • Show Last 20 Lines |
This will display "0 tracks remaining". That is not good.
Please put back the previous behavior or fix the i18n call to have a correct way to say "no remaining tracks".