Changeset View
Standalone View
autotests/kxmlgui_unittest.cpp
| Show First 20 Lines • Show All 1080 Lines • ▼ Show 20 Line(s) | |||||
| 1081 | void KXmlGui_UnitTest::testSpecificApplicationLanguageQLocale() | 1081 | void KXmlGui_UnitTest::testSpecificApplicationLanguageQLocale() | ||
| 1082 | { | 1082 | { | ||
| 1083 | const QLocale originalSystemLocale = QLocale::system(); | 1083 | const QLocale originalSystemLocale = QLocale::system(); | ||
| 1084 | 1084 | | |||
| 1085 | KDEPrivate::setApplicationSpecificLanguage("ru_RU"); | 1085 | KDEPrivate::setApplicationSpecificLanguage("ru_RU"); | ||
| 1086 | KDEPrivate::initializeLanguages(); | 1086 | KDEPrivate::initializeLanguages(); | ||
| 1087 | 1087 | | |||
| 1088 | QCOMPARE(QLocale::system().language(), QLocale::Russian); | 1088 | QCOMPARE(QLocale::system().language(), QLocale::Russian); | ||
| 1089 | QCOMPARE(QLocale::system().monthName(1), QString::fromUtf8("января")); | ||||
asemke: does this test work? The name of the month is "январь" in russian, not "января". | |||||
aacidAuthorUnsubmitted Yes, it may surprise you, but i did actually run the tests before submitting this code change. aacid: Yes, it may surprise you, but i did actually run the tests before submitting this code change. | |||||
asemkeUnsubmitted The question was rethoric. I was rather surprised about the validnes of the check you did here. asemke: The question was rethoric. I was rather surprised about the validnes of the check you did here. | |||||
ltoscanoUnsubmitted ltoscano: Declensions: https://en.wiktionary.org/wiki/%D1%8F%D0%BD%D0%B2%D0%B0%D1%80%D1%8C#Declension | |||||
asemkeUnsubmitted there is no declension in Russian for the nominative case. The name of the month is январь and not января, but it is первого января (on January 1st) and not первого январь. https://doc.qt.io/qt-5/qlocale.html#monthName - QLocale must return the name of the month, meaning the nominative case and not one of its declensions. asemke: there is no declension in Russian for the nominative case. The name of the month is январь and… | |||||
yurchorUnsubmitted AFAIK this is broken on Qt level. Cf. calendar widget in KOrganizer (Ukrainian)  https://bugs.kde.org/show_bug.cgi?id=256952 There are new specifiers for the primary and alternative month names in glibc but Qt does not implement them (must be something like "LLLL YYYY" instead of "MMMM YYYY" in formatting). Rafal Luzynski (the author of the glibc patch) in a private message (2018-01-25) promised me to send the patch for Qt but this has not happened yet. yurchor: AFAIK this is broken on Qt level. Cf. calendar widget in KOrganizer (Ukrainian)
{F7273188}… | |||||
asemkeUnsubmitted This is maybe not Qt but the locale defintion files which are probably distro specific. I just checked on SLES and on openSuse. for ukrainian: LC_TIME=uk_UA.UTF-8 locale mon січень;лютий;березень;квітень;травень;червень;липень;серпень;вересень;жовтень;листопад;грудень for russian: LC_TIME=ru_RU.UTF-8 locale mon Январь;Февраль;Март;Апрель;Май;Июнь;Июль;Август;Сентябрь;Октябрь;Ноябрь;Декабрь This is, except of capital letters for ru_RU, correct. On Mac I get however січня;лютого;березня;квітня;травня;червня;липня;серпня;вересня;жовтня;листопада;грудня and января;февраля;марта;апреля;мая;июня;июля;августа;сентября;октября;ноября;декабря which is possessive case and is wrong if you reffer to the name of the month itself. @aacid on your distribution you'll most probably get the same output as on my Mac. Under the assumption that Qt evaluates the locale definition files, your test will probably fail on other distributions which do this correctly. asemke: This is maybe not Qt but the locale defintion files which are probably distro specific. I just… | |||||
asemkeUnsubmitted @aacid the discussion about declensions in slawic languages is not relevant to your patch I'd say. Maybe it's better to use in the test a language like German or any other languages where we don't have this additional complication. asemke: @aacid the discussion about declensions in slawic languages is not relevant to your patch I'd… | |||||
| 1089 | 1090 | | |||
| 1090 | KDEPrivate::setApplicationSpecificLanguage("wa"); | 1091 | KDEPrivate::setApplicationSpecificLanguage("wa"); | ||
| 1091 | KDEPrivate::initializeLanguages(); | 1092 | KDEPrivate::initializeLanguages(); | ||
| 1092 | 1093 | | |||
| 1093 | QCOMPARE(QLocale::system().language(), QLocale::Walloon); | 1094 | QCOMPARE(QLocale::system().language(), QLocale::Walloon); | ||
| 1094 | 1095 | | |||
| 1095 | KDEPrivate::setApplicationSpecificLanguage(QByteArray()); | 1096 | KDEPrivate::setApplicationSpecificLanguage(QByteArray()); | ||
| 1096 | KDEPrivate::initializeLanguages(); | 1097 | KDEPrivate::initializeLanguages(); | ||
| Show All 14 Lines | |||||
does this test work? The name of the month is "январь" in russian, not "января".