Changeset View
Changeset View
Standalone View
Standalone View
src/dolphinmainwindow.cpp
| Show First 20 Lines • Show All 745 Lines • ▼ Show 20 Line(s) | 742 | foreach (QObject* child, children()) { | |||
|---|---|---|---|---|---|
| 746 | } | 746 | } | ||
| 747 | } | 747 | } | ||
| 748 | 748 | | |||
| 749 | GeneralSettings::setLockPanels(newLockState); | 749 | GeneralSettings::setLockPanels(newLockState); | ||
| 750 | } | 750 | } | ||
| 751 | 751 | | |||
| 752 | void DolphinMainWindow::slotTerminalPanelVisibilityChanged() | 752 | void DolphinMainWindow::slotTerminalPanelVisibilityChanged() | ||
| 753 | { | 753 | { | ||
| 754 | if (m_terminalPanel->isHiddenInVisibleWindow()) { | 754 | if (m_terminalPanel->isHiddenInVisibleWindow() && m_activeViewContainer) { | ||
elvisangelaccio: This looks like an unrelated change, if it's not can you explain why we need it? | |||||
m_activeViewContainer is NULL when Dolphin starts and without this change app crashes. AndreyYashkin: //m_activeViewContainer// is //NULL// when Dolphin starts and without this change app crashes. | |||||
You're right, it was a problem also before and it was working just by luck... elvisangelaccio: You're right, it was a problem also before and it was working just by luck... | |||||
| 755 | m_activeViewContainer->view()->setFocus(); | 755 | m_activeViewContainer->view()->setFocus(); | ||
| 756 | } | 756 | } | ||
| 757 | } | 757 | } | ||
| 758 | 758 | | |||
| 759 | void DolphinMainWindow::goBack() | 759 | void DolphinMainWindow::goBack() | ||
| 760 | { | 760 | { | ||
| 761 | KUrlNavigator* urlNavigator = m_activeViewContainer->urlNavigator(); | 761 | KUrlNavigator* urlNavigator = m_activeViewContainer->urlNavigator(); | ||
| 762 | urlNavigator->goBack(); | 762 | urlNavigator->goBack(); | ||
| ▲ Show 20 Lines • Show All 1336 Lines • Show Last 20 Lines | |||||
This looks like an unrelated change, if it's not can you explain why we need it?