Differential D23075 Diff 63508 src/dolphinmainwindow.cpp

Changeset View

Standalone View

View Options

src/dolphinmainwindow.cpp

Context not available.
1727 1727​
1728 m_controlButton = new QToolButton(this); 1728​ m_controlButton = new QToolButton(this);
1729 m_controlButton->setIcon(QIcon::fromTheme(QStringLiteral("application-menu"))); 1729​ m_controlButton->setIcon(QIcon::fromTheme(QStringLiteral("application-menu")));
1730 m_controlButton->setText(i18nc("@action", "Control")); 1730​ m_controlButton->setToolTip(i18nc("@action", "Show menu"));
ngrahamUnsubmitted
Done

Tooltips are written as commands or sentences. Maybe change this to something like "Show menu"

ngraham: Tooltips are written as commands or sentences. Maybe change this to something like "Show menu"
simonkrAuthorUnsubmitted
Done

Done! :)

simonkr: Done! :)
1731 m_controlButton->setAttribute(Qt::WidgetAttribute::WA_CustomWhatsThis); 1731​ m_controlButton->setAttribute(Qt::WidgetAttribute::WA_CustomWhatsThis);
1732 m_controlButton->setPopupMode(QToolButton::InstantPopup); 1732​ m_controlButton->setPopupMode(QToolButton::InstantPopup);
1733 m_controlButton->setToolButtonStyle(toolBar()->toolButtonStyle()); ​
1734 1733​
1735 QMenu* controlMenu = new QMenu(m_controlButton); 1734​ QMenu* controlMenu = new QMenu(m_controlButton);
1736 connect(controlMenu, &QMenu::aboutToShow, this, &DolphinMainWindow::updateControlMenu); 1735​ connect(controlMenu, &QMenu::aboutToShow, this, &DolphinMainWindow::updateControlMenu);
Context not available.
1741 toolBar()->addWidget(m_controlButton); 1740​ toolBar()->addWidget(m_controlButton);
1742 connect(toolBar(), &KToolBar::iconSizeChanged, 1741​ connect(toolBar(), &KToolBar::iconSizeChanged,
1743 m_controlButton, &QToolButton::setIconSize); 1742​ m_controlButton, &QToolButton::setIconSize);
1744 connect(toolBar(), &KToolBar::toolButtonStyleChanged, ​
1745 m_controlButton, &QToolButton::setToolButtonStyle); ​
1746 1743​
1747 // The added widgets are owned by the toolbar and may get deleted when e.g. the toolbar 1744​ // The added widgets are owned by the toolbar and may get deleted when e.g. the toolbar
1748 // gets edited. In this case we must add them again. The adding is done asynchronously by 1745​ // gets edited. In this case we must add them again. The adding is done asynchronously by
Context not available.