Differential D22468 Diff 63234 kcm/package/contents/ui/Panel.qml

Changeset View

Standalone View

View Options

kcm/package/contents/ui/Panel.qml

  • This file was added.
1​/********************************************************************
2​Copyright © 2019 Roman Gilg <subdiff@gmail.com>
3​
4​This program is free software; you can redistribute it and/or modify
5​it under the terms of the GNU General Public License as published by
6​the Free Software Foundation; either version 2 of the License, or
7​(at your option) any later version.
8​
9​This program is distributed in the hope that it will be useful,
10​but WITHOUT ANY WARRANTY; without even the implied warranty of
11​MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12​GNU General Public License for more details.
13​
14​You should have received a copy of the GNU General Public License
15​along with this program. If not, see <http://www.gnu.org/licenses/>.
16​*********************************************************************/
17​import QtQuick 2.9
18​import QtQuick.Layouts 1.1
19​import QtQuick.Controls 2.3 as Controls
20​import org.kde.plasma.extras 2.0 as PlasmaExtras
21​import org.kde.kirigami 2.4 as Kirigami
22​import org.kde.private.kcm.kscreen 1.0 as KScreen
23​
24​ColumnLayout {
25​ Kirigami.FormLayout {
26​ twinFormLayouts: globalSettingsLayout
27​ Item {
28​ Kirigami.FormData.isSection: true
29​ Kirigami.FormData.label: i18n("Output settings")
30​
31​ Rectangle {
32​ anchors.fill: parent
33​ opacity: 0.5
34​ }
35​ }
broulikUnsubmitted
Done

Have you tried twinFormLayouts?

broulik: Have you tried `twinFormLayouts`?
romanggAuthorUnsubmitted
Not Done

Nice!

romangg: Nice!
36​ }
37​
38​ Controls.SwipeView {
39​ id: panelView
40​ currentIndex: root.selectedOutput
41​
42​ onCurrentIndexChanged: root.selectedOutput =
43​ Qt.binding(function() { return currentIndex; });
44​
45​ Layout.fillWidth: true
46​
47​ Repeater {
48​ model: kcm.outputModel
49​ OutputPanel {}
50​ }
51​ }
52​
53​ Controls.PageIndicator {
54​ id: indicator
55​
56​ Layout.alignment: Qt.AlignHCenter
57​ opacity: count > 1 ? 1 : 0
58​
59​ count: panelView.count
60​ currentIndex: panelView.currentIndex
61​ interactive: true
62​ onCurrentIndexChanged: root.selectedOutput = currentIndex
63​ }
64​
65​ Kirigami.FormLayout {
66​ id: globalSettingsLayout
67​ Layout.fillWidth: true
68​ Layout.topMargin: 20
69​ Kirigami.Separator {
70​ Layout.fillWidth: true
71​ Kirigami.FormData.isSection: true
72​ }
73​ Item {
74​ Layout.fillWidth: true
75​ Kirigami.FormData.isSection: true
76​ Kirigami.FormData.label: i18n("Arrangement settings")
77​ }
78​
79​ ColumnLayout {
80​ Layout.fillWidth: true
81​ Kirigami.FormData.label: i18n("Global scale:")
82​
83​ visible: !kcm.perOutputScaling
84​
85​ Controls.Slider {
86​ id: globalScaleSlider
87​
88​ Layout.fillWidth: true
89​ from: 1
broulikUnsubmitted
Done

Why is "Scale" under arrangement?

broulik: Why is "Scale" under arrangement?
romanggAuthorUnsubmitted
Done

It's the global scale on X11 affecting every output in the arrangement and not only a single one. On X11 there are no scale values per output. Note to self: Change this label to "Global scale".

romangg: It's the global scale on X11 affecting every output in the arrangement and not only a single…
90​ to: 3
91​ stepSize: 0.1
92​ live: true
93​ value: kcm.globalScale
94​ onMoved: kcm.globalScale = value
95​ }
96​ Controls.Label {
97​ Layout.alignment: Qt.AlignHCenter
98​ text: globalScaleSlider.value.toLocaleString(Qt.locale(), "f", 1)
99​ }
broulikUnsubmitted
Not Done

Can we make it not show all the tick marks but only the integer ones like in the current scale UI?

broulik: Can we make it not show all the tick marks but only the integer ones like in the current scale…
romanggAuthorUnsubmitted
Not Done

Not with the default Slider style. Maybe needs a custom slider style or something?

romangg: Not with the default Slider style. Maybe needs a custom slider style or something?
100​ }
101​
102​ Controls.ButtonGroup {
broulikUnsubmitted
Done

Use onMoved which blabla, see onClicked and onActivated

broulik: Use `onMoved` which blabla, see `onClicked` and `onActivated`
103​ buttons: retentionSelector.children
104​ }
105​
106​ ColumnLayout {
broulikUnsubmitted
Done

You can pretty-format the number like this:

globalScaleSlider.value.toLocaleString(Qt.locale(), "f", 1)

(If that doesn't work wrap it in Number(...).toLocaleString(...))

broulik: You can pretty-format the number like this: ``` globalScaleSlider.value.toLocaleString(Qt.
107​ id: retentionSelector
108​
109​ Kirigami.FormData.label: i18n("Save values of an output:")
110​ Kirigami.FormData.buddyFor: globalRetentionRadio
111​ spacing: Kirigami.Units.smallSpacing
112​
113​ Controls.RadioButton {
114​ id: globalRetentionRadio
115​ text: i18n("For this and other combination of outputs")
116​ checked: !individualRetentionRadio.checked
117​ onClicked: kcm.outputRetention = KScreen.Control.Global
118​ }
119​
120​ Controls.RadioButton {
121​ id: individualRetentionRadio
122​ text: i18n("For this specific setup independently of others")
123​ checked: kcm.outputRetention === KScreen.Control.Individual
broulikUnsubmitted
Done

onClicked
I also think the operator priorities are a bit mixed up here

broulik: `onClicked` I also think the operator priorities are a bit mixed up here
124​ onClicked: kcm.outputRetention = KScreen.Control.Individual
125​ }
126​ }
127​ }
128​}