Differential D15693 Diff 62779 krusader/GUI/krhistorycombobox.h

Changeset View

Standalone View

View Options

krusader/GUI/krhistorycombobox.h

  • This file was added.
PropertyOld ValueNew Value
File Modenull100755
1​/*****************************************************************************
2​ * Copyright (C) 2018-2019 Shie Erlich <krusader@users.sourceforge.net> *
nmelUnsubmitted
Not Done

We don't include Shie & Rafi in new files since they haven't contributed to this code. We just use more generic Krusader Krew (see compat.h for example).

nmel: We don't include Shie & Rafi in new files since they haven't contributed to this code. We just…
asensiAuthorUnsubmitted
Not Done

In the past I added some files (I remember krarcbasemanager.h and krdebuglogger.h), and assigned its copyright to Shie and Rafi. I feel uncomfortable writing only "Krusader Krew" as the copyright owner, would that allow future Krusader Krews to fork Krusader files with a proprietary license and more :-?. Including Shie and Rafi as copyright owners makes future scenarios safer as future Krusader Krews would need Shie and Rafi to perform some critical legal actions.

Even though I appreciate a lot our Krusader Krew, I also have to face that we not a company, nor an registered nonprofit organization, etc. :-( so I wouldn't perform some particular legal actions (perhaps some of them are not valid, or are unnecessary risky) in the name of our nowadays beloved Krusader Krew.

asensi: In the past I added some files (I remember krarcbasemanager.h and krdebuglogger.h), and…
nmelUnsubmitted
Not Done

I'm not a lawyer, but I see many orgs use names in copyright lines which are not companies or non-profits. For example, Gentoo build configs are authored as (# Copyright 1999-2019 Gentoo Authors) and Gentoo Authors is not an org.

In the same time, it doesn't hurt, so I have no issue here. I'm not sure if Shie and Rafi have any issue for having their names signed under the code they didn't write, but so far they haven't expressed any objections. ;)

nmel: I'm not a lawyer, but I see many orgs use names in copyright lines which are not companies or…
asensiAuthorUnsubmitted
Not Done

I'm not a lawyer :-), and in a similar vein to previous comments, I have to trust more in Shie and Rafi than in future Krusader Krews because I still don't know about them :-(

asensi: I'm not a lawyer :-), and in a similar vein to previous comments, I have to trust more in Shie…
3​ * Copyright (C) 2018-2019 Rafi Yanai <krusader@users.sourceforge.net> *
4​ * Copyright (C) 2018-2019 Krusader Krew [https://krusader.org] *
5​ * *
6​ * This file is part of Krusader [https://krusader.org]. *
7​ * *
8​ * Krusader is free software: you can redistribute it and/or modify *
9​ * it under the terms of the GNU General Public License as published by *
10​ * the Free Software Foundation, either version 2 of the License, or *
11​ * (at your option) any later version. *
12​ * *
13​ * Krusader is distributed in the hope that it will be useful, *
14​ * but WITHOUT ANY WARRANTY; without even the implied warranty of *
15​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
16​ * GNU General Public License for more details. *
17​ * *
18​ * You should have received a copy of the GNU General Public License *
19​ * along with Krusader. If not, see [http://www.gnu.org/licenses/]. *
20​ *****************************************************************************/
21​
22​#ifndef KRHISTORYCOMBOBOX_H
23​#define KRHISTORYCOMBOBOX_H
24​
25​#include <KCompletion/KHistoryComboBox>
26​
27​/**
28​ * A KrHistoryComboBox event filter that e.g. deletes the current item when Shift+Del is pressed
29​ * There was more information in https://doc.qt.io/qt-5/qobject.html#installEventFilter,
30​ * https://forum.qt.io/post/160618 and
31​ * https://stackoverflow.com/questions/17820947/remove-items-from-qcombobox-from-ui/52459337#52459337
32​ */
33​class KHBoxEventFilter : public QObject
nmelUnsubmitted
Not Done

I agree with Alex, these classes are auxiliary and should be fully moved to cpp. You don't plan to use them in other files, do you?

nmel: I agree with Alex, these classes are auxiliary and should be fully moved to cpp. You don't plan…
asensiAuthorUnsubmitted
Not Done

I suppose you are talking about two class declarations, I moved them to the cpp file, there were no longer any "does not name a type" error messages, thought a "[krusader/GUI/CMakeFiles/GUI_autogen] Error 1" one appeared. In order to solve it I added a

#include "krhistorycombobox.moc" // required for class definitions with Q_OBJECT macro in implementation files

line, in a similar way to the

#include "jobman.moc" // required for class definitions with Q_OBJECT macro in implementation files

line that already existed in the Krusader source code. I wonder if do you have any alternative :-?

asensi: I suppose you are talking about two class declarations, I moved them to the cpp file, there…
34​{
35​ Q_OBJECT
36​
37​public:
38​ explicit KHBoxEventFilter(QObject *parent = nullptr) : QObject(parent) {}
39​
40​protected:
41​ bool eventFilter(QObject *obj, QEvent *event) override;
42​};
43​
44​/**
45​ * An event filter for the popup list of a KrHistoryComboBox, e.g. it deletes the current
46​ * item when the user presses Shift+Del
47​ */
48​class KHBoxListEventFilter : public QObject
49​{
50​ Q_OBJECT
51​
52​public:
53​ explicit KHBoxListEventFilter(QObject *parent = nullptr) : QObject(parent) {}
54​
55​protected:
56​ bool eventFilter(QObject *obj, QEvent *event) override;
57​};
58​
59​
60​/**
61​ * A specialized version of a KHistoryComboBox, e.g. it deletes the current
62​ * item when the user presses Shift+Del
63​ */
64​class KrHistoryComboBox : public KHistoryComboBox
65​{
66​ Q_OBJECT
67​
68​public:
69​ explicit KrHistoryComboBox(bool useCompletion, QWidget *parent = nullptr);
70​};
71​
72​#endif // KRHISTORYCOMBOBOX_H