Differential D15693 Diff 62779 krusader/GUI/krhistorycombobox.cpp

Changeset View

Standalone View

View Options

krusader/GUI/krhistorycombobox.cpp

  • This file was added.
PropertyOld ValueNew Value
File Modenull100755
1​/*****************************************************************************
2​ * Copyright (C) 2018-2019 Shie Erlich <krusader@users.sourceforge.net> *
3​ * Copyright (C) 2018-2019 Rafi Yanai <krusader@users.sourceforge.net> *
4​ * Copyright (C) 2018-2019 Krusader Krew [https://krusader.org] *
5​ * *
6​ * This file is part of Krusader [https://krusader.org]. *
7​ * *
8​ * Krusader is free software: you can redistribute it and/or modify *
9​ * it under the terms of the GNU General Public License as published by *
10​ * the Free Software Foundation, either version 2 of the License, or *
11​ * (at your option) any later version. *
12​ * *
13​ * Krusader is distributed in the hope that it will be useful, *
14​ * but WITHOUT ANY WARRANTY; without even the implied warranty of *
15​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
16​ * GNU General Public License for more details. *
17​ * *
18​ * You should have received a copy of the GNU General Public License *
19​ * along with Krusader. If not, see [http://www.gnu.org/licenses/]. *
20​ *****************************************************************************/
21​
22​#include "krhistorycombobox.h"
23​
24​// QtCore
25​#include <QEvent>
26​// QtGui
27​#include <QKeyEvent>
28​// QtWidgets
29​#include <QAbstractItemView>
30​
31​bool KHBoxEventFilter::eventFilter(QObject *obj, QEvent *event)
32​{
33​ if (event->type() == QEvent::KeyPress) {
34​ auto keyEvent = static_cast<QKeyEvent *>(event);
35​ if (keyEvent->modifiers() == Qt::ShiftModifier && keyEvent->key() == Qt::Key::Key_Delete) {
36​ auto box = dynamic_cast<KHistoryComboBox *>(obj);
37​ if (box != nullptr) {
38​ QString entryToDelete = box->currentText();
39​ // Delete the current item
40​ box->removeItem(box->currentIndex());
41​ // The item has to be deleted also from the completion list
42​ box->completionObject()->removeItem(entryToDelete);
43​ return true;
44​ }
45​ }
46​ }
47​ // Perform the usual event processing
48​ return QObject::eventFilter(obj, event);
49​}
50​
51​bool KHBoxListEventFilter::eventFilter(QObject *obj, QEvent *event)
52​{
53​ if (event->type() == QEvent::KeyPress) {
54​ auto keyEvent = static_cast<QKeyEvent *>(event);
55​ if (keyEvent->modifiers() == Qt::ShiftModifier && keyEvent->key() == Qt::Key::Key_Delete) {
56​ auto iv = dynamic_cast<QAbstractItemView *>(obj);
57​ if (iv->model() != nullptr) {
58​ QString entryToDelete = iv->currentIndex().data().toString();
59​ // Delete the current item from the popup list
60​ iv->model()->removeRow(iv->currentIndex().row());
61​ // The item has to be deleted also from the completion list of the KHistoryComboBox
62​ if (obj->parent() != nullptr) {
nmelUnsubmitted
Done

Since obj == iv, you can use iv here and below for clarity.

nmel: Since obj == iv, you can use iv here and below for clarity.
63​ auto box = static_cast<KHistoryComboBox *>(obj->parent()->parent());
nmelUnsubmitted
Done

dynamic_cast

nmel: dynamic_cast
64​ if (box != nullptr) {
65​ box->completionObject()->removeItem(entryToDelete);
66​ return true;
67​ }
68​ }
69​ }
70​ }
71​ }
72​ // Perform the usual event processing
73​ return QObject::eventFilter(obj, event);
74​}
75​
76​KrHistoryComboBox::KrHistoryComboBox(bool useCompletion, QWidget *parent)
77​ : KHistoryComboBox(useCompletion, parent)
78​{
79​ installEventFilter(new KHBoxEventFilter(this));
80​
81​ QAbstractItemView* iv = view();
nmelUnsubmitted
Done

QAbstractItemView *iv (pointer style)

nmel: QAbstractItemView *iv (pointer style)
82​ if (iv != nullptr)
83​ iv->installEventFilter(new KHBoxListEventFilter(this));
84​}
abikaUnsubmitted
Done

i would recommend to not use pure abbreviations like iv but longer variable names like itemView. This is much more readable.
Same for box vs. comboBox. A bit longer is better in most cases.

abika: i would recommend to not use pure abbreviations like `iv` but longer variable names like…