Differential D22494 Diff 62657 dataengines/potd/potdprovider.cpp

Changeset View

Standalone View

dataengines/potd/potdprovider.cpp

Show All 16 Lines
17	* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.	17		* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
18	*/	18		*/
19		19
20	#include "potdprovider.h"	20		#include "potdprovider.h"
21		21
22	// Qt	22		// Qt
23	#include <QDate>	23		#include <QDate>
24		24
25
26	class PotdProviderPrivate	25		class PotdProviderPrivate
27	{	26		{
28	public:	27		public:
29	QString name;	28		QString name;
30	QDate date;	29		QDate date;
		30		QString identifier;
31	};	31		};
32		32
33	PotdProvider::PotdProvider( QObject *parent, const QVariantList &args )	33		PotdProvider::PotdProvider( QObject *parent, const QVariantList &args )
34	: QObject( parent ),	34		: QObject( parent ),
35	d(new PotdProviderPrivate)	35		d(new PotdProviderPrivate)
36	{	36		{
37	if ( args.count() > 0 ) {	37		if ( args.count() > 0 ) {
38	d->name = args[ 0 ].toString();	38		d->name = args[ 0 ].toString();
39		39
40	if ( args.count() > 1 && args[ 1 ].canConvert( QVariant::Date ) ) {	40		d->identifier = d->name;
41	d->date = args[ 1 ].toDate();	41
		42		if ( args.count() > 1 ) {
		43		for (int i = 1; i < args.count(); i++) {
		44		d->identifier += QStringLiteral(":") + args[i].toString();
		45		QDate date = QDate::fromString(args[ i ].toString(), Qt::ISODate);
		46		if (date.isValid()) {
		47		d->date = date;
		48		}
		49		}
42	}	50		}
43	} else {	51		} else {
44	d->name = QStringLiteral("Unknown");	52		d->name = QStringLiteral("Unknown");
			ngrahamUnsubmitted Not Done The lack of error handling and else blocks for all the ifs in this new code makes me feel a bit nervous. ngraham: The lack of error handling and else blocks for all the ifs in this new code makes me feel a bit…
			guoyunheAuthorUnsubmitted Not Done `date` is optional, so if it not found, just leave it as undefined. I can add some detection to `toString()` function, in case they passed some non-string args. `mach()` should be safe. guoyunhe: `date` is optional, so if it not found, just leave it as undefined. I can add some detection to…
			guoyunheAuthorUnsubmitted Not Done Read Qt documentation that `QVariant::toString()` will always return a string even if the type is not supported (empty string). So this code won't produce any error/exception. guoyunhe: Read Qt documentation that `QVariant::toString()` will always return a string even if the type…
		53		d->identifier = d->name;
45	}	54		}
46	}	55		}
47		56
48	PotdProvider::~PotdProvider()	57		PotdProvider::~PotdProvider()
49	{	58		{
50	}	59		}
51		60
52	QString PotdProvider::name() const	61		QString PotdProvider::name() const
53	{	62		{
54	return d->name;	63		return d->name;
55	}	64		}
56		65
57	QDate PotdProvider::date() const	66		QDate PotdProvider::date() const
58	{	67		{
59	return d->date.isNull() ? QDate::currentDate() : d->date;	68		return d->date.isNull() ? QDate::currentDate() : d->date;
60	}	69		}
61		70
62	bool PotdProvider::isFixedDate() const	71		bool PotdProvider::isFixedDate() const
63	{	72		{
64	return !d->date.isNull();	73		return !d->date.isNull();
65	}	74		}
66		75
67	QString PotdProvider::identifier() const	76		QString PotdProvider::identifier() const
68	{	77		{
69	if (isFixedDate()) {	78		return d->identifier;
70	return d->name + QLatin1Char(':') + d->date.toString(Qt::ISODate);
71	}
72
73	return d->name;
74	}	79		}
75		80
76		81