Differential D22494 Diff 62546 wallpapers/potd/contents/ui/config.qml

Changeset View

Standalone View

View Options

wallpapers/potd/contents/ui/config.qml

Show All 24 Lines
25 25​
26Kirigami.FormLayout { 26​Kirigami.FormLayout {
27 id: root 27​ id: root
28 twinFormLayouts: parentLayout 28​ twinFormLayouts: parentLayout
29 anchors.left: parent.left 29​ anchors.left: parent.left
30 anchors.right: parent.right 30​ anchors.right: parent.right
31 31​
32 property string cfg_Provider 32​ property string cfg_Provider
33​ property string cfg_Category
33 property int cfg_FillMode 34​ property int cfg_FillMode
34 property alias cfg_Color: colorButton.color 35​ property alias cfg_Color: colorButton.color
35 property alias formLayout: root 36​ property alias formLayout: root
36 37​
37 ListModel { 38​ ListModel {
38 id: providerModel 39​ id: providerModel
39 } 40​ }
40 41​
Show All 37 Lines70 QQC1.ComboBox {
78 textRole: "name" 79​ textRole: "name"
79 onCurrentIndexChanged: { 80​ onCurrentIndexChanged: {
80 cfg_Provider = providerModel.get(currentIndex)["id"] 81​ cfg_Provider = providerModel.get(currentIndex)["id"]
81 } 82​ }
82 } 83​ }
83 84​
84 // TODO: port to QQC2 version once we've fixed https://bugs.kde.org/show_bug.cgi?id=403153 85​ // TODO: port to QQC2 version once we've fixed https://bugs.kde.org/show_bug.cgi?id=403153
85 QQC1.ComboBox { 86​ QQC1.ComboBox {
87​ id: categoryComboBox
88​ visible: cfg_Provider === 'unsplash'
89​ TextMetrics {
90​ id: categoryTextMetrics
91​ text: categoryComboBox.currentText
92​ }
93​ implicitWidth: Math.max(providerTextMetrics.width + Kirigami.Units.gridUnit * 2 + Kirigami.Units.smallSpacing * 2, pluginComboBox.width) //QQC1 Combobox default sizing is broken
94​ Kirigami.FormData.label: i18ndc("plasma_wallpaper_org.kde.potd", "@label:listbox", "Category:")
95​ model: [
96​ {
97​ 'label': i18ndc("plasma_wallpaper_org.kde.potd", "@item:inlistbox", "All"),
98​ 'value': '1065976'
99​ },
100​ {
101​ 'label': i18ndc("plasma_wallpaper_org.kde.potd", "@item:inlistbox", "1080p"),
102​ 'value': '1339107'
103​ },
104​ {
105​ 'label': i18ndc("plasma_wallpaper_org.kde.potd", "@item:inlistbox", "4K"),
106​ 'value': '1339090'
107​ },
108​ {
109​ 'label': i18ndc("plasma_wallpaper_org.kde.potd", "@item:inlistbox", "Ultra Wide"),
110​ 'value': '1339089'
111​ },
112​ {
113​ 'label': i18ndc("plasma_wallpaper_org.kde.potd", "@item:inlistbox", "Background"),
114​ 'value': '1339276'
115​ },
116​ {
117​ 'label': i18ndc("plasma_wallpaper_org.kde.potd", "@item:inlistbox", "Lock Screen"),
118​ 'value': '1339070'
119​ },
120​ {
121​ 'label': i18ndc("plasma_wallpaper_org.kde.potd", "@item:inlistbox", "Nature"),
122​ 'value': '1065376'
123​ },
124​ {
125​ 'label': i18ndc("plasma_wallpaper_org.kde.potd", "@item:inlistbox", "Tumblr"),
126​ 'value': '1111644'
127​ },
128​ {
129​ 'label': i18ndc("plasma_wallpaper_org.kde.potd", "@item:inlistbox", "Black"),
130​ 'value': '1101680'
131​ },
132​ {
133​ 'label': i18ndc("plasma_wallpaper_org.kde.potd", "@item:inlistbox", "Flower"),
134​ 'value': '1100232'
135​ },
136​ {
137​ 'label': i18ndc("plasma_wallpaper_org.kde.potd", "@item:inlistbox", "Funny"),
138​ 'value': '1111682'
139​ },
140​ {
141​ 'label': i18ndc("plasma_wallpaper_org.kde.potd", "@item:inlistbox", "Cute"),
142​ 'value': '1111680'
143​ },
144​ {
145​ 'label': i18ndc("plasma_wallpaper_org.kde.potd", "@item:inlistbox", "Cool"),
146​ 'value': '1111678'
147​ },
148​ {
149​ 'label': i18ndc("plasma_wallpaper_org.kde.potd", "@item:inlistbox", "Fall"),
150​ 'value': '1100229'
151​ },
152​ {
153​ 'label': i18ndc("plasma_wallpaper_org.kde.potd", "@item:inlistbox", "Love"),
154​ 'value': '1066280'
155​ },
156​ {
157​ 'label': i18ndc("plasma_wallpaper_org.kde.potd", "@item:inlistbox", "Design"),
158​ 'value': '1066276'
159​ },
160​ {
161​ 'label': i18ndc("plasma_wallpaper_org.kde.potd", "@item:inlistbox", "Christmas"),
162​ 'value': '1066273'
163​ },
164​ {
165​ 'label': i18ndc("plasma_wallpaper_org.kde.potd", "@item:inlistbox", "Travel"),
166​ 'value': '1065428'
167​ },
168​ {
169​ 'label': i18ndc("plasma_wallpaper_org.kde.potd", "@item:inlistbox", "Beach"),
170​ 'value': '1065423'
171​ },
172​ {
173​ 'label': i18ndc("plasma_wallpaper_org.kde.potd", "@item:inlistbox", "Car"),
174​ 'value': '1065408'
175​ },
176​ {
177​ 'label': i18ndc("plasma_wallpaper_org.kde.potd", "@item:inlistbox", "Sports"),
178​ 'value': '1065402'
179​ },
180​ {
181​ 'label': i18ndc("plasma_wallpaper_org.kde.potd", "@item:inlistbox", "Animal"),
182​ 'value': '1065390'
183​ },
184​ {
185​ 'label': i18ndc("plasma_wallpaper_org.kde.potd", "@item:inlistbox", "People"),
186​ 'value': '1065386'
187​ },
188​ {
189​ 'label': i18ndc("plasma_wallpaper_org.kde.potd", "@item:inlistbox", "Music"),
190​ 'value': '1065384'
191​ },
192​ {
193​ 'label': i18ndc("plasma_wallpaper_org.kde.potd", "@item:inlistbox", "Summer"),
194​ 'value': '1065380'
195​ },
196​ {
197​ 'label': i18ndc("plasma_wallpaper_org.kde.potd", "@item:inlistbox", "Galaxy"),
198​ 'value': '1065374'
199​ },
200​ ]
201​
202​ textRole: "label"
203​ onCurrentIndexChanged: {
204​ cfg_Category = model[currentIndex]["value"]
205​ }
206​ Component.onCompleted: setCategory();
207​
208​ function setCategory() {
ngrahamUnsubmitted
Done

Since this is only used once, you don't need to make it a function; just put all of this stuff in the Component.onCompleted: directly

ngraham: Since this is only used once, you don't need to make it a function; just put all of this stuff…
guoyunheAuthorUnsubmitted
Not Done

Fixed.

guoyunhe: Fixed.
209​ for (var i = 0; i < model.length; i++) {
210​ if (model[i]["value"] == wallpaper.configuration.Category) {
211​ categoryComboBox.currentIndex = i;
212​ }
213​ }
214​ }
215​ }
216​
217​ // TODO: port to QQC2 version once we've fixed https://bugs.kde.org/show_bug.cgi?id=403153
218​ QQC1.ComboBox {
86 id: resizeComboBox 219​ id: resizeComboBox
87 TextMetrics { 220​ TextMetrics {
88 id: resizeTextMetrics 221​ id: resizeTextMetrics
89 text: resizeComboBox.currentText 222​ text: resizeComboBox.currentText
90 } 223​ }
91 implicitWidth: Math.max(resizeTextMetrics.width + Kirigami.Units.gridUnit * 2 + Kirigami.Units.smallSpacing * 2, pluginComboBox.width) //QQC1 Combobox default sizing is broken 224​ implicitWidth: Math.max(resizeTextMetrics.width + Kirigami.Units.gridUnit * 2 + Kirigami.Units.smallSpacing * 2, pluginComboBox.width) //QQC1 Combobox default sizing is broken
92 Kirigami.FormData.label: i18ndc("plasma_wallpaper_org.kde.potd", "@label:listbox", "Positioning:") 225​ Kirigami.FormData.label: i18ndc("plasma_wallpaper_org.kde.potd", "@label:listbox", "Positioning:")
93 model: [ 226​ model: [
▲ Show 20 Lines • Show All 42 Lines • Show Last 20 Lines