Differential D2079 Diff 4926 plugins/platforms/x11/standalone/glxbackend.cpp

Changeset View

Standalone View

View Options

plugins/platforms/x11/standalone/glxbackend.cpp

Context not available.
45 45​
46#ifndef XCB_GLX_BUFFER_SWAP_COMPLETE 46​#ifndef XCB_GLX_BUFFER_SWAP_COMPLETE
47#define XCB_GLX_BUFFER_SWAP_COMPLETE 1 47​#define XCB_GLX_BUFFER_SWAP_COMPLETE 1
48​
graesslinUnsubmitted
Not Done

nitpick, empty newline

graesslin: nitpick, empty newline
48typedef struct xcb_glx_buffer_swap_complete_event_t { 49​typedef struct xcb_glx_buffer_swap_complete_event_t {
49 uint8_t response_type; /**< */ 50​ uint8_t response_type; /**< */
50 uint8_t pad0; /**< */ 51​ uint8_t pad0; /**< */
Context not available.
62 63​
63#include <tuple> 64​#include <tuple>
64 65​
66​#ifndef GLX_GENERATE_RESET_ON_VIDEO_MEMORY_PURGE_NV
67​#define GLX_GENERATE_RESET_ON_VIDEO_MEMORY_PURGE_NV 0x20F7
68​#endif
69​
65#if __cplusplus <= 201103L 70​#if __cplusplus <= 201103L
66namespace std { 71​namespace std {
67 // C++-14 72​ // C++-14
Context not available.
262 0 267​ 0
263 }; 268​ };
264 269​
270​ const int attribs_31_core_nv_robustness[] = {
271​ GLX_CONTEXT_MAJOR_VERSION_ARB, 3,
272​ GLX_CONTEXT_MINOR_VERSION_ARB, 1,
273​ GLX_CONTEXT_FLAGS_ARB, GLX_CONTEXT_ROBUST_ACCESS_BIT_ARB,
274​ GLX_CONTEXT_RESET_NOTIFICATION_STRATEGY_ARB, GLX_LOSE_CONTEXT_ON_RESET_ARB,
275​ GLX_GENERATE_RESET_ON_VIDEO_MEMORY_PURGE_NV, GL_TRUE,
276​ 0
277​ };
278​
265 const int attribs_31_core[] = { 279​ const int attribs_31_core[] = {
266 GLX_CONTEXT_MAJOR_VERSION_ARB, 3, 280​ GLX_CONTEXT_MAJOR_VERSION_ARB, 3,
267 GLX_CONTEXT_MINOR_VERSION_ARB, 1, 281​ GLX_CONTEXT_MINOR_VERSION_ARB, 1,
Context not available.
284 298​
285 // Try to create a 3.1 context first 299​ // Try to create a 3.1 context first
286 if (options->glCoreProfile()) { 300​ if (options->glCoreProfile()) {
fredrikUnsubmitted
Not Done

Just an observation that this patch only enables the extension when kwin is configured to use the core profile.

fredrik: Just an observation that this patch only enables the extension when kwin is configured to use…
287 if (have_robustness) 301​ if (have_robustness && hasGLExtension("GLX_NV_robustness_video_memory_purge"))
graesslinUnsubmitted
Not Done

QByteArrayLiteral

graesslin: QByteArrayLiteral
elvisangelaccioUnsubmitted
Not Done

hasGLExtension("GLX_NV_robustness_video_memory_purge") returns false on my nvidia card + binary blob. Debug output shows that the glExtensions list in kwinglutils.cpp is empty.

elvisangelaccio: `hasGLExtension("GLX_NV_robustness_video_memory_purge")` returns false on my nvidia card +…
elvisangelaccioUnsubmitted
Not Done

Ok the bug is that you need to use hasExtension() rather than hasGLExtension(). After this small change your patch works fine (I get the "Desktop effects were restarted" notification after switching VT!)

elvisangelaccio: Ok the bug is that you need to use `hasExtension()` rather than `hasGLExtension()`. After this…
graesslinUnsubmitted
Not Done
Debug output shows that the glExtensions list in kwinglutils.cpp is empty.

That one is no longer used. You can check in KWin debug console (KRunner enter "KWin") in the OpenGL tab which extensions are available.

graesslin: > Debug output shows that the glExtensions list in kwinglutils.cpp is empty. That one is no…
302​ ctx = glXCreateContextAttribsARB(display(), fbconfig, 0, direct, attribs_31_core_nv_robustness);
303​
304​ else if (have_robustness)
graesslinUnsubmitted
Not Done

maybe we should not use an else-if here, but instead try the have_robustness if creating the context failed (like the other cases).

graesslin: maybe we should not use an else-if here, but instead try the have_robustness if creating the…
288 ctx = glXCreateContextAttribsARB(display(), fbconfig, 0, direct, attribs_31_core_robustness); 305​ ctx = glXCreateContextAttribsARB(display(), fbconfig, 0, direct, attribs_31_core_robustness);
289 306​
290 if (!ctx) 307​ if (!ctx)
Context not available.