Differential D22614 Diff 62197 src/backend/generalTest/HypothesisTest.cpp

Changeset View

Standalone View

View Options

src/backend/generalTest/HypothesisTest.cpp

Context not available.
70 m_statisticValue.clear(); 70​ m_statisticValue.clear();
71 m_statsTable = ""; 71​ m_statsTable = "";
72 m_tooltips.clear(); 72​ m_tooltips.clear();
73 for (int i = 0; i < 10; i++) 73​ for (int i = 0; i < RESULTLINESCOUNT; i++)
74 m_resultLine[i]->clear(); 74​ m_resultLine[i]->clear();
75 75​
76 switch (test.subtype) { 76​ switch (test.subtype) {
Context not available.
110 m_statisticValue.clear(); 110​ m_statisticValue.clear();
111 m_statsTable = ""; 111​ m_statsTable = "";
112 m_tooltips.clear(); 112​ m_tooltips.clear();
113 for (int i = 0; i < 10; i++) 113​ for (int i = 0; i < RESULTLINESCOUNT; i++)
114 m_resultLine[i]->clear(); 114​ m_resultLine[i]->clear();
115 115​
116 m_currTestName = "<h2>" + i18n("Levene Test for Equality of Variance") + "</h2>"; 116​ m_currTestName = "<h2>" + i18n("Levene Test for Equality of Variance") + "</h2>";
Context not available.
155 printError("Atleast two values should be there in every column"); 155​ printError("Atleast two values should be there in every column");
156 return; 156​ return;
157 } 157​ }
158 if (std[i] == 0) { 158​ if (std[i] <= 0) {
sgerlachUnsubmitted
Done

<= contradicts error message. Can std be < 0? (fix everywhere)

sgerlach: <= contradicts error message. Can std be < 0? (fix everywhere)
devanshuagarwalAuthorUnsubmitted
Done

No std cant be < 0.

In starting I wrote

if (std[i] == 0) {
}

but then it shows warning.
Comparing floating point with == or != is unsafe.

Hence I have used <=

devanshuagarwal: No std cant be < 0. In starting I wrote ``` if (std[i] == 0) { } ``` but then it shows…
sgerlachUnsubmitted
Done

you should do a floating point comparison like "std[i] < DBL_MIN" or use gsl_fcmp().

sgerlach: you should do a floating point comparison like "std[i] < DBL_MIN" or use gsl_fcmp().
159 printError(i18n("Standard Deviation of atleast one column is equal to 0: last column is: %1", m_columns[i]->name())); 159​ printError(i18n("Standard Deviation of atleast one column is equal to 0: last column is: %1", m_columns[i]->name()));
sgerlachUnsubmitted
Done

"atleast" -> "at least" (fix everywhere)

sgerlach: "atleast" -> "at least" (fix everywhere)
160 return; 160​ return;
161 } 161​ }
Context not available.
213 printError("Atleast two values should be there in every column"); 213​ printError("Atleast two values should be there in every column");
214 return; 214​ return;
215 } 215​ }
216 if (std[i] == 0) { 216​ if (std[i] <= 0) {
217 printError( i18n("Standard Deviation of atleast one column is equal to 0: last column is: %1", m_columns[i]->name())); 217​ printError( i18n("Standard Deviation of atleast one column is equal to 0: last column is: %1", m_columns[i]->name()));
218 return; 218​ return;
219 } 219​ }
Context not available.
322 322​
323 m_statsTable = getHtmlTable(2, 5, rowMajor); 323​ m_statsTable = getHtmlTable(2, 5, rowMajor);
324 324​
325 if (std == 0) { 325​ if (std <= 0) {
326 printError("Standard deviation of the difference is 0"); 326​ printError("Standard deviation of the difference is 0");
327 return; 327​ return;
328 } 328​ }
Context not available.
404 404​
405 m_statsTable = getHtmlTable(2, 5, rowMajor); 405​ m_statsTable = getHtmlTable(2, 5, rowMajor);
406 406​
407 if (std == 0) { 407​ if (std <= 0) {
408 printError("Standard deviation is 0"); 408​ printError("Standard deviation is 0");
409 return; 409​ return;
410 } 410​ }
Context not available.
645 groupMean[i][j] /= replicates[i][j]; 645​ groupMean[i][j] /= replicates[i][j];
646 } 646​ }
647 647​
648 // for (int i = 0; i < np_a; i++) ​
649 // for (int j = 0; j < np_b; j++) ​
650 // groupMean[i][j] = int(groupMean[i][j]); ​
651 ​
652 double ss_within = 0; 648​ double ss_within = 0;
653 for (int i = 0; i < totalRows_a; i++) { 649​ for (int i = 0; i < totalRows_a; i++) {
654 QString name_a = m_columns[0]->textAt(i); 650​ QString name_a = m_columns[0]->textAt(i);
Context not available.
661 int df_within = (replicate - 1) * np_a * np_b; 657​ int df_within = (replicate - 1) * np_a * np_b;
662 double ms_within = ss_within / df_within; 658​ double ms_within = ss_within / df_within;
663 659​
664 double mean_a[np_a]; 660​ double* mean_a = new double[np_a];
665 double mean_b[np_b]; 661​ double* mean_b = new double[np_b];
666 for (int i = 0; i < np_a; i++) { 662​ for (int i = 0; i < np_a; i++) {
667 for (int j = 0; j < np_b; j++) { 663​ for (int j = 0; j < np_b; j++) {
668 mean_a[i] += groupMean[i][j] / np_b; 664​ mean_a[i] += groupMean[i][j] / np_b;
Context not available.
701 int df_interaction = (np_a - 1) * (np_b - 1); 697​ int df_interaction = (np_a - 1) * (np_b - 1);
702 double ms_interaction = ss_interaction / df_interaction; 698​ double ms_interaction = ss_interaction / df_interaction;
703 699​
704 QString partitionNames_a[np_a]; 700​ QString* partitionNames_a = new QString[np_a];
705 QString partitionNames_b[np_b]; 701​ QString* partitionNames_b = new QString[np_b];
706 702​
707 QMapIterator<QString, int> itr_a(catToNumber_a); 703​ QMapIterator<QString, int> itr_a(catToNumber_a);
708 while (itr_a.hasNext()) { 704​ while (itr_a.hasNext()) {
Context not available.
806 m_pValue.append(m_pValue_a); 802​ m_pValue.append(m_pValue_a);
807 m_pValue.append(m_pValue_b); 803​ m_pValue.append(m_pValue_b);
808 804​
805​ delete[] mean_a;
806​ delete[] mean_b;
807​ delete[] partitionNames_a;
808​ delete[] partitionNames_b;
809​
809 return; 810​ return;
810} 811​}
811 812​
Context not available.