Differential D22457 Diff 61752 applet/contents/ui/ShowQR.qml

Changeset View

Standalone View

View Options

applet/contents/ui/ShowQR.qml

  • This file was added.
1​/*
2​ Copyright 2019 Aleix Pol Gonzalez <aleixpol@kde.org>
3​
4​ This library is free software; you can redistribute it and/or
5​ modify it under the terms of the GNU Lesser General Public
6​ License as published by the Free Software Foundation; either
7​ version 2.1 of the License, or (at your option) version 3, or any
8​ later version accepted by the membership of KDE e.V. (or its
9​ successor approved by the membership of KDE e.V.), which shall
10​ act as a proxy defined in Section 6 of version 3 of the license.
11​
12​ This library is distributed in the hope that it will be useful,
13​ but WITHOUT ANY WARRANTY; without even the implied warranty of
14​ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
15​ Lesser General Public License for more details.
16​
17​ You should have received a copy of the GNU Lesser General Public
18​ License along with this library. If not, see <http://www.gnu.org/licenses/>.
19​*/
20​
21​import QtQuick 2.0
22​import QtQuick.Window 2.0
23​import QtQuick.Layouts 1.0
24​import org.kde.kirigami 2.3 as Kirigami
25​import org.kde.prison 1.0 as Prison
26​
broulikUnsubmitted
Done

Add this as RUNTIME Cmake dependency

broulik: Add this as `RUNTIME` Cmake dependency
27​Window
28​{
broulikUnsubmitted
Not Done

Can you instad do a StackView and show the barcode inside the applet like Klipper does it? This would make it more consistent.

broulik: Can you instad do a `StackView` and show the barcode inside the applet like Klipper does it?
apolAuthorUnsubmitted
Not Done

I thought about that too, my use-case was though to give access to wifi on somebody by my side, making them aim at my screen would be weird.

apol: I thought about that too, my use-case was though to give access to wifi on somebody by my side…
29​ id: window
30​ width: 640
31​ height: 320
32​ color: Qt.rgba(0, 0, 0, 0.3)
33​ flags: Qt.FramelessWindowHint
34​
35​ property alias content: dataInput.content
36​
37​ MouseArea {
38​ anchors.fill: parent
39​
40​ onClicked: {
41​ window.visible = false
42​ window.destroy()
43​ }
44​
45​ ColumnLayout {
ngrahamUnsubmitted
Done

I don't think you need to use a ColumnLayout if it'll have only one item in it. You can just add margins to the Prison item itself.

ngraham: I don't think you need to use a ColumnLayout if it'll have only one item in it. You can just…
apolAuthorUnsubmitted
Not Done

Yes, good catch. I had something there and ended up removing it.

apol: Yes, good catch. I had something there and ended up removing it.
46​ anchors {
47​ fill: parent
48​ margins: Kirigami.Units.largeSpacing * 4
49​ }
50​
51​ Prison.Barcode {
52​ id: dataInput
53​ Layout.fillWidth: true
54​ Layout.fillHeight: true
ngrahamUnsubmitted
Done

These won't do anything because it's not in a Layout anymore

ngraham: These won't do anything because it's not in a Layout anymore
55​ barcodeType: "QRCode"
56​ }
57​ }
58​ }
59​}