Differential D21970 Diff 61391 src/util/externalcommand_polkitbackend.cpp

Changeset View

Standalone View

src/util/externalcommand_polkitbackend.cpp

This file was added.

1		/*************************************************************************
2		* Copyright (C) 2019 by Shubham <shubham.jangra@kdemail.net> *
3		* *
4		* This program is free software; you can redistribute it and/or *
5		* modify it under the terms of the GNU General Public License as *
6		* published by the Free Software Foundation; either version 3 of *
7		* the License, or (at your option) any later version. *
8		* *
9		* This program is distributed in the hope that it will be useful, *
10		* but WITHOUT ANY WARRANTY; without even the implied warranty of *
11		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
12		* GNU General Public License for more details. *
13		* *
14		* You should have received a copy of the GNU General Public License *
15		* along with this program. If not, see <http://www.gnu.org/licenses/>.*
16		*************************************************************************/
17
18		#include "util/externalcommand_polkitbackend.h"
19
20		#include <QApplication>
21		#include <QDebug>
22		#include <QDBusConnection>
23		#include <QDBusConnectionInterface>
24		#include <QEventLoop>
25		#include <QString>
26		#include <QTimer>
27		#include <QWidget>
28
29		#include <PolkitQt1/Authority>
30		#include <PolkitQt1/Subject>
31
32		using namespace PolkitQt1;
33
34		namespace Auth
35		{
36
37		PolkitEventLoop::PolkitEventLoop(QObject *parent)
38		: QEventLoop(parent),
39		m_result(Authority::No)
40		{
41
42		}
43
44		PolkitEventLoop::~PolkitEventLoop()
45		{
46
47		}
48
49		void PolkitEventLoop::requestQuit(const Authority::Result &result)
50		{
51		m_result = result;
52		}
53
54		Authority::Result PolkitEventLoop::result() const
55		{
56		return m_result;
57		}
58
59		PolkitQt1Backend::PolkitQt1Backend()
60		: m_flyingActions(false)
61		{
62		// Connect various useful Polkit signals
63		connect(Authority::instance(), &Authority::configChanged, this, &Auth::PolkitQt1Backend::authStatusChanged);
64		connect(Authority::instance(), &Authority::consoleKitDBChanged, this, &Auth::PolkitQt1Backend::authStatusChanged);
65
66		// Take the current action into account.
67		m_flyingActions = true;
68		}
69
70		PolkitQt1Backend::~PolkitQt1Backend()
71		{
72
73		}
74
75		void PolkitQt1Backend::initPolkitAgent(const QString &action, QWidget parent /= nullptr*/) const
76		{
77		if (!parent) {
78		qWarning() << "Parent widget does not exists, can not proceed further";
79		return;
80		}
81
82		// Check if we are running terminal session or GUI session
83		if (!qApp) {
84		qWarning() << "We are running a TTY (Terminal) session";
85		qDebug() << "Can not proceed further since we do not support Text based Polkit Authentication Agent";
86		return;
87		}
88
89		// Get the dialog parent window Id
90		quint64 parentWindowID = parent->effectiveWinId();
91
92		// Make a call to the KDE polkit Authentication Agent asking for it's services
93		QDBusMessage callAgent = QDBusMessage::createMethodCall(QLatin1String("org.kde.polkit-kde-authentication-agent-1"), QLatin1String("/org/kde/Polkit1AuthAgent"), QLatin1String("org.kde.Polkit1AuthAgent"),
	stikonasUnsubmitted Done I'll have to read a bit more about polkit, but this requirement sounds strange. It shouldn't be necessary to have kde-authentication-agent-1. Some users might be on other desktop environments and use their own polkit authentication agent, e.g. `polkit-gnome-authentication-agent-1`. stikonas: I'll have to read a bit more about polkit, but this requirement sounds strange. It shouldn't…
94		QLatin1String("setWindowIdForAction"));
95
96		callAgent << action;
97		callAgent << parentWindowID;
98
99		QDBusPendingCall call = QDBusConnection::sessionBus().asyncCall(callAgent);
100		call.waitForFinished();
101
102		auto watcher = new QDBusPendingCallWatcher(call);
103
104		connect(watcher, &QDBusPendingCallWatcher::finished, this, [this, action, watcher](){
105
106		const QDBusMessage reply = watcher->reply();
107
108		if (reply.type() == QDBusMessage::ErrorMessage) {
109		qWarning() << "Could not call the Authentication Agent, Error:" << reply.errorMessage();
110		}
111
112		watcher->deleteLater();
113		});
114		}
115
116		Authority::Result PolkitQt1Backend::actionStatus(const QString &action, const QByteArray &callerID) const
117		{
118		SystemBusNameSubject subject(QString::fromUtf8(callerID));
119
120		auto authority = PolkitQt1::Authority::instance();
121
122		auto result = authority->checkAuthorizationSync(action, subject, Authority::None);
123
124		if (authority->hasError()) {
125		qDebug() << "Encountered error while checking action status, Error code:" << authority->lastError() << "\nError Details:" << authority->errorDetails();
126		authority->clearError();
127		}
128
129		return result;
130		}
131
132		QByteArray PolkitQt1Backend::callerID() const
133		{
134		return QDBusConnection::systemBus().baseService().toUtf8();
135		}
136
137		bool PolkitQt1Backend::authorizeAction(const QString &action, const QByteArray &callerID)
138		{
139		SystemBusNameSubject subject(QString::fromUtf8(callerID));
140
141		auto authority = Authority::instance();
142
143		PolkitEventLoop event(qobject_cast<QObject *>(qApp));
144
145		connect(authority, &Authority::checkAuthorizationFinished, &event, &PolkitEventLoop::requestQuit);
146
147		authority->checkAuthorizationSync(action, subject, Authority::AllowUserInteraction);
148
149		event.exec();
150
151		if (authority->hasError()) {
152		qWarning() << "Encountered error while checking authorization, Error code:" << authority->lastError() << "\n" <<"Error details:" << authority->errorDetails();
153
154		// Clear all the errors from the buffer so that hasError() does not give previous error as a result when called later
155		authority->clearError();
156		}
157
158		if (event.result() == Authority::Yes) {
159		// Emit signal signalling that current action is authorized by the authority instance
160		emit actionAuthorized(true);
161		return true;
162		} else {
163		emit actionAuthorized(false);
164		return false;
165		}
166		}
167
168		bool stopAction(const QString &action, const QByteArray &callerID)
169		{
170		Q_UNUSED(action)
171
172		SystemBusNameSubject subject(QString::fromUtf8(callerID));
173
174		auto authority = Authority::instance();
175
176		PolkitEventLoop event(qobject_cast<QObject *>(qApp));
177
178		//connect(authority, &Authority::revokeTemporaryAuthorizationsFinished, &event, &PolkitEventLoop::requestQuit);
179
180		event.exec();
181
182		return authority->revokeTemporaryAuthorizationsSync(subject);
183		}
184
185		void PolkitQt1Backend::quit() const
186		{
187
188		}
189
190		void PolkitQt1Backend::authStatusChanged()
191		{
192		for (auto it = m_cachedResults.begin(); it != m_cachedResults.end(); ++it) {
193		const QString action = it.key();
194		QByteArray pid = QDBusConnection::systemBus().baseService().toUtf8();
195		if (it.value() != actionStatus(action, pid)) {
196		*it = actionStatus(action, pid);
197		}
198		}
199
200		// Force updating known actions
201		Authority::instance()->enumerateActions();
202		m_flyingActions = true;
203		}
204
205		void PolkitQt1Backend::updateCachedActions(const ActionDescription::List &actions)
206		{
207		Q_UNUSED(actions)
208		}
209
210		} // namespace Auth
211
212		#include "moc_externalcommand_polkitbackend.cpp"