Differential D22144 Diff 60789 recentlyused/CMakeLists.txt

Changeset View

Standalone View

View Options

recentlyused/CMakeLists.txt

  • This file was added.
1​add_definitions(-DTRANSLATION_DOMAIN=\"kio5_recentlyused\")
2​
3​find_package(KF5 ${KF5_MIN_VERSION} REQUIRED COMPONENTS
4​ KIO
dfaureUnsubmitted
Done

this was already done by the parent CMakeLists.txt, wasn't it? Why do it again?

dfaure: this was already done by the parent CMakeLists.txt, wasn't it? Why do it again?
5​ I18n
6​ Activities
7​ ActivitiesStats
8​)
9​
10​set(
11​ kio_recentlyused_SRCS
12​
dfaureUnsubmitted
Done

join with previous line, it looks very strange this way

dfaure: join with previous line, it looks very strange this way
13​ recentlyused.cpp
14​)
15​
16​ecm_qt_declare_logging_category(kio_recentlyused_SRCS
17​ HEADER recentlyused-logsettings.h
18​ IDENTIFIER KIO_RECENTLYUSED_LOG
19​CATEGORY_NAME log_kio_recentlyused)
20​
21​add_library(recentlyused MODULE ${kio_recentlyused_SRCS})
22​
23​target_link_libraries(recentlyused
24​ KF5::KIOCore
25​ KF5::I18n
26​ KF5::Activities
27​ KF5::ActivitiesStats)
28​set_target_properties(recentlyused PROPERTIES OUTPUT_NAME "recentlyused")
29​install(TARGETS recentlyused DESTINATION ${KDE_INSTALL_PLUGINDIR}/kf5/kio)
30​
dfaureUnsubmitted
Done

You should also set LIBRARY_OUTPUT_DIRECTORY, see https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled

dfaure: You should also set LIBRARY_OUTPUT_DIRECTORY, see https://community.kde.
mevenAuthorUnsubmitted
Done

This will be the first ioslave in kio-extras using it...
Some of the ioslave even use the old protocol files...
Might be a followup maintenance Diff...

meven: This will be the first ioslave in kio-extras using it... Some of the ioslave even use the old…
31​install( FILES recentlyused.protocol DESTINATION ${KDE_INSTALL_KSERVICES5DIR} )