Differential D22062 Diff 60548 kdevplatform/outputview/outputfilteringstrategies.h

Changeset View

Standalone View

View Options

kdevplatform/outputview/outputfilteringstrategies.h

Show First 20 Lines • Show All 75 Lines • ▼ Show 20 Line(s)
76 76​
77/** 77​/**
78 * This filter strategy filters out errors (no actions) from Python and PHP scripts. 78​ * This filter strategy filters out errors (no actions) from Python and PHP scripts.
79 **/ 79​ **/
80class KDEVPLATFORMOUTPUTVIEW_EXPORT ScriptErrorFilterStrategy : public IFilterStrategy 80​class KDEVPLATFORMOUTPUTVIEW_EXPORT ScriptErrorFilterStrategy : public IFilterStrategy
81{ 81​{
82 82​
83public: 83​public:
84 ScriptErrorFilterStrategy(); 84​ ScriptErrorFilterStrategy(const QString& scriptdir = QString());
kossebauUnsubmitted
Done

Make constructor explicit, scriptdir -> scriptDir.
To improve over the existing code, please add some API dox what value exactly is expected with th argument scriptDir, not immediately obvious to me (as non-.script code developer).

kossebau: Make constructor `explicit`, scriptdir -> scriptDir. To improve over the existing code, please…
85 85​
86 FilteredItem errorInLine(const QString& line) override; 86​ FilteredItem errorInLine(const QString& line) override;
87 87​
88 FilteredItem actionInLine(const QString& line) override; 88​ FilteredItem actionInLine(const QString& line) override;
89 89​private:
90​ QString scriptDir;
kossebauUnsubmitted
Done

For consistency, please add instead a pimpl

const QScopedPointer<class ScriptErrorFilterStrategyPrivate> d;

similar to CompilerFilterStrategy

kossebau: For consistency, please add instead a pimpl ``` const QScopedPointer<class…
90}; 91​};
91 92​
92/** 93​/**
93 * This filter strategy filters out errors (no actions) from runtime debug output of native applications 94​ * This filter strategy filters out errors (no actions) from runtime debug output of native applications
94 * 95​ *
95 * This is especially useful for runtime output of Qt applications, for example lines such as: 96​ * This is especially useful for runtime output of Qt applications, for example lines such as:
96 * "ASSERT: "errors().isEmpty()" in file /tmp/foo/bar.cpp", line 49" 97​ * "ASSERT: "errors().isEmpty()" in file /tmp/foo/bar.cpp", line 49"
97 */ 98​ */
Show All 27 Lines