Differential D21970 Diff 60267 src/util/externalcommand_polkitbackend.cpp

Changeset View

Standalone View

src/util/externalcommand_polkitbackend.cpp

This file was added.

1		/*************************************************************************
2		* Copyright (C) 2019 by Shubham <shubham.jangra@kdemail.net> *
3		* *
4		* This program is free software; you can redistribute it and/or *
5		* modify it under the terms of the GNU General Public License as *
6		* published by the Free Software Foundation; either version 3 of *
7		* the License, or (at your option) any later version. *
8		* *
9		* This program is distributed in the hope that it will be useful, *
10		* but WITHOUT ANY WARRANTY; without even the implied warranty of *
11		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
12		* GNU General Public License for more details. *
13		* *
14		* You should have received a copy of the GNU General Public License *
15		* along with this program. If not, see <http://www.gnu.org/licenses/>.*
16		*************************************************************************/
17
18		#include "util/externalcommand_polkitbackend.h"
19
20		#include <QApplication>
21		#include <QByteArray>
22		#include <QCoreApplication>
23		#include <QDebug>
24		#include <QDBusConnection>
25		#include <QDBusConnectionInterface>
26		#include <QEventLoop>
27		#include <QString>
28		#include <QStringList>
29		#include <QTimer>
30		#include <QWidget>
31
32		#include <PolkitQt1/Authority>
33		#include <PolkitQt1/ActionDescription>
34		#include <PolkitQt1/Subject>
35
36		using namespace PolkitQt1;
37
38		namespace Auth
39		{
40
41		PolkitEventLoop::PolkitEventLoop(QObject *parent)
42		: QEventLoop(parent),
43		m_result(result())
44		{
45
46		}
47
48		PolkitEventLoop::~PolkitEventLoop()
49		{
50
51		}
52
53		void PolkitEventLoop::requestQuit(const Authority::Result &result)
54		{
55		m_result = result;
56		quit();
57		}
58
59		Authority::Result PolkitEventLoop::result() const
60		{
61		return m_result;
62		}
63
64		PolkitQt1Backend::PolkitQt1Backend()
65		: m_existingActions(QStringList()),
66		m_flyingActions(false)
67		{
68		// Connect various useful Polkit signals
69		connect(Authority::instance(), &Authority::configChanged, this, &Auth::PolkitQt1Backend::checkForResultChanged);
70		connect(Authority::instance(), &Authority::consoleKitDBChanged, this, &Auth::PolkitQt1Backend::checkForResultChanged);
71
72		//connect(Authority::instance(), /SIGNAL(consoleKitDBChanged())/&Gui::dataChanged, this, /SLOT(checkForResultChanged())/ &Auth::PolkitQt1Backend::checkForResultChanged);
73		//connect(Authority::instance(), /SIGNAL(enumerateActionsFinished(PolkitQt1::ActionDescription::List))/,this, /SLOT(updateCachedActions(PolkitQt1::ActionDescription::List))/);
74
75		// Take the current action into account.
76		m_flyingActions = true;
77
78
79		}
80
81		PolkitQt1Backend::~PolkitQt1Backend()
82		{
83
84		}
85
86		void PolkitQt1Backend::initPolkitAgent(const QString &action, QWidget parent /= nullptr*/)
87		{
88		if (!parent) {
89		qWarning() << "Parent widget does not exists, can not proceed further";
90		return;
91		}
92
93		// Check if KDE authentication agent exists
	stikonasUnsubmitted Done I'll have to read a bit more about polkit, but this requirement sounds strange. It shouldn't be necessary to have kde-authentication-agent-1. Some users might be on other desktop environments and use their own polkit authentication agent, e.g. `polkit-gnome-authentication-agent-1`. stikonas: I'll have to read a bit more about polkit, but this requirement sounds strange. It shouldn't…
94		if (QDBusConnection::sessionBus().interface()->isServiceRegistered(QLatin1String("org.kde.polkit-kde-authentication-agent-1"))) {
95		// Check if we are running terminal session or GUI session
96		if (!qApp \|\| !qobject_cast<QApplication *>(qApp)) {
97		qWarning() << "We are running a TTY session";
98		}
99
100		// Retrieve the dialog root window Id
101		qulonglong wId = parent->effectiveWinId();
102
103		// Send it over the bus to our agent
104		QDBusMessage methodCall =
105		QDBusMessage::createMethodCall(QLatin1String("org.kde.polkit-kde-authentication-agent-1"), QLatin1String("/org/kde/Polkit1AuthAgent"), QLatin1String("org.kde.Polkit1AuthAgent"),
106		QLatin1String("setWIdForAction"));
107
108		methodCall << action;
109		methodCall << wId;
110
111		QDBusPendingCall call = QDBusConnection::sessionBus().asyncCall(methodCall);
112		call.waitForFinished();
113
114		if (call.isError()) {
115		qWarning() << "ERROR while streaming the parent!!" << call.error();
116		}
117		} else {
118		qInfo() << "KDE polkit agent appears too old or not registered on the bus";
119		}
120		}
121
122		Authority::Result PolkitQt1Backend::actionStatus(const QString &action, QByteArray &callerID)
123		{
124		// Get the process ID of the caller
125		SystemBusNameSubject subject(QString::fromUtf8(callerID));
126
127		auto authority = PolkitQt1::Authority::instance();
128
129		auto result = authority->checkAuthorizationSync(action, subject, Authority::None);
130
131		if (authority->hasError()) {
132		qDebug() << "Encountered error while checking action status, error code:" << authority->lastError() << "\nError Details:" << authority->errorDetails();
133
134		// Clear all the errors from the buffer so that hasError() does not give previous error as a result when called later
135		authority->clearError();
136		}
137
138		return result;
139		}
140
141		QByteArray PolkitQt1Backend::callerID() const
142		{
143		// Get the current Application process ID
144		return QDBusConnection::systemBus().baseService().toUtf8();
145		}
146
147		bool PolkitQt1Backend::isCallerAuthorized(const QString &action, QByteArray &callerID)
148		{
149		SystemBusNameSubject subject(QString::fromUtf8(callerID));
150		Authority *authority = Authority::instance();
151
152		PolkitEventLoop event;
153
154		connect(authority, &Authority::checkAuthorizationFinished, &event, &PolkitEventLoop::requestQuit);
155
156		authority->checkAuthorizationSync(action, subject, Authority::None);
157
158		event.exec();
159
160		if (authority->hasError()) {
161		qWarning() << "Encountered error while checking authorization, Error code:" << authority->lastError() << "\n" <<"Error details:" << authority->errorDetails();
162
163		// Clear all the errors from the buffer so that hasError() does not give previous error as a result when called later
164		authority->clearError();
165		}
166
167		if (event.result() == Authority::Yes) {
168		// Emit signal signalling that current action is authorized by the authority instance
169		emit actionAuthorized(true);
170		return true;
171		} else {
172		emit actionAuthorized(false);
173		return false;
174		}
175		}
176
177		bool PolkitQt1Backend::actionAlreadyExists(const QString &action)
178		{
179		auto authority = Authority::instance();
180
181		if (m_flyingActions && authority->hasError() /&& !authority->enumerateActionsSync()/) {
182		// This can happen if enumerateActions call failed
183		qWarning() << "Encountered error while checking authorization, Error code:" << authority->lastError() << "\n" <<"Error details:" << authority->errorDetails();
184
185		// Clear all the errors from the buffer so that hasError() does not give previous error as a result when called later
186		authority->clearError();
187
188		m_flyingActions = false;
189		}
190
191		// Any flying actions?
192		if (m_flyingActions) {
193		int tries = 0;
194		while (m_flyingActions && tries < 10) {
195		// Wait max 2 seconds
196		QEventLoop e;
197		QTimer::singleShot(2000, &e, /&quit/SLOT(quit()));
198		e.exec();
199		++tries;
200		}
201		}
202
203		return m_existingActions.contains(action);
204		}
205
206		Authority::ErrorCode PolkitQt1Backend::pollError() const
207		{
208		// Get current instance of the Authority
209		auto authority = Authority::instance();
210
211		if (authority->hasError()) {
212		return authority->lastError();
213		}
214
215		return Authority::E_None;
216		}
217
218		// Dummy function for calling QTimer
219		void PolkitQt1Backend::quit() const
220		{
221
222		}
223
224		void PolkitQt1Backend::sendProgressStep(const int percent)
225		{
226
227		}
228
229		void PolkitQt1Backend::sendProgressStep(const QVariantMap &step)
230		{
231
232		}
233
234		void PolkitQt1Backend::checkForResultChanged()
235		{
236		for (auto it = m_cachedResults.begin(); it != m_cachedResults.end(); ++it) {
237		const QString action = it.key();
238		QByteArray pid = QDBusConnection::systemBus().baseService().toUtf8();
239		if (it.value() != actionStatus(action, pid)) {
240		*it = actionStatus(action, pid);
241		}
242		}
243
244		// Force updating known actions
245		Authority::instance()->enumerateActions();
246		m_flyingActions = true;
247		}
248
249		void PolkitQt1Backend::updateCachedActions(const ActionDescription::List &actions)
250		{
251
252		}
253
254		} // namespace Auth
255
256
257
258