Differential D21850 Diff 59953 kmymoney/views/khomeview_p.h

Changeset View

Standalone View

View Options

kmymoney/views/khomeview_p.h

Context not available.
1230 case Account::Type::Loan: 1230​ case Account::Type::Loan:
1231 // list account if it's the last in the hierarchy or has transactions in it 1231​ // list account if it's the last in the hierarchy or has transactions in it
1232 if ((*it).accountList().isEmpty() || (file->transactionCount((*it).id()) > 0)) { 1232​ if ((*it).accountList().isEmpty() || (file->transactionCount((*it).id()) > 0)) {
1233 liabilities << *it; 1233​ // Add it if we are not hiding zero balance liabilities, or the balance is not zero
1234​ const auto value =
tbaumgartUnsubmitted
Not Done

I would change this into:

const auto value = MyMoneyFile::instance()->balance((*it).id(), QDate::currentDate());
if (!(KMyMoneySettings::hideZeroBalanceLiabilities() &&
            value.isZero())) {
tbaumgart: I would change this into: ``` const auto value = MyMoneyFile::instance()->balance((*it).id()…
1235​ MyMoneyFile::instance()->balance((*it).id(), QDate::currentDate());
1236​ if (!(KMyMoneySettings::hideZeroBalanceLiabilities() && value.isZero())) {
1237​ liabilities << *it;
1238​ }
1234 } 1239​ }
1235 break; 1240​ break;
1236 1241​
Context not available.