Differential D21638 Diff 59314 src/Gui/TimerProgress.cpp

Changeset View

Standalone View

View Options

src/Gui/TimerProgress.cpp

  • This file was added.
1​/* This file is part of Spectacle, the KDE screenshot utility
2​ * Copyright 2019 David Redondo <kde@david-redondo.de>
3​ * Copyright 2016 Kai Uwe Broulik <kde@privat.broulik.de>
4​ *
5​ * This program is free software; you can redistribute it and/or modify
6​ * it under the terms of the GNU Lesser General Public License as published by
7​ * the Free Software Foundation; either version 2 of the License, or
8​ * (at your option) any later version.
9​ *
10​ * This program is distributed in the hope that it will be useful,
11​ * but WITHOUT ANY WARRANTY; without even the implied warranty of
12​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13​ * GNU General Public License for more details.
14​ *
15​ * You should have received a copy of the GNU Lesser General Public License
16​ * along with this program; if not, write to the Free Software
17​ * Foundation, Inc., 51 Franklin Street, Fifth Floor,
18​ * Boston, MA 02110-1301, USA.
19​ *
20​ * SPDX-License-Identifier: LGPL-2.0-or-later
21​ */
22​
23​#include "TimerProgress.h"
24​
25​#include <KAboutData>
broulikUnsubmitted
Done

Unused

broulik: Unused
26​
27​#include <QDBusConnection>
28​#include <QDBusMessage>
29​#include <QTimer>
30​#include <QVariantMap>
31​
32​const TimerProgress& TimerProgress::fromTimer(QTimer* timer, int updateIntervall)
broulikUnsubmitted
Done

interval with one L

broulik: interval with one L
davidreAuthorUnsubmitted
Not Done

Maybe I could make all the timer stuff const QTimer* const or (better?) const QTimer& ?

davidre: Maybe I could make all the timer stuff const QTimer* const or (better?) const QTimer& ?
33​{
34​ return *(new TimerProgress(timer, updateIntervall));
anthonyfieroniUnsubmitted
Done

You don't need to return if you don't use. To not leak make timer parent of TimerProgress.

anthonyfieroni: You don't need to return if you don't use. To not leak make timer parent of TimerProgress.
35​}
36​
37​TimerProgress::TimerProgress(QTimer *timer, int updateIntervall, QObject *parent) : QObject(parent), mTimer(timer), mUpdateTimer(new QTimer(this))
broulikUnsubmitted
Done

Please spread this out over multiple lines for readability

TimerProgress::TimerProgress(...)
    : QObject(parent)
    , mTimer(timer)
    , ...
{
broulik: Please spread this out over multiple lines for readability ``` TimerProgress::TimerProgress(...
38​{
39​ update({ {QStringLiteral("progress-visible"), true} });
40​ mUpdateTimer->setInterval(updateIntervall);
41​ connect(mUpdateTimer, &QTimer::timeout, this, [this] {update({ {QStringLiteral("progress"), progress() / 100.0} });;});
broulikUnsubmitted
Done

Please cleanup the coding style in this area

broulik: Please cleanup the coding style in this area
42​ connect(mTimer, &QTimer::timeout, this, [this]{
43​ update({ {QStringLiteral("progress-visible"), false} });
44​ delete this;});
45​ mUpdateTimer->start();
46​}
47​
48​TimerProgress::~TimerProgress() = default;
49​
50​
davidreAuthorUnsubmitted
Not Done

Should I use deleteLater() here, too?

davidre: Should I use deleteLater() here, too?
broulikUnsubmitted
Not Done

Since you're not deleting the object that emitted the signal, should be safe

broulik: Since you're not deleting the object that emitted the signal, should be safe
51​int TimerProgress::progress() const
anthonyfieroniUnsubmitted
Done

Remove, parent is better than delete this.

anthonyfieroni: Remove, parent is better than `delete this`.
52​{
53​ return (mTimer->interval() - mTimer->remainingTime()) * 100 / mTimer->interval();
54​}
55​
56​void TimerProgress::update(const QVariantMap &properties)
57​{
58​ QDBusMessage message = QDBusMessage::createSignal(QStringLiteral("/org/kdevelop/UnityLauncher"),
59​ QStringLiteral("com.canonical.Unity.LauncherEntry"),
60​ QStringLiteral("Update"));
61​ message.setArguments({QStringLiteral("org.kde.spectacle.desktop"), properties});
broulikUnsubmitted
Done

Use QGuiApplication::desktopFileName()

broulik: Use `QGuiApplication::desktopFileName()`
62​ QDBusConnection::sessionBus().send(message);
63​}