Differential D21615 Diff 59234 bin/Packager/Nsis/NullsoftInstaller.nsi

Changeset View

Standalone View

View Options

bin/Packager/Nsis/NullsoftInstaller.nsi

Show First 20 Lines • Show All 155 Lines • ▼ Show 20 Line(s)
156AddSize @{installSize} 156​AddSize @{installSize}
157 157​
158WriteUninstaller "${uninstaller}" 158​WriteUninstaller "${uninstaller}"
159 159​
160SectionEnd 160​SectionEnd
161 161​
162; create shortcuts 162​; create shortcuts
163Section 163​Section
164SetShellVarContext all 164​${If} $MultiUser.InstallMode == "CurrentUser"
165​ SetShellVarContext current
vonrethUnsubmitted
Not Done

Hm do we need to touch SetShellVarContext at all?
I don't think we need it now that we have use the MultiUser stuff, does it work without this call?

vonreth: Hm do we need to touch SetShellVarContext at all? I don't think we need it now that we have…
brute4s99AuthorUnsubmitted
Not Done

Without this change, the shortcuts are installed in the global $SMPROGRAMS and thus does not respect the "install only for me" option during installation.
I haven't tried without the call, I can try it some time today :)

brute4s99: Without this change, the shortcuts are installed in the global $SMPROGRAMS and thus does not…
166​${EndIf}
165!insertmacro MUI_STARTMENU_WRITE_BEGIN Application 167​!insertmacro MUI_STARTMENU_WRITE_BEGIN Application
166CreateDirectory "$SMPROGRAMS\$StartMenuFolder" 168​CreateDirectory "$SMPROGRAMS\$StartMenuFolder"
167SetOutPath $INSTDIR ; for working directory 169​SetOutPath $INSTDIR ; for working directory
168@{shortcuts} 170​@{shortcuts}
169CreateShortCut "$SMPROGRAMS\$StartMenuFolder\Uninstall.lnk" "$INSTDIR\uninstall.exe" 171​CreateShortCut "$SMPROGRAMS\$StartMenuFolder\Uninstall.lnk" "$INSTDIR\uninstall.exe"
170!insertmacro MUI_STARTMENU_WRITE_END 172​!insertmacro MUI_STARTMENU_WRITE_END
171SectionEnd 173​SectionEnd
172 174​
Show All 30 Lines