Differential D1917 Diff 4609 src/plugins/runner/gdal/GdalRunner.cpp

Changeset View

Standalone View

View Options

src/plugins/runner/gdal/GdalRunner.cpp

  • This file was added.
1​//
2​// This file is part of the Marble Virtual Globe.
3​//
4​// This program is free software licensed under the GNU LGPL. You can
5​// find a copy of this license in LICENSE.txt in the top directory of
6​// the source code.
7​//
8​// Copyright 2016 Chris Hills <chaz@chaz6.com>
9​
10​#include "GdalRunner.h"
11​
12​#include "GeoDataDocument.h"
13​#include "GeoDataPlacemark.h"
14​#include "GeoDataPolygon.h"
15​#include "GeoDataSchema.h"
16​#include "GeoDataSimpleField.h"
17​#include "GeoDataStyle.h"
18​#include "GeoDataPolyStyle.h"
19​#include "MarbleDebug.h"
20​
21​#include <QtCore/QFileInfo>
22​
kossebauUnsubmitted
Not Done

No QtCore module prefix, please.

kossebau: No QtCore module prefix, please.
23​#include <gdal_priv.h>
24​#include <ogrsf_frmts.h>
25​
26​namespace Marble
27​{
28​
29​GdalRunner::GdalRunner(QObject *parent) :
30​ ParsingRunner(parent)
31​{
32​}
33​
34​GdalRunner::~GdalRunner()
35​{
36​}
37​
38​GeoDataDocument *GdalRunner::parseFile( const QString &fileName, DocumentRole role, QString &error )
39​{
40​
41​ GDALDataset *gDataset;
42​ gDataset = static_cast<GDALDataset*>( GDALOpenEx( fileName.toStdString().c_str(), GDAL_OF_VECTOR, NULL, NULL, NULL ) );
43​
44​ if ( gDataset == NULL ) {
45​ error = QString("Failed to read %1").arg(fileName);
kossebauUnsubmitted
Not Done

No NULL please., this is C++ :) 0 should work here.

kossebau: No NULL please., this is C++ :) 0 should work here.
46​ mDebug() << error;
47​ return nullptr;
48​ }
49​
50​ if ( gDataset->GetLayerCount() < 1 ) {
51​ mDebug() << "No layers found!";
52​ return nullptr;
nienhueserUnsubmitted
Done

Can you update error here, too?

nienhueser: Can you update error here, too?
chaz6AuthorUnsubmitted
Done

OK!

chaz6: OK!
53​ }
54​
55​ GeoDataDocument *document = new GeoDataDocument;
56​ document->setDocumentRole( role );
57​
58​ OGRLayer *gLayer;
59​ gLayer = gDataset->GetLayer(0); // TODO: support for multiple layers
60​
61​ OGRFeature *gFeature;
62​ gLayer->ResetReading();
63​ while( ( gFeature = gLayer->GetNextFeature() ) != NULL ) {
64​ OGRGeometry *gGeometry;
65​ gGeometry = gFeature->GetGeometryRef();
66​ if( gGeometry != NULL ) {
67​ GeoDataPlacemark *placemark = 0;
68​ placemark = new GeoDataPlacemark;
69​
70​ switch( gGeometry->getGeometryType() ) {
nienhueserUnsubmitted
Done

Should this only be done when the geometry is supported below? Otherwise empty placemarks would be added

nienhueser: Should this only be done when the geometry is supported below? Otherwise empty placemarks would…
chaz6AuthorUnsubmitted
Not Done

Understood, I will move it.

chaz6: Understood, I will move it.
71​ case wkbPoint: {
72​ OGRPoint *gPoint = static_cast<OGRPoint*>( gGeometry );
73​ GeoDataPoint *point = new GeoDataPoint( gPoint->getX(), gPoint->getY(), 0, GeoDataCoordinates::Degree );
74​ document->append( placemark );
75​ placemark->setGeometry( point );
nienhueserUnsubmitted
Done

Use p.GetZ() instead of 0 here? Same for the other points below.

nienhueser: Use p.GetZ() instead of 0 here? Same for the other points below.
76​ mDebug() << "point " << placemark->name();
77​ break;
78​ }
79​ case wkbLineString: {
80​ OGRLineString *gLineString = static_cast<OGRLineString*>( gGeometry );
81​ GeoDataLineString *line = new GeoDataLineString;
82​ OGRPoint p;
83​
84​ for( int j=0; j<gLineString->getNumPoints(); ++j ) {
85​ gLineString->getPoint( j, &p );
kossebauUnsubmitted
Not Done

To transform the temporary string behind the const char* pointer returned by OGRFeature::GetFieldAsString* into a QString, use QString::fromLatin1(), or, if there is not only 7bit-latin chars in the string, but actually utf-8 encoded ones, QString::fromUtf8().
E.g.

placemark->setName(QString::fromLatin1(gFeature->GetFieldAsString(nameField)));
kossebau: To transform the temporary string behind the const char* pointer returned by OGRFeature…
86​ line->append( GeoDataCoordinates(
87​ p.getX(), p.getY(),
88​ 0, GeoDataCoordinates::Degree ) );
89​ }
90​
91​ document->append( placemark );
92​ placemark->setGeometry( line );
93​ mDebug() << "arc " << placemark->name();
94​ break;
95​ }
96​ case wkbPolygon: {
97​ OGRPolygon *gPolygon = static_cast<OGRPolygon*>( gGeometry );
98​
99​ GeoDataPolygon *polygon = new GeoDataPolygon;
100​
101​ OGRLinearRing *gLinearRing = gPolygon->getExteriorRing();
102​ GeoDataLinearRing outerRing;
103​
104​ for( int j=0; j<gLinearRing->getNumPoints(); ++j ) {
105​ OGRPoint gPoint;
106​ gLinearRing->getPoint( j, &gPoint );
107​ outerRing.append( GeoDataCoordinates(
108​ gPoint.getX(), gPoint.getY(),
109​ 0, GeoDataCoordinates::Degree ) );
110​ }
111​ polygon->setOuterBoundary( outerRing );
112​
113​ for( int j=0; j<gPolygon->getNumInteriorRings(); ++j ) {
114​ GeoDataLinearRing ring;
115​ gLinearRing = gPolygon->getInteriorRing( j );
116​ for( int k=0; k<gLinearRing->getNumPoints(); ++k ) {
117​ OGRPoint gPoint;
118​ gLinearRing->getPoint( k, &gPoint );
119​ ring.append( GeoDataCoordinates(
120​ gPoint.getX(), gPoint.getY(),
121​ 0, GeoDataCoordinates::Degree ) );
122​ }
123​ polygon->appendInnerBoundary( ring );
124​ }
125​
126​ placemark->setGeometry( polygon );
127​ document->append( placemark );
128​ mDebug() << "polygon " << placemark->name();
129​ break;
130​ }
131​ case wkbMultiPoint: {
132​ GeoDataMultiGeometry *multigeom = new GeoDataMultiGeometry;
133​
134​ OGRMultiPoint *gMultipoint = static_cast<OGRMultiPoint *>( gGeometry );
135​ for (int j=0; j < gMultipoint->getNumGeometries(); ++j ){
136​ OGRPoint *gPoint = static_cast<OGRPoint *>(gMultipoint->getGeometryRef( j ) );
137​ GeoDataPoint *point = new GeoDataPoint( gPoint->getX(), gPoint->getY(), 0, GeoDataCoordinates::Degree );
138​ multigeom->append( point );
139​ }
140​
141​ placemark->setGeometry( multigeom );
142​ document->append( placemark );
143​ mDebug() << "multipoint " << placemark->name();
144​ break;
145​ }
146​ case wkbMultiLineString: {
147​ GeoDataMultiGeometry *multigeom = new GeoDataMultiGeometry;
148​
149​ OGRMultiLineString *gMultiLineString = static_cast<OGRMultiLineString *>( gGeometry );
150​ for (int j=0; j < gMultiLineString->getNumGeometries(); ++j ){
151​ OGRLineString *gLinestring = static_cast<OGRLineString *>( gMultiLineString->getGeometryRef( j ) );
152​ GeoDataLineString *line = new GeoDataLineString;
153​
154​ OGRPoint p;
155​ for ( int k=0; k<gLinestring->getNumPoints(); ++k ) {
156​ gLinestring->getPoint( k, &p );
157​ line->append( GeoDataCoordinates(
158​ p.getX(), p.getY(),
159​ 0, GeoDataCoordinates::Degree ) );
160​ }
161​
162​ multigeom->append( line );
163​ }
164​ placemark->setGeometry( multigeom );
165​ document->append( placemark );
166​ mDebug() << "multilinestring " << placemark->name();
167​ break;
168​ }
169​ case wkbMultiPolygon: {
170​ GeoDataMultiGeometry *multigeom = new GeoDataMultiGeometry;
171​
172​ OGRMultiPolygon *gMultiPolygon = static_cast<OGRMultiPolygon *>( gGeometry );
173​ for ( int j=0; j<gMultiPolygon->getNumGeometries(); ++j ){
174​ OGRPolygon *gPolygon = static_cast<OGRPolygon *>( gMultiPolygon->getGeometryRef( j ) );
175​ GeoDataPolygon *polygon = new GeoDataPolygon;
176​
177​ OGRLinearRing *gLinearRing = gPolygon->getExteriorRing();
178​ GeoDataLinearRing outerRing;
179​ for( int k=0; j<gLinearRing->getNumPoints(); ++k ) {
180​ OGRPoint gPoint;
181​ gLinearRing->getPoint( k, &gPoint );
182​ outerRing.append( GeoDataCoordinates(
183​ gPoint.getX(), gPoint.getY(),
184​ 0, GeoDataCoordinates::Degree ) );
185​ }
186​ polygon->setOuterBoundary( outerRing );
187​
188​ for( int k=0; j<gPolygon->getNumInteriorRings(); ++j ) {
189​ GeoDataLinearRing ring;
190​ gLinearRing = gPolygon->getInteriorRing( k );
191​ for( int l=0; k<gLinearRing->getNumPoints(); ++l ) {
192​ OGRPoint gPoint;
193​ gLinearRing->getPoint( l, &gPoint );
194​ ring.append( GeoDataCoordinates(
195​ gPoint.getX(), gPoint.getY(),
196​ 0, GeoDataCoordinates::Degree ) );
197​ }
198​ polygon->appendInnerBoundary( ring );
199​ }
200​ multigeom->append( polygon );
201​ }
202​
203​ placemark->setGeometry( multigeom );
204​ document->append( placemark );
205​ mDebug() << "polygon " << placemark->name();
206​ break;
207​ }
208​ }
209​ }
210​ }
211​
212​ if ( document->size() ) {
213​ document->setFileName( fileName );
214​ return document;
215​ } else {
216​ delete document;
217​ return nullptr;
218​ }
219​
220​}
221​
222​}
223​
224​#include "moc_GdalRunner.cpp"
kossebauUnsubmitted
Not Done

Tabs sneaking in? :) Please use spaces for indentation.

kossebau: Tabs sneaking in? :) Please use spaces for indentation.
kossebauUnsubmitted
Not Done

No need for else after return

kossebau: No need for `else` after `return`