Changeset View
Changeset View
Standalone View
Standalone View
src/modeldataloader.h
Show First 20 Lines • Show All 56 Lines • ▼ Show 20 Line(s) | 55 | Q_SIGNALS: | |||
---|---|---|---|---|---|
57 | void allAlbumsData(const ModelDataLoader::ListAlbumDataType &allData); | 57 | void allAlbumsData(const ModelDataLoader::ListAlbumDataType &allData); | ||
58 | 58 | | |||
59 | void allArtistsData(const ModelDataLoader::ListArtistDataType &allData); | 59 | void allArtistsData(const ModelDataLoader::ListArtistDataType &allData); | ||
60 | 60 | | |||
61 | void allGenresData(const ModelDataLoader::ListGenreDataType &allData); | 61 | void allGenresData(const ModelDataLoader::ListGenreDataType &allData); | ||
62 | 62 | | |||
63 | void allTracksData(const ModelDataLoader::ListTrackDataType &allData); | 63 | void allTracksData(const ModelDataLoader::ListTrackDataType &allData); | ||
64 | 64 | | |||
65 | void allRadiosData(const ModelDataLoader::ListTrackDataType &radiosData); | ||||
66 | | ||||
65 | void allTrackData(const ModelDataLoader::TrackDataType &allData); | 67 | void allTrackData(const ModelDataLoader::TrackDataType &allData); | ||
astippich: are all these updateUI signals (also below) really necessary? they are not needed for the rest… | |||||
Indeed I have removed radioModified signal which was not needed in this class. For the three others, I kept a defined role for each of them:
Should it be better if I try to integrate them or at least give them some better names? jguidon: Indeed I have removed radioModified signal which was not needed in this class.
For the three… | |||||
If you rename it now to radioModified I think it is pretty consistent with the rest astippich: If you rename it now to radioModified I think it is pretty consistent with the rest | |||||
66 | 68 | | |||
67 | void tracksAdded(ModelDataLoader::ListTrackDataType newData); | 69 | void tracksAdded(ModelDataLoader::ListTrackDataType newData); | ||
68 | 70 | | |||
69 | void trackModified(const ModelDataLoader::TrackDataType &modifiedTrack); | 71 | void trackModified(const ModelDataLoader::TrackDataType &modifiedTrack); | ||
70 | 72 | | |||
71 | void trackRemoved(qulonglong removedTrackId); | 73 | void trackRemoved(qulonglong removedTrackId); | ||
72 | 74 | | |||
73 | void genresAdded(ModelDataLoader::ListGenreDataType newData); | 75 | void genresAdded(ModelDataLoader::ListGenreDataType newData); | ||
Show All 34 Lines | 87 | public Q_SLOTS: | |||
108 | void loadFrequentlyPlayedData(ElisaUtils::PlayListEntryType dataType); | 110 | void loadFrequentlyPlayedData(ElisaUtils::PlayListEntryType dataType); | ||
109 | 111 | | |||
110 | private: | 112 | private: | ||
111 | 113 | | |||
112 | void databaseTracksAdded(const ListTrackDataType &newData); | 114 | void databaseTracksAdded(const ListTrackDataType &newData); | ||
113 | 115 | | |||
114 | void databaseTrackModified(const TrackDataType &modifiedTrack); | 116 | void databaseTrackModified(const TrackDataType &modifiedTrack); | ||
115 | 117 | | |||
116 | void databaseTrackRemoved(qulonglong removedTrackId); | 118 | void databaseTrackRemoved(qulonglong removedTrackId); | ||
astippich: can these be renamed for consistency with others? | |||||
117 | 119 | | |||
118 | void databaseGenresAdded(const ListGenreDataType &newData); | 120 | void databaseGenresAdded(const ListGenreDataType &newData); | ||
119 | 121 | | |||
120 | void databaseArtistsAdded(const ListArtistDataType &newData); | 122 | void databaseArtistsAdded(const ListArtistDataType &newData); | ||
121 | 123 | | |||
122 | void databaseArtistRemoved(qulonglong removedDatabaseId); | 124 | void databaseArtistRemoved(qulonglong removedDatabaseId); | ||
123 | 125 | | |||
124 | void databaseAlbumsAdded(const ListAlbumDataType &newData); | 126 | void databaseAlbumsAdded(const ListAlbumDataType &newData); | ||
Show All 12 Lines |
are all these updateUI signals (also below) really necessary? they are not needed for the rest of the views