Differential D1917 Diff 4585 src/plugins/runner/gdal/GdalRunner.cpp

Changeset View

Standalone View

View Options

src/plugins/runner/gdal/GdalRunner.cpp

  • This file was added.
1​//
2​// This file is part of the Marble Virtual Globe.
3​//
4​// This program is free software licensed under the GNU LGPL. You can
5​// find a copy of this license in LICENSE.txt in the top directory of
6​// the source code.
7​//
8​// Copyright 2016 Chris Hills <chaz@chaz6.com>
9​
10​#include "GdalRunner.h"
11​
12​#include "GeoDataDocument.h"
13​#include "GeoDataPlacemark.h"
14​#include "GeoDataPolygon.h"
15​#include "GeoDataSchema.h"
16​#include "GeoDataSimpleField.h"
17​#include "GeoDataStyle.h"
18​#include "GeoDataPolyStyle.h"
19​#include "MarbleDebug.h"
20​
21​#include <QtCore/QFileInfo>
22​
kossebauUnsubmitted
Not Done

No QtCore module prefix, please.

kossebau: No QtCore module prefix, please.
23​#include <gdal_priv.h>
24​#include <ogrsf_frmts.h>
25​
26​namespace Marble
27​{
28​
29​GdalRunner::GdalRunner(QObject *parent) :
30​ ParsingRunner(parent)
31​{
32​}
33​
34​GdalRunner::~GdalRunner()
35​{
36​}
37​
38​GeoDataDocument *GdalRunner::parseFile( const QString &fileName, DocumentRole role, QString &error )
39​{
40​
41​ GDALDataset *gDataset;
42​ gDataset = static_cast<GDALDataset*>( GDALOpenEx( fileName.toStdString().c_str(), GDAL_OF_VECTOR, NULL, NULL, NULL ) );
43​
44​ if ( gDataset == NULL ) {
45​ error = QString("Failed to read %1").arg(fileName);
kossebauUnsubmitted
Not Done

No NULL please., this is C++ :) 0 should work here.

kossebau: No NULL please., this is C++ :) 0 should work here.
46​ mDebug() << error;
47​ return nullptr;
48​ }
49​
50​ if ( gDataset->GetLayerCount() < 1 ) {
51​ error << QString("No layers found!");
52​ mDebug() << error;
nienhueserUnsubmitted
Done

Can you update error here, too?

nienhueser: Can you update error here, too?
chaz6AuthorUnsubmitted
Done

OK!

chaz6: OK!
53​ return nullptr;
54​ }
55​
56​ GeoDataDocument *document = new GeoDataDocument;
57​ document->setDocumentRole( role );
58​
59​ OGRLayer *gLayer;
60​ gLayer = gDataset->GetLayer(0); // TODO: support for multiple layers
61​
62​ OGRFeature *gFeature;
63​ gLayer->ResetReading();
64​ while( ( gFeature = gLayer->GetNextFeature() ) != NULL ) {
65​ OGRGeometry *gGeometry;
66​ gGeometry = gFeature->GetGeometryRef();
67​ if( gGeometry != NULL ) {
68​ GeoDataPlacemark *placemark = 0;
69​ placemark = new GeoDataPlacemark;
70​
nienhueserUnsubmitted
Done

Should this only be done when the geometry is supported below? Otherwise empty placemarks would be added

nienhueser: Should this only be done when the geometry is supported below? Otherwise empty placemarks would…
chaz6AuthorUnsubmitted
Not Done

Understood, I will move it.

chaz6: Understood, I will move it.
71​ switch( gGeometry->getGeometryType() ) {
72​ case wkbPoint: {
73​ OGRPoint *gPoint = static_cast<OGRPoint*>( gGeometry );
74​ GeoDataPoint *point = new GeoDataPoint( gPoint->getX(), gPoint->getY(), 0, GeoDataCoordinates::Degree );
75​ document->append( placemark );
nienhueserUnsubmitted
Done

Use p.GetZ() instead of 0 here? Same for the other points below.

nienhueser: Use p.GetZ() instead of 0 here? Same for the other points below.
76​ placemark->setGeometry( point );
77​ mDebug() << "point " << placemark->name();
78​ break;
79​ }
80​ case wkbLineString: {
81​ OGRLineString *gLineString = static_cast<OGRLineString*>( gGeometry );
82​ GeoDataLineString *line = new GeoDataLineString;
83​ OGRPoint p;
84​
85​ for( int j=0; j<gLineString->getNumPoints(); ++j ) {
kossebauUnsubmitted
Not Done

To transform the temporary string behind the const char* pointer returned by OGRFeature::GetFieldAsString* into a QString, use QString::fromLatin1(), or, if there is not only 7bit-latin chars in the string, but actually utf-8 encoded ones, QString::fromUtf8().
E.g.

placemark->setName(QString::fromLatin1(gFeature->GetFieldAsString(nameField)));
kossebau: To transform the temporary string behind the const char* pointer returned by OGRFeature…
86​ gLineString->getPoint( j, &p );
87​ line->append( GeoDataCoordinates(
88​ p.getX(), p.getY(),
89​ 0, GeoDataCoordinates::Degree ) );
90​ }
91​
92​ document->append( placemark );
93​ placemark->setGeometry( line );
94​ mDebug() << "arc " << placemark->name();
95​ break;
96​ }
97​ case wkbPolygon: {
98​ OGRPolygon *gPolygon = static_cast<OGRPolygon*>( gGeometry );
99​
100​ GeoDataPolygon *polygon = new GeoDataPolygon;
101​
102​ OGRLinearRing *gLinearRing = gPolygon->getExteriorRing();
103​ GeoDataLinearRing outerRing;
104​
105​ for( int j=0; j<gLinearRing->getNumPoints(); ++j ) {
106​ OGRPoint gPoint;
107​ gLinearRing->getPoint( j, &gPoint );
108​ outerRing.append( GeoDataCoordinates(
109​ gPoint.getX(), gPoint.getY(),
110​ 0, GeoDataCoordinates::Degree ) );
111​ }
112​ polygon->setOuterBoundary( outerRing );
113​
114​ for( int j=0; j<gPolygon->getNumInteriorRings(); ++j ) {
115​ GeoDataLinearRing ring;
116​ gLinearRing = gPolygon->getInteriorRing( j );
117​ for( int k=0; k<gLinearRing->getNumPoints(); ++k ) {
118​ OGRPoint gPoint;
119​ gLinearRing->getPoint( k, &gPoint );
120​ ring.append( GeoDataCoordinates(
121​ gPoint.getX(), gPoint.getY(),
122​ 0, GeoDataCoordinates::Degree ) );
123​ }
124​ polygon->appendInnerBoundary( ring );
125​ }
126​
127​ document->append( placemark );
128​ placemark->setGeometry( polygon );
129​ mDebug() << "polygon " << placemark->name();
130​ break;
131​ }
132​ case wkbMultiPoint: {
133​ break;
134​ }
135​ case wkbMultiLineString: {
136​ break;
137​ }
138​ case wkbMultiPolygon: {
139​ break;
140​ }
141​ }
142​ }
143​ }
144​
145​ if ( document->size() ) {
146​ document->setFileName( fileName );
147​ return document;
148​ } else {
149​ delete document;
150​ return nullptr;
151​ }
152​
153​}
154​
155​}
156​
157​#include "moc_GdalRunner.cpp"
kossebauUnsubmitted
Not Done

Tabs sneaking in? :) Please use spaces for indentation.

kossebau: Tabs sneaking in? :) Please use spaces for indentation.
kossebauUnsubmitted
Not Done

No need for else after return

kossebau: No need for `else` after `return`